----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24710 -----------------------------------------------------------
api/src/com/cloud/network/Networks.java <https://reviews.apache.org/r/12849/#comment48820> Commenting as discussed on list - I think we should remove the check for contains(":") at this line. We weren't doing it before July 20, it's invalid as per the URI spec, and it breaks existing callers. - Dave Cahill On Aug. 6, 2013, 9:16 a.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12849/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 9:16 a.m.) > > > Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, > and Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Both BroadcastDomainType and IsolationType needed some extra code for > backwards compatibility > > > Diffs > ----- > > api/src/com/cloud/network/Networks.java c76c3d4 > api/test/com/cloud/network/NetworksTest.java 31114e8 > > Diff: https://reviews.apache.org/r/12849/diff/ > > > Testing > ------- > > > Thanks, > > daan Hoogland > >
