----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24766 -----------------------------------------------------------
Replied to Sheng's comments. api/src/com/cloud/network/Networks.java <https://reviews.apache.org/r/12849/#comment48888> Sheng, not sure if you caught the conversation around breaking backwards compatibility, but it explains these changes. the reason for using the 4-parameter URI constructor is that it creates "scheme://value" URIs, which is what this method used to do before it was changed on July 19. There is no 2-parameter URI constructor, so I guess you're proposing the 3-parameter constructor - however that creates a URI without // - see https://gist.github.com/davecahill/6170364 for an example. As for the check, this was also added in the July 19 commit - it causes Exceptions on valid input (colons in the value param are valid), which is why I'm proposing we remove it. Hope that explains it - feel free to grab me on IRC for more details if needed. - Dave Cahill On Aug. 6, 2013, 2:25 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12849/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 2:25 p.m.) > > > Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, > and Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Both BroadcastDomainType and IsolationType needed some extra code for > backwards compatibility > > > Diffs > ----- > > api/src/com/cloud/network/Networks.java c76c3d4 > api/test/com/cloud/network/NetworksTest.java 31114e8 > > Diff: https://reviews.apache.org/r/12849/diff/ > > > Testing > ------- > > > Thanks, > > daan Hoogland > >
