----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24720 -----------------------------------------------------------
As discussed on IRC Daan's aim is to allow using URIs of type lswitch:* rather than lswitch://*, so we agreed that existing code shouldn't be affected, and just lswitch behavior should be overridden. Daan, thanks for the explanation, and look forward to seeing the new patch. api/src/com/cloud/network/Networks.java <https://reviews.apache.org/r/12849/#comment48824> What I want is to have toUri work as before this commit, which broke backwards compatibility: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob;f=api/src/com/cloud/network/Networks.java;h=c76c3d4a473b5f87e8829aff1213b8d9be958190;hb=2d4464d2badc9aff842fd180bafc4c384a83a91d i.e. return new URI(scheme + "://" + value); Not this: return new URI(value.toString()); - Dave Cahill On Aug. 6, 2013, 10:41 a.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12849/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 10:41 a.m.) > > > Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, > and Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Both BroadcastDomainType and IsolationType needed some extra code for > backwards compatibility > > > Diffs > ----- > > api/src/com/cloud/network/Networks.java c76c3d4 > api/test/com/cloud/network/NetworksTest.java 31114e8 > > Diff: https://reviews.apache.org/r/12849/diff/ > > > Testing > ------- > > > Thanks, > > daan Hoogland > >
