> On July 23, 2013, 12:30 p.m., Koushik Das wrote: > > api/src/com/cloud/network/Networks.java, line 225 > > <https://reviews.apache.org/r/12849/diff/1/?file=325398#file325398line225> > > > > Why only Vlan in case of IsolationType and Vlan, Storage and Mido in > > the case of BroadcastDomainType? Earlier both used similar logic. > > > > If all system VMs (SSVM, CPVM and router VMs) are getting started after > > this then should be fine. > > > > Also ensure that upgraded setups work fine as well.
tested by instantiating a zone. There are no upgrade (database) aspects to this as far as I can see. - daan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review23686 ----------------------------------------------------------- On July 23, 2013, 10:02 a.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12849/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 10:02 a.m.) > > > Review request for cloudstack and Koushik Das. > > > Repository: cloudstack-git > > > Description > ------- > > Both BroadcastDomainType and IsolationType needed some extra code for > backwards compatibility > > > Diffs > ----- > > api/src/com/cloud/network/Networks.java c76c3d4 > > server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java > 6fafa3e > > Diff: https://reviews.apache.org/r/12849/diff/ > > > Testing > ------- > > > Thanks, > > daan Hoogland > >
