Re: BookKeeper and code-coverage - JaCoco

2018-02-28 Thread Enrico Olivelli
We are online ! https://coveralls.io/github/apache/bookkeeper/ I will create issues in order to increase code coverage for 4.8 Enrico Il mar 27 feb 2018, 18:28 Enrico Olivelli ha scritto: > > > Il mar 27 feb 2018, 18:17 Aaron Coburn ha scritto: > >> Hello Enrico, >> >> I have a number of pr

Re: BookKeeper and code-coverage - JaCoco

2018-02-27 Thread Enrico Olivelli
Il mar 27 feb 2018, 18:17 Aaron Coburn ha scritto: > Hello Enrico, > > I have a number of projects that make use of Coveralls.io< > http://Coveralls.io>, and I believe that the only way to clean up or > reset the build history of a project is to completely delete the project > (in Coveralls.io

Re: BookKeeper and code-coverage - JaCoco

2018-02-27 Thread Aaron Coburn
Hello Enrico, I have a number of projects that make use of Coveralls.io, and I believe that the only way to clean up or reset the build history of a project is to completely delete the project (in Coveralls.io) and then re-add the repository. That is t

Re: BookKeeper and code-coverage - JaCoco

2018-02-27 Thread Enrico Olivelli
Everything is up and running. We have to clean up the history of the project on Coveralls.io because of the strange integration with Jenkins. Coveralls.io uses the build #n as ID for the history: as I started a new Jenkins Job now we re-started from #1 and the history is very messy. I can't find

Re: BookKeeper and code-coverage - JaCoco

2018-02-23 Thread Sijie Guo
Change lgtm. Merged. You are unblocked for updating the jenkins job. Please remember deleting the wip jenkins job after you update the jenkins dsl. - Sijie On Fri, Feb 23, 2018 at 1:12 AM, Enrico Olivelli wrote: > Patch is ready forto review > https://github.com/apache/bookkeeper/pull/1129 > >

Re: BookKeeper and code-coverage - JaCoco

2018-02-23 Thread Enrico Olivelli
Patch is ready forto review https://github.com/apache/bookkeeper/pull/1129 Once all is working okay in master I will submit patch for standard jenkins job Il lun 19 feb 2018, 10:45 Sijie Guo ha scritto: > On Mon, Feb 19, 2018 at 12:23 AM, Enrico Olivelli > wrote: > > > News: > > I am strugglin

Re: BookKeeper and code-coverage - JaCoco

2018-02-19 Thread Sijie Guo
On Mon, Feb 19, 2018 at 12:23 AM, Enrico Olivelli wrote: > News: > I am struggling to create an aggregate code coverage report, but actually I > have troubles with (I suspect) PowerMock, which is changing classes at > runtime. > > The goal of an aggregate report is to consider in the report test

Re: BookKeeper and code-coverage - JaCoco

2018-02-19 Thread Enrico Olivelli
News: I am struggling to create an aggregate code coverage report, but actually I have troubles with (I suspect) PowerMock, which is changing classes at runtime. The goal of an aggregate report is to consider in the report test cases which "test" classes which are not bundled within the same maven

Re: BookKeeper and code-coverage - JaCoco

2018-02-15 Thread Sijie Guo
ack On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli wrote: > Il mer 14 feb 2018, 23:35 Sijie Guo ha scritto: > > > Well done, Enrico! > > > > It seems the CI job seems to be ready to get in. Can you make the Jenkins > > job as part of .test-infra? > > > > No, it s not working well. > I am work

Re: BookKeeper and code-coverage - JaCoco

2018-02-14 Thread Enrico Olivelli
Il mer 14 feb 2018, 23:35 Sijie Guo ha scritto: > Well done, Enrico! > > It seems the CI job seems to be ready to get in. Can you make the Jenkins > job as part of .test-infra? > No, it s not working well. I am working on a new maven module which will aggregate the reports of all upstream projec

Re: BookKeeper and code-coverage - JaCoco

2018-02-14 Thread Sijie Guo
Well done, Enrico! It seems the CI job seems to be ready to get in. Can you make the Jenkins job as part of .test-infra? - Sijie On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli wrote: > I have to clean up the patch but actually code coverage report makes sense > and it is reporting a 72% code

Re: BookKeeper and code-coverage - JaCoco

2018-02-14 Thread Enrico Olivelli
I have to clean up the patch but actually code coverage report makes sense and it is reporting a 72% code coverage (using coveralls.io KPI). Most cases of non covered code are about: - classes which do not have test cases in the same module (I am working on this) - classes which are not abstact but

Re: BookKeeper and code-coverage - JaCoco

2018-02-11 Thread Enrico Olivelli
Created this job on CI https://builds.apache.org/job/bookkeeper-code-coverage-wip/ I am working on a way to create a better report, using this suggestion http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-and-report-of-multiple-eclipse-plug-in-projects/ Build takes really long time with J

Re: BookKeeper and code-coverage - JaCoco

2018-02-07 Thread Enrico Olivelli
2018-02-05 22:33 GMT+01:00 Sijie Guo : > On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli > wrote: > > > Il lun 5 feb 2018, 18:11 David Rusek ha scritto: > > > > > It sounds like we didn't do anything with the info for a long time. > > Enrico, > > > I'm glad you're looking at it! Are you planning

Re: BookKeeper and code-coverage - JaCoco

2018-02-05 Thread Sijie Guo
On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli wrote: > Il lun 5 feb 2018, 18:11 David Rusek ha scritto: > > > It sounds like we didn't do anything with the info for a long time. > Enrico, > > I'm glad you're looking at it! Are you planning on filing some issues > > related to interpreting the

Re: BookKeeper and code-coverage - JaCoco

2018-02-05 Thread Enrico Olivelli
Il lun 5 feb 2018, 18:11 David Rusek ha scritto: > It sounds like we didn't do anything with the info for a long time. Enrico, > I'm glad you're looking at it! Are you planning on filing some issues > related to interpreting the coverage data and improving it? > It was long time ago when I star

Re: BookKeeper and code-coverage - JaCoco

2018-02-05 Thread David Rusek
It sounds like we didn't do anything with the info for a long time. Enrico, I'm glad you're looking at it! Are you planning on filing some issues related to interpreting the coverage data and improving it? -Dave On Mon, Feb 5, 2018 at 10:08 AM, Enrico Olivelli wrote: > Will do. > Enrico > > Il

Re: BookKeeper and code-coverage - JaCoco

2018-02-05 Thread Enrico Olivelli
Will do. Enrico Il lun 5 feb 2018, 17:45 Sijie Guo ha scritto: > Can’t remember exactly whether it is only on BC stuffs. But feel free to > try it. > > On Mon, Feb 5, 2018 at 8:43 AM Enrico Olivelli > wrote: > >> I think was due to BC tests, we can restore now that we do not have that >> shade

Re: BookKeeper and code-coverage - JaCoco

2018-02-05 Thread Sijie Guo
Can’t remember exactly whether it is only on BC stuffs. But feel free to try it. On Mon, Feb 5, 2018 at 8:43 AM Enrico Olivelli wrote: > I think was due to BC tests, we can restore now that we do not have that > shade stuff anymore > > Enrico > > Il lun 5 feb 2018, 17:40 Sijie Guo ha scritto: >

Re: BookKeeper and code-coverage - JaCoco

2018-02-05 Thread Enrico Olivelli
I think was due to BC tests, we can restore now that we do not have that shade stuff anymore Enrico Il lun 5 feb 2018, 17:40 Sijie Guo ha scritto: > Yes we disabled it long time ago. Because it failed CI with > ClassNotFoundException. > > Sijie > > On Mon, Feb 5, 2018 at 12:27 AM Enrico Olivell

Re: BookKeeper and code-coverage - JaCoco

2018-02-05 Thread Sijie Guo
Yes we disabled it long time ago. Because it failed CI with ClassNotFoundException. Sijie On Mon, Feb 5, 2018 at 12:27 AM Enrico Olivelli wrote: > Sijie, > it seems that Coveralls report is a bit outdated. > Have we have disabled it on CI ? > > see > https://coveralls.io/github/apache/bookkeepe

Re: BookKeeper and code-coverage - JaCoco

2018-02-05 Thread Enrico Olivelli
Sijie, it seems that Coveralls report is a bit outdated. Have we have disabled it on CI ? see https://coveralls.io/github/apache/bookkeeper?branch=master Enrico 2017-10-03 19:55 GMT+02:00 Enrico Olivelli : > Ok, I'll check it out. > > Il mar 3 ott 2017, 19:52 Sijie Guo ha scritto: > >> It seem

Re: BookKeeper and code-coverage - JaCoco

2017-10-03 Thread Enrico Olivelli
Ok, I'll check it out. Il mar 3 ott 2017, 19:52 Sijie Guo ha scritto: > It seems that the jacoco was not disabled at master build. so all the > master builds are still failing. I just disabled it. > > - Sijie > > On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli > wrote: > >> The problem is onl

Re: BookKeeper and code-coverage - JaCoco

2017-10-03 Thread Sijie Guo
It seems that the jacoco was not disabled at master build. so all the master builds are still failing. I just disabled it. - Sijie On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli wrote: > The problem is only on backward compatibiliy tests > I am going to disable Jacoco in master build > I wli

Re: BookKeeper and code-coverage - JaCoco

2017-09-20 Thread Enrico Olivelli
The problem is only on backward compatibiliy tests I am going to disable Jacoco in master build I wlil be back when I have news -- Enrico --- T E S T S --- Running org.apache.bookkeeper.tests.

Re: BookKeeper and code-coverage - JaCoco

2017-09-20 Thread Enrico Olivelli
Sorry, I did not try with the latest master but it should not be a problem. I will investigate and maybe revert It could be a problem related to the env, Eventually using docker will be nicer and more reproducible I will work on it asap tomorrow Enrico On mer 20 set 2017, 20:28 Sijie Guo wrote:

Re: BookKeeper and code-coverage - JaCoco

2017-09-20 Thread Sijie Guo
did you test this with current master before enabling in bookkeeper-master job? It somehow broke the jenkins. because I saw ClassNotFoundException in latest jekins build. https://builds.apache.org/blue/organizations/jenkins/bookkeeper-master/detail/bookkeeper-master/1889/pipeline On Wed, Sep 2

Re: BookKeeper and code-coverage - JaCoco

2017-09-20 Thread Enrico Olivelli
I have updated master job https://builds.apache.org/job/bookkeeper-master/ let's see the results -- Enrico 2017-08-24 10:27 GMT+02:00 Enrico Olivelli : > It seems that JaCoCo works like a charm > https://builds.apache.org/job/bookkeeper-codecoverage/3/console > https://coveralls.io/github/apache

Re: BookKeeper and code-coverage - JaCoco

2017-08-24 Thread Enrico Olivelli
It seems that JaCoCo works like a charm https://builds.apache.org/job/bookkeeper-codecoverage/3/console https://coveralls.io/github/apache/bookkeeper I will integrate it into nightly builds, the only concern is that CodeCoverage instrumentation may affect tests thoughts ? -- Enrico 2017-08-24

Re: BookKeeper and code-coverage - JaCoco

2017-08-23 Thread Jia Zhai
👍 On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli wrote: > 2017-08-23 17:34 GMT+02:00 Sijie Guo : > > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" wrote: > > > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli : > > > > > Latest news > > > > > > The build works and coveralls reports a 63% code cove

Re: BookKeeper and code-coverage - JaCoco

2017-08-23 Thread Enrico Olivelli
2017-08-23 17:34 GMT+02:00 Sijie Guo : > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" wrote: > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli : > > > Latest news > > > > The build works and coveralls reports a 63% code coverage. > > Maybe the link to the badge on readme.md is wrong, I will check > > >

Re: BookKeeper and code-coverage - JaCoco

2017-08-23 Thread Sijie Guo
On Aug 23, 2017 7:31 AM, "Enrico Olivelli" wrote: 2017-08-23 8:29 GMT+02:00 Enrico Olivelli : > Latest news > > The build works and coveralls reports a 63% code coverage. > Maybe the link to the badge on readme.md is wrong, I will check > Our core in README.md is good, but github caches images,

Re: BookKeeper and code-coverage - JaCoco

2017-08-23 Thread Enrico Olivelli
2017-08-23 8:29 GMT+02:00 Enrico Olivelli : > Latest news > > The build works and coveralls reports a 63% code coverage. > Maybe the link to the badge on readme.md is wrong, I will check > Our core in README.md is good, but github caches images, this is the good link but GitHub cached an old vers

Re: BookKeeper and code-coverage - JaCoco

2017-08-23 Thread Sijie Guo
On Tue, Aug 22, 2017 at 11:53 PM, Enrico Olivelli wrote: > I think that the coveralls badge on distributed log is broken, it still > points to and 'incubator link' > > /cc DL devs > Enrico, It is not broken. The project is using token for reporting the coverage, not naming. If you took a look

Re: BookKeeper and code-coverage - JaCoco

2017-08-22 Thread Enrico Olivelli
I think that the coveralls badge on distributed log is broken, it still points to and 'incubator link' /cc DL devs On mer 23 ago 2017, 08:29 Enrico Olivelli wrote: > Latest news > > The build works and coveralls reports a 63% code coverage. > Maybe the link to the badge on readme.md is wrong,

Re: BookKeeper and code-coverage - JaCoco

2017-08-22 Thread Enrico Olivelli
Latest news The build works and coveralls reports a 63% code coverage. Maybe the link to the badge on readme.md is wrong, I will check Cobertura reports a lot of parsing errors, I will continue to try JaCoCo I will try on DL to in case we have to switch Enrico On mar 22 ago 2017, 22:00 Enrico O

Re: BookKeeper and code-coverage - JaCoco

2017-08-22 Thread Enrico Olivelli
2017-08-22 21:52 GMT+02:00 Sijie Guo : > Hi Enrico, > > You should use 'ubuntu' rather than 'Ubuntu' (it is case sensitive). It is > running now - > https://builds.apache.org/job/bookkeeper-codecoverage/1/console > > Thank you. I thought I had tried but without success. > Also It would be good

Re: BookKeeper and code-coverage - JaCoco

2017-08-22 Thread Sijie Guo
Hi Enrico, You should use 'ubuntu' rather than 'Ubuntu' (it is case sensitive). It is running now - https://builds.apache.org/job/bookkeeper-codecoverage/1/console Also It would be good to put code-coverage into https://builds.apache.org/job/bookkeeper-release-nightly-snapshot/ eventually. - Si

Re: BookKeeper and code-coverage - JaCoco

2017-08-21 Thread Sijie Guo
I will check it tomorrow. On Aug 20, 2017 1:23 AM, "Enrico Olivelli" wrote: > Sijie, > I am not able to make the new job run > https://builds.apache.org/job/bookkeeper-codecoverage/ > > I cannot find any available node, I tried with ubumtu and haddop, with > different cases for the first char >

Re: BookKeeper and code-coverage - JaCoco

2017-08-20 Thread Enrico Olivelli
Sijie, I am not able to make the new job run https://builds.apache.org/job/bookkeeper-codecoverage/ I cannot find any available node, I tried with ubumtu and haddop, with different cases for the first char Ideas? Enrico On sab 19 ago 2017, 15:35 Enrico Olivelli wrote: > I have created a new je

Re: BookKeeper and code-coverage - JaCoco

2017-08-19 Thread Enrico Olivelli
I have created a new jenkins job https://builds.apache.org/job/bookkeeper-codecoverage/ emails will be sent to my address eolive...@apache.org I am playing with cobertura, if I won't succeed I will create a PR in order to introduce the configuration of JaCoCo on master branch Enrico 2017-08-04

Re: BookKeeper and code-coverage - JaCoco

2017-08-04 Thread Sijie Guo
Sure go for it. Sijie On Aug 4, 2017 12:46 PM, "Enrico Olivelli" wrote: > Il gio 20 lug 2017, 17:06 Enrico Olivelli ha > scritto: > > > Jacoco is running as expected > > see: > > https://coveralls.io/jobs/27785961 > > > > I think it is better to switch to Jacoco > > > > I wonder why on DL ther

Re: BookKeeper and code-coverage - JaCoco

2017-08-04 Thread Enrico Olivelli
Il gio 20 lug 2017, 17:06 Enrico Olivelli ha scritto: > Jacoco is running as expected > see: > https://coveralls.io/jobs/27785961 > > I think it is better to switch to Jacoco > > I wonder why on DL there is no such problem with Cobertura > @Sijie do you have any idea ? > Other opinions? I am goi

Re: BookKeeper and code-coverage - JaCoco

2017-07-20 Thread Enrico Olivelli
Jacoco is running as expected see: https://coveralls.io/jobs/27785961 I think it is better to switch to Jacoco I wonder why on DL there is no such problem with Cobertura @Sijie do you have any idea ? -- Enrico 2017-07-20 16:06 GMT+02:00 Enrico Olivelli : > I am sorry but it seems that cober

Re: BookKeeper and code-coverage - JaCoco

2017-07-20 Thread Enrico Olivelli
I am sorry but it seems that cobertura is not working with java8, as reported in Coveralls.io homepage https://github.com/trautonen/coveralls-maven-plugin see our error: https://builds.apache.org/job/bookkeeper-tests/6/console I will be back to Jacoco which seems to be the only one which support

Re: BookKeeper and code-coverage - JaCoco

2017-07-19 Thread Sijie Guo
Hmm he should mail you the token rather then posting on the jira :) On Jul 19, 2017 8:56 AM, "Enrico Olivelli" wrote: > We have the token, it is in the ticket. > I will do some tests soon > Enrico > > Il mer 19 lug 2017, 17:52 Enrico Olivelli ha > scritto: > > > this is the INFRA ticket for hav

Re: BookKeeper and code-coverage - JaCoco

2017-07-19 Thread Enrico Olivelli
We have the token, it is in the ticket. I will do some tests soon Enrico Il mer 19 lug 2017, 17:52 Enrico Olivelli ha scritto: > this is the INFRA ticket for having a coveralls.io token in our Jenkins > builds > https://issues.apache.org/jira/browse/INFRA-14649 > > -- Enrico > > 2017-07-17 23:49

Re: BookKeeper and code-coverage - JaCoco

2017-07-19 Thread Enrico Olivelli
this is the INFRA ticket for having a coveralls.io token in our Jenkins builds https://issues.apache.org/jira/browse/INFRA-14649 -- Enrico 2017-07-17 23:49 GMT+02:00 Enrico Olivelli : > > > Il lun 17 lug 2017, 22:55 Sijie Guo ha scritto: > >> On Tue, Jul 18, 2017 at 4:46 AM, Enrico Olivelli >>

Re: BookKeeper and code-coverage - JaCoco

2017-07-17 Thread Enrico Olivelli
Il lun 17 lug 2017, 22:55 Sijie Guo ha scritto: > On Tue, Jul 18, 2017 at 4:46 AM, Enrico Olivelli > wrote: > > > Il lun 17 lug 2017, 21:34 Sijie Guo ha scritto: > > > > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico Olivelli > > > wrote: > > > > > > > I have just committed coveralls.io and cobertu

Re: BookKeeper and code-coverage - JaCoco

2017-07-17 Thread Sijie Guo
On Tue, Jul 18, 2017 at 4:46 AM, Enrico Olivelli wrote: > Il lun 17 lug 2017, 21:34 Sijie Guo ha scritto: > > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico Olivelli > > wrote: > > > > > I have just committed coveralls.io and cobertura plugins into main > > pom.xml > > > (as DistributedLog does) > >

Re: BookKeeper and code-coverage - JaCoco

2017-07-17 Thread Enrico Olivelli
Il lun 17 lug 2017, 21:34 Sijie Guo ha scritto: > On Sun, Jul 16, 2017 at 8:06 PM, Enrico Olivelli > wrote: > > > I have just committed coveralls.io and cobertura plugins into main > pom.xml > > (as DistributedLog does) > > The next step is to enable cobertura and tests in Travis. > > Currently

Re: BookKeeper and code-coverage - JaCoco

2017-07-17 Thread Venkateswara Rao Jujjuri
Adding Dustin to the thread. On Wed, Jul 5, 2017 at 12:57 AM, Enrico Olivelli wrote: > I am attaching a report (I am using Google Drive as most email clients will > block attachments with html inside) . > Just untar and play with your browser > > > 2017-07-04 18:18 GMT+02:00 Dávid Szigecsán : >

Re: BookKeeper and code-coverage - JaCoco

2017-07-17 Thread Sijie Guo
On Sun, Jul 16, 2017 at 8:06 PM, Enrico Olivelli wrote: > I have just committed coveralls.io and cobertura plugins into main pom.xml > (as DistributedLog does) > The next step is to enable cobertura and tests in Travis. > Currently we do not run tests on Travis because it is very slow. > any

Re: BookKeeper and code-coverage - JaCoco

2017-07-16 Thread Enrico Olivelli
I have just committed coveralls.io and cobertura plugins into main pom.xml (as DistributedLog does) The next step is to enable cobertura and tests in Travis. Currently we do not run tests on Travis because it is very slow. any ideas ? Meanwhile I am going to submit a PR with a change in Travis

Re: BookKeeper and code-coverage - JaCoco

2017-07-06 Thread Enrico Olivelli
2017-07-05 16:13 GMT+02:00 Enrico Olivelli : > > > 2017-07-05 16:05 GMT+02:00 Sijie Guo : > >> It would be worth checking with the INFRA to see what kind of code >> coverage >> that it provides. I remembered that a few ASF projects using coveralls.io >> , >> INFRA can enable this for you and give

Re: BookKeeper and code-coverage - JaCoco

2017-07-05 Thread Enrico Olivelli
2017-07-05 16:05 GMT+02:00 Sijie Guo : > It would be worth checking with the INFRA to see what kind of code coverage > that it provides. I remembered that a few ASF projects using coveralls.io, > INFRA can enable this for you and give you an token which you can configure > in the CI job. I think c

Re: BookKeeper and code-coverage - JaCoco

2017-07-05 Thread Sijie Guo
It would be worth checking with the INFRA to see what kind of code coverage that it provides. I remembered that a few ASF projects using coveralls.io, INFRA can enable this for you and give you an token which you can configure in the CI job. I think coveralls supports JaCoco. Sijie On Jul 5, 2017

Re: BookKeeper and code-coverage - JaCoco

2017-07-05 Thread Enrico Olivelli
I am attaching a report (I am using Google Drive as most email clients will block attachments with html inside) . Just untar and play with your browser 2017-07-04 18:18 GMT+02:00 Dávid Szigecsán : > SonarCloud is free for open source. > > https://about.sonarcloud.io/ Yes I known recently we have

Re: BookKeeper and code-coverage - JaCoco

2017-07-04 Thread Dávid Szigecsán
SonarCloud is free for open source. https://about.sonarcloud.io/ 2017-07-04 18:15 GMT+02:00 Enrico Olivelli : > Il mar 4 lug 2017, 18:08 Dávid Szigecsán ha scritto: > > > +1 > > > > What do you think about sonar? :) > > > > I am using sonar in projects in my company, it is great. > But it needs

Re: BookKeeper and code-coverage - JaCoco

2017-07-04 Thread Enrico Olivelli
Il mar 4 lug 2017, 18:08 Dávid Szigecsán ha scritto: > +1 > > What do you think about sonar? :) > I am using sonar in projects in my company, it is great. But it needs a server, so it is not easy to use for everyone Enrico > > 2017-07-04 17:24 GMT+02:00 Enrico Olivelli : > > > Hi all, > > as w

Re: BookKeeper and code-coverage - JaCoco

2017-07-04 Thread Dávid Szigecsán
+1 What do you think about sonar? :) 2017-07-04 17:24 GMT+02:00 Enrico Olivelli : > Hi all, > as we are in the mood of enhancing automatic QA and quality of > BookKeeper I have created this issue in order to introduce JaCoCo in > the build/test pipeline > > https://github.com/apache/bookkeeper/i