On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <eolive...@gmail.com> wrote:
2017-08-23 8:29 GMT+02:00 Enrico Olivelli <eolive...@gmail.com>: > Latest news > > The build works and coveralls reports a 63% code coverage. > Maybe the link to the badge on readme.md is wrong, I will check > Our core in README.md is good, but github caches images, this is the good link but GitHub cached an old version of the image https://coveralls.io/repos/github/apache/bookkeeper/badge.svg?branch=master > Cobertura reports a lot of parsing errors, I will continue to try JaCoCo > I have tried with JaCoCo the result is similar, but there are no "scary" message on console output like this: net.sourceforge.cobertura.javancss.parser.ParseException: Encountered " "default" "default "" at line 332, column 5. Was expecting one of: "abstract" ... "boolean" ... "byte" ... "char" ... "class" ... "double" ... "enum" ... "final" ... "float" ... "int" ... "interface" ... "long" ... "native" ... "private" ... "protected" ... "public" ... "short" ... "static" ... "strictfp" ... "synchronized" ... "transient" ... "void" ... "volatile" ... <IDENTIFIER> ... "}" ... ";" ... "@" ... "<" ... at net.sourceforge.cobertura.javancss.parser.JavaParser. generateParseException(JavaParser.java:10490) at net.sourceforge.cobertura.javancss.parser.JavaParser.jj_ consume_token(JavaParser.java:10366) at net.sourceforge.cobertura.javancss.parser.JavaParser. UnmodifiedInterfaceDeclaration(JavaParser.java:1475) at net.sourceforge.cobertura.javancss.parser.JavaParser. InterfaceDeclaration(JavaParser.java:1273) at net.sourceforge.cobertura.javancss.parser.JavaParser. TypeDeclaration(JavaParser.java:580) at net.sourceforge.cobertura.javancss.parser.JavaParser. CompilationUnit(JavaParser.java:318) at net.sourceforge.cobertura.javancss.parser.JavaParser. parse(JavaParser.java:100) at net.sourceforge.cobertura.javancss.Javancss._ measureSource(Javancss.java:192) at net.sourceforge.cobertura.javancss.Javancss._ measureRoot(Javancss.java:268) at net.sourceforge.cobertura.javancss.Javancss.<init>( Javancss.java:347) at net.sourceforge.cobertura.javancss.JavancssFactory. newInstance(JavancssFactory.java:40) at net.sourceforge.cobertura.reporting.ComplexityCalculator. getFunctionMetricsForSingleFile(ComplexityCalculator.java:243) Maybe it is better to switch to JaCoCo, Cobertura wants to read java code but cannot handle Java8 default methods interface syntax Issue: https://github.com/apache/bookkeeper/issues/464 Patch to introduce the configuration: https://github.com/apache/bookkeeper/pull/465 Good job! I made one comment in the pull request. Otherwise, overall looks good. Once we have a stable code coverage tool I would like to setup an automatic check upon Pull Requests Sure, are you planning to enforce pull request should increase coverage? Thoughts ? Enrico I will try on DL to in case we have to switch > > Enrico > > On mar 22 ago 2017, 22:00 Enrico Olivelli <eolive...@gmail.com> wrote: > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <guosi...@gmail.com>: >> >>> Hi Enrico, >>> >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case sensitive). It >>> is >>> running now - >>> https://builds.apache.org/job/bookkeeper-codecoverage/1/console >>> >>> >> Thank you. I thought I had tried but without success. >> >> >>> Also It would be good to put code-coverage into >>> https://builds.apache.org/job/bookkeeper-release-nightly-snapshot/ >>> eventually. >>> >> >> I will play and the integrate the two jobs >> >> Thank you very much >> Enrico >> >> >>> >>> - Sijie >>> >>> >>> >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <guosi...@gmail.com> wrote: >>> >>> > I will check it tomorrow. >>> > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <eolive...@gmail.com> >>> wrote: >>> > >>> >> Sijie, >>> >> I am not able to make the new job run >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/ >>> >> >>> >> I cannot find any available node, I tried with ubumtu and haddop, with >>> >> different cases for the first char >>> >> >>> >> Ideas? >>> >> Enrico >>> >> >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <eolive...@gmail.com> >>> wrote: >>> >> >>> >> > I have created a new jenkins job >>> >> > https://builds.apache.org/job/bookkeeper-codecoverage/ >>> >> > >>> >> > emails will be sent to my address eolive...@apache.org >>> >> > >>> >> > I am playing with cobertura, if I won't succeed I will create a PR >>> in >>> >> > order to introduce the configuration of JaCoCo on master branch >>> >> > >>> >> > Enrico >>> >> > >>> >> > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <guosi...@gmail.com>: >>> >> > >>> >> >> Sure go for it. >>> >> >> >>> >> >> Sijie >>> >> >> >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <eolive...@gmail.com> >>> >> wrote: >>> >> >> >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <eolive...@gmail.com> >>> ha >>> >> >> > scritto: >>> >> >> > >>> >> >> > > Jacoco is running as expected >>> >> >> > > see: >>> >> >> > > https://coveralls.io/jobs/27785961 >>> >> >> > > >>> >> >> > > I think it is better to switch to Jacoco >>> >> >> > > >>> >> >> > > I wonder why on DL there is no such problem with Cobertura >>> >> >> > > @Sijie do you have any idea ? >>> >> >> > > >>> >> >> > >>> >> >> > Other opinions? I am going to test codecov.io too in other >>> projects >>> >> and >>> >> >> > compare the results >>> >> >> > >>> >> >> > Enrico >>> >> >> > >>> >> >> > >>> >> >> > > >>> >> >> > > -- Enrico >>> >> >> > > >>> >> >> > > >>> >> >> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli < >>> eolive...@gmail.com>: >>> >> >> > > >>> >> >> > >> I am sorry but it seems that cobertura is not working with >>> java8, >>> >> as >>> >> >> > >> reported in Coveralls.io homepage >>> >> >> > >> https://github.com/trautonen/coveralls-maven-plugin >>> >> >> > >> >>> >> >> > >> >>> >> >> > >> see our error: >>> >> >> > >> https://builds.apache.org/job/bookkeeper-tests/6/console >>> >> >> > >> >>> >> >> > >> I will be back to Jacoco which seems to be the only one which >>> >> >> supports >>> >> >> > >> java8 for Coveralls >>> >> >> > >> >>> >> >> > >> -- Enrico >>> >> >> > >> >>> >> >> > >> >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <guosi...@gmail.com>: >>> >> >> > >> >>> >> >> > >>> Hmm he should mail you the token rather then posting on the >>> jira >>> >> :) >>> >> >> > >>> >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" < >>> eolive...@gmail.com> >>> >> >> > wrote: >>> >> >> > >>> >>> >> >> > >>> > We have the token, it is in the ticket. >>> >> >> > >>> > I will do some tests soon >>> >> >> > >>> > Enrico >>> >> >> > >>> > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli < >>> eolive...@gmail.com >>> >> > >>> >> >> ha >>> >> >> > >>> > scritto: >>> >> >> > >>> > >>> >> >> > >>> > > this is the INFRA ticket for having a coveralls.io >>> token in >>> >> our >>> >> >> > >>> Jenkins >>> >> >> > >>> > > builds >>> >> >> > >>> > > https://issues.apache.org/jira/browse/INFRA-14649 >>> >> >> > >>> > > >>> >> >> > >>> > > -- Enrico >>> >> >> > >>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico Olivelli < >>> >> eolive...@gmail.com >>> >> >> >: >>> >> >> > >>> > > >>> >> >> > >>> > >> >>> >> >> > >>> > >> >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <guosi...@gmail.com > >>> ha >>> >> >> > >>> scritto: >>> >> >> > >>> > >> >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico Olivelli < >>> >> >> > >>> eolive...@gmail.com> >>> >> >> > >>> > >>> wrote: >>> >> >> > >>> > >>> >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo < >>> guosi...@gmail.com> >>> >> ha >>> >> >> > >>> scritto: >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico Olivelli < >>> >> >> > >>> > >>> eolive...@gmail.com> >>> >> >> > >>> > >>> > > wrote: >>> >> >> > >>> > >>> > > >>> >> >> > >>> > >>> > > > I have just committed coveralls.io and cobertura >>> >> >> plugins >>> >> >> > >>> into >>> >> >> > >>> > main >>> >> >> > >>> > >>> > > pom.xml >>> >> >> > >>> > >>> > > > (as DistributedLog does) >>> >> >> > >>> > >>> > > > The next step is to enable cobertura and tests in >>> >> >> Travis. >>> >> >> > >>> > >>> > > > Currently we do not run tests on Travis because >>> it is >>> >> >> very >>> >> >> > >>> > >>> slow..... >>> >> >> > >>> > >>> > > > any ideas ? >>> >> >> > >>> > >>> > > > >>> >> >> > >>> > >>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls token for reporting >>> the >>> >> >> > coverage >>> >> >> > >>> > >>> results. >>> >> >> > >>> > >>> > > Jenkins is probably better for this purpose >>> because the >>> >> >> token >>> >> >> > >>> has >>> >> >> > >>> > to >>> >> >> > >>> > >>> be >>> >> >> > >>> > >>> > > store secretly. >>> >> >> > >>> > >>> > > >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > In this doc it seems that using the coveralls plugin >>> >> inside >>> >> >> a >>> >> >> > >>> travis >>> >> >> > >>> > >>> build >>> >> >> > >>> > >>> > does not require tokens >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> https://github.com/trautonen/ >>> coveralls-maven-plugin/blob/ >>> >> >> > >>> > master/README.md >>> >> >> > >>> > >>> >>> >> >> > >>> > >>> >>> >> >> > >>> > >>> >>> >> >> > >>> > >>> I barely remembered that it doesn't actually work, but >>> I >>> >> >> might be >>> >> >> > >>> > wrong. >>> >> >> > >>> > >>> >>> >> >> > >>> > >> >>> >> >> > >>> > >> I just pinged infra, my email was not responded >>> >> >> > >>> > >> >>> >> >> > >>> > >> Enrico >>> >> >> > >>> > >> >>> >> >> > >>> > >>> >>> >> >> > >>> > >>> >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > Enrico >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > > >>> >> >> > >>> > >>> > > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a PR with a >>> change in >>> >> >> Travis >>> >> >> > >>> > config >>> >> >> > >>> > >>> in >>> >> >> > >>> > >>> > > order >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis >>> >> >> > >>> > >>> > > > >>> >> >> > >>> > >>> > > > -- Enrico >>> >> >> > >>> > >>> > > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico Olivelli < >>> >> >> > >>> eolive...@gmail.com >>> >> >> > >>> > >: >>> >> >> > >>> > >>> > > > >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00 Enrico Olivelli < >>> >> >> > >>> > eolive...@gmail.com >>> >> >> > >>> > >>> >: >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00 Sijie Guo < >>> >> >> > guosi...@gmail.com >>> >> >> > >>> >: >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > >>> It would be worth checking with the INFRA to >>> see >>> >> >> what >>> >> >> > >>> kind of >>> >> >> > >>> > >>> code >>> >> >> > >>> > >>> > > > >>> coverage >>> >> >> > >>> > >>> > > > >>> that it provides. I remembered that a few ASF >>> >> >> projects >>> >> >> > >>> using >>> >> >> > >>> > >>> > > > >>> coveralls.io, >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you and give you an >>> >> token >>> >> >> > >>> which you >>> >> >> > >>> > >>> can >>> >> >> > >>> > >>> > > > >>> configure >>> >> >> > >>> > >>> > > > >>> in the CI job. I think coveralls supports >>> JaCoco. >>> >> >> > >>> > >>> > > > >>> >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA and come back >>> with >>> >> the >>> >> >> > >>> response >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > no answer from INFRA >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with coveralls.io and >>> I >>> >> found >>> >> >> > the >>> >> >> > >>> our >>> >> >> > >>> > >>> repo >>> >> >> > >>> > >>> > is >>> >> >> > >>> > >>> > > > > somehow already configured, see >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/apache/bookkeeper >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > It seams that in order to have such service use >>> >> have >>> >> >> to >>> >> >> > >>> include >>> >> >> > >>> > >>> > JaCoCo >>> >> >> > >>> > >>> > > > > maven plugin, then enable some automatic build >>> >> using >>> >> >> > >>> Jenkins or >>> >> >> > >>> > >>> > Travis >>> >> >> > >>> > >>> > > > and >>> >> >> > >>> > >>> > > > > then add another coveralls plugin >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > see this interesting document >>> >> >> > >>> > >>> > > > > https://github.com/ >>> asciidoctor/asciidoctor/wiki/ >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-for-maven-projects >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > I think that the starting point is to integrate >>> >> JaCoco >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > -- Enrico >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > >> -- Enrico >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > >>> >>> >> >> > >>> > >>> > > > >>> Sijie >>> >> >> > >>> > >>> > > > >>> >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM, "Enrico Olivelli" < >>> >> >> > >>> > eolive...@gmail.com >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > > wrote: >>> >> >> > >>> > >>> > > > >>> >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I am using Google >>> >> Drive >>> >> >> as >>> >> >> > >>> most >>> >> >> > >>> > >>> email >>> >> >> > >>> > >>> > > > clients >>> >> >> > >>> > >>> > > > >>> will >>> >> >> > >>> > >>> > > > >>> > block attachments with html inside) . >>> >> >> > >>> > >>> > > > >>> > Just untar and play with your browser >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00 Dávid Szigecsán >>> < >>> >> >> > >>> > >>> sige...@gmail.com>: >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for open source. >>> >> >> > >>> > >>> > > > >>> > > >>> >> >> > >>> > >>> > > > >>> > > https://about.sonarcloud.io/ >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> > Yes I known >>> >> >> > >>> > >>> > > > >>> > recently we have activated Travis CI, I >>> think >>> >> that >>> >> >> > the >>> >> >> > >>> > trend >>> >> >> > >>> > >>> is >>> >> >> > >>> > >>> > to >>> >> >> > >>> > >>> > > > >>> > integrate with such free tools in order to >>> >> achieve >>> >> >> > the >>> >> >> > >>> best >>> >> >> > >>> > >>> > quality >>> >> >> > >>> > >>> > > > >>> with >>> >> >> > >>> > >>> > > > >>> > the minimum effort >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> > -- Enrico >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15 GMT+02:00 Enrico >>> Olivelli < >>> >> >> > >>> > >>> > eolive...@gmail.com >>> >> >> > >>> > >>> > > >: >>> >> >> > >>> > >>> > > > >>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08 Dávid >>> Szigecsán < >>> >> >> > >>> > >>> sige...@gmail.com> >>> >> >> > >>> > >>> > ha >>> >> >> > >>> > >>> > > > >>> > scritto: >>> >> >> > >>> > >>> > > > >>> > >> >>> >> >> > >>> > >>> > > > >>> > >> > +1 >>> >> >> > >>> > >>> > > > >>> > >> > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think about sonar? :) >>> >> >> > >>> > >>> > > > >>> > >> > >>> >> >> > >>> > >>> > > > >>> > >> >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in projects in my >>> company, >>> >> it >>> >> >> is >>> >> >> > >>> great. >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server, so it is not >>> easy to >>> >> use >>> >> >> > for >>> >> >> > >>> > >>> everyone >>> >> >> > >>> > >>> > > > >>> > >> >>> >> >> > >>> > >>> > > > >>> > >> Enrico >>> >> >> > >>> > >>> > > > >>> > >> >>> >> >> > >>> > >>> > > > >>> > >> > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24 GMT+02:00 Enrico >>> >> Olivelli < >>> >> >> > >>> > >>> > > eolive...@gmail.com >>> >> >> > >>> > >>> > > > >: >>> >> >> > >>> > >>> > > > >>> > >> > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all, >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the mood of enhancing >>> >> >> automatic >>> >> >> > QA >>> >> >> > >>> and >>> >> >> > >>> > >>> > quality >>> >> >> > >>> > >>> > > of >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have created this >>> issue in >>> >> >> order >>> >> >> > to >>> >> >> > >>> > >>> introduce >>> >> >> > >>> > >>> > > > >>> JaCoCo in >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test pipeline >>> >> >> > >>> > >>> > > > >>> > >> > > >>> >> >> > >>> > >>> > > > >>> > >> > > https://github.com/apache/ >>> >> >> > bookkeeper/issues/232 >>> >> >> > >>> > >>> > > > >>> > >> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests and report to >>> the >>> >> >> > comunity >>> >> >> > >>> > >>> > > > >>> > >> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico >>> >> >> > >>> > >>> > > > >>> > >> > > >>> >> >> > >>> > >>> > > > >>> > >> > >>> >> >> > >>> > >>> > > > >>> > >> -- >>> >> >> > >>> > >>> > > > >>> > >> >>> >> >> > >>> > >>> > > > >>> > >> >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli >>> >> >> > >>> > >>> > > > >>> > >> >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> > bookkeeper-server-jacoco.tar.gz >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/ >>> file/d/0Bz7lsWhNTGF- >>> >> >> > >>> > OVZFblRpZE00Nz >>> >> >> > >>> > >>> > > > >>> A/view?usp= >>> >> >> > >>> > >>> > > > >>> > drive_web> >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> > >>> >> >> > >>> > >>> > > > >>> >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > >> >>> >> >> > >>> > >>> > > > > >>> >> >> > >>> > >>> > > > >>> >> >> > >>> > >>> > > >>> >> >> > >>> > >>> > -- >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> > -- Enrico Olivelli >>> >> >> > >>> > >>> > >>> >> >> > >>> > >>> >>> >> >> > >>> > >> -- >>> >> >> > >>> > >> >>> >> >> > >>> > >> >>> >> >> > >>> > >> -- Enrico Olivelli >>> >> >> > >>> > >> >>> >> >> > >>> > > >>> >> >> > >>> > > -- >>> >> >> > >>> > >>> >> >> > >>> > >>> >> >> > >>> > -- Enrico Olivelli >>> >> >> > >>> > >>> >> >> > >>> >>> >> >> > >> >>> >> >> > >> >>> >> >> > > -- >>> >> >> > >>> >> >> > >>> >> >> > -- Enrico Olivelli >>> >> >> > >>> >> >> >>> >> > >>> >> > -- >>> >> >>> >> >>> >> -- Enrico Olivelli >>> >> >>> > >>> >> -- > > > -- Enrico Olivelli >
