On Fri, 8 Nov 2024 10:42:15 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Fri, 11 Oct 2024 15:49:33 GMT, Chen Liang wrote:
>> Please review this patch that:
>> 1. Implemented `forEach` to optimize for 1 or 2 element collections.
>> 2. Implemented `spliterator` to optimize for a single element.
>>
>> The default implementations for multiple-element immutable collect
On Tue, 29 Oct 2024 17:06:08 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/MouseInfo.java line 68:
>>
>>> 66: * @throws SecurityException if a security manager exists and its
>>> 67: *{@code checkPermission} method doesn't allow the
>>> operation
>
On Fri, 8 Nov 2024 11:31:40 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Put back @SuppressWarnings annotations to be fixed by JDK-8343286.
-
Changes:
- a
On Fri, 8 Nov 2024 16:59:48 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch fixes the deadlock in `TestMemorySession#testAcquireCloseRace`.
>> The lock-step spin lock is implemented as with `lock` being an
>> `AtomicInteger`:
>>
>> // Keep the 2 threads operating on the same scope
>>
On Fri, 8 Nov 2024 10:10:28 GMT, Eirik Bjørsnøs wrote:
> Please review this doc-only enhancement which links the word _equivalent_ in
> `Float.NaN` and `Double.NaN` constant field descriptions to the
> floating-point equivalence discussion in `Double`.
>
>> It is equivalent to the value retu
On Fri, 8 Nov 2024 12:22:54 GMT, Maurizio Cimadamore
wrote:
>> Hi,
>>
>> This patch fixes the deadlock in `TestMemorySession#testAcquireCloseRace`.
>> The lock-step spin lock is implemented as with `lock` being an
>> `AtomicInteger`:
>>
>> // Keep the 2 threads operating on the same scop
On Thu, 7 Nov 2024 18:30:22 GMT, Vladimir Ivanov wrote:
>> The synchronization block may be substituted by the 'volatile' variable
>> smaller synchronization block.
>> It reduce the total blocking time for the specjvm2008::xml.validation
>> workload and improve the reported score.
>> Scores for
On Wed, 30 Oct 2024 11:05:17 GMT, Magnus Ihse Bursie wrote:
>> make/scripts/compare.sh line 1457:
>>
>>> 1455: THIS_SEC_BIN="$THIS_SEC_DIR/sec-bin.zip"
>>> 1456: if [ "$OPENJDK_TARGET_OS" = "windows" ]; then
>>> 1457: JGSS_WINDOWS_BIN="jgss-windows-x64-bin.zip"
>>
>>
On Thu, 7 Nov 2024 22:31:21 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> system
On Fri, 8 Nov 2024 13:56:38 GMT, Viktor Klang wrote:
>> Make final adjustments to drop PreviewFeature and updating the @ since
>> markers.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating the copyright year of the
On Fri, 8 Nov 2024 13:49:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main cha
On Fri, 1 Nov 2024 18:06:47 GMT, Alexey Ivanov wrote:
> > I'd not looked at this test before but when I do the thing I noticed is
> > that createPrivateValue is no longer used. But I don't see a problem with
> > keeping the rest of the test.
>
> @prrace Do I understand correctly that _“`create
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Thu, 7 Nov 2024 22:31:21 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> system
On Fri, 8 Nov 2024 04:40:15 GMT, Jaikiran Pai wrote:
> Hello Naoto, this looks good to me. The test itself could assert that the
> printed timezone is indeed the default timezone, but if you prefer it in its
> current form, that's fine too.
Thank you, Jai. I considererd that too, i.e. affirmin
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains ei
On Fri, 8 Nov 2024 11:31:40 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Fri, 8 Nov 2024 18:26:25 GMT, Saint Wesonga wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Inline buildJniFunctionName
>
> src/hotspot/os/posix/include/jvm_md.h line 41:
>
>> 39:
>> 40: #define JNI_ONLO
On Fri, 8 Nov 2024 11:31:40 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Thu, 7 Nov 2024 23:36:39 GMT, Naoto Sato wrote:
> A small enhancement in the Java launcher. For diagnostic purposes, display
> the default time zone ID with the `-XshowSettings` option.
This pull request has now been integrated.
Changeset: 03298558
Author:Naoto Sato
URL:
https:/
On Thu, 7 Nov 2024 23:36:39 GMT, Naoto Sato wrote:
> A small enhancement in the Java launcher. For diagnostic purposes, display
> the default time zone ID with the `-XshowSettings` option.
Thank you for your reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/21965#issuecommen
On Fri, 8 Nov 2024 08:15:32 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
>> instruction for following IR pallets.
>>
>>
>>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>>MulVL (URShiftVL SRC1 , 32) (U
On Fri, 8 Nov 2024 17:07:55 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
Use the built-in file system provider rather than the custom file system
provider.
Add "public static FileSystemProvider create" method in
DefaultFileSystemProvider which is from java8API to be compatible against
runtime.
-
Commit messages:
- 8331467: Fix JDK-8331467 ImageReaderFa
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unused warnings and addressed all of them by commenting out th
On Thu, 31 Oct 2024 19:07:42 GMT, Chris Plummer wrote:
>>> I do wonder if mutex support can be implemented for Windows with
>>> Acquire/ReleaseSRWLockExclusive. I know it's not strictly needed, but it
>>> would be nice to have. Shame threads.h is not available with some Visual
>>> Studio versi
On Thu, 17 Oct 2024 03:37:38 GMT, jyxzwd wrote:
> Use the built-in file system provider rather than the custom file system
> provider.
> Add "public static FileSystemProvider create" method in
> DefaultFileSystemProvider which is from java8API to be compatible against
> runtime.
This pull req
Use the built-in file system provider rather than the custom file system
provider.
Add "public static FileSystemProvider create" method in
DefaultFileSystemProvider which is from java8API to be compatible against
runtime.
-
Commit messages:
- 8331467: Fix JDK-8331467 ImageReaderFa
On Sat, 9 Nov 2024 04:26:55 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> un
Can I please get a review for this PR that add tests to verify the value of
`@since` tags to the Tools area modules. The test is described in this
[email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
The benefit from this is helping API authors and reviewer validate the
On Fri, 8 Nov 2024 10:42:15 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Fri, 8 Nov 2024 16:13:28 GMT, Per Minborg wrote:
> This PR proposed to add a few benchmarks using superword/autovectorization
This pull request has now been integrated.
Changeset: 2fb0c1dd
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/2fb0c1dd62f1c690cf6b78f5cdfe18b
On Fri, 8 Nov 2024 16:13:28 GMT, Per Minborg wrote:
> This PR proposed to add a few benchmarks using superword/autovectorization
Marked as reviewed by mcimadamore (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21988#pullrequestreview-2424305115
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
On Fri, 8 Nov 2024 17:07:55 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Fri, 8 Nov 2024 11:31:40 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Fri, 8 Nov 2024 10:42:15 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Fri, 8 Nov 2024 11:56:08 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch fixes the deadlock in `TestMemorySession#testAcquireCloseRace`.
> The lock-step spin lock is implemented as with `lock` being an
> `AtomicInteger`:
>
> // Keep the 2 threads operating on the same scope
> int k =
On Fri, 8 Nov 2024 11:56:08 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch fixes the deadlock in `TestMemorySession#testAcquireCloseRace`.
> The lock-step spin lock is implemented as with `lock` being an
> `AtomicInteger`:
>
> // Keep the 2 threads operating on the same scope
> int k =
On Fri, 8 Nov 2024 13:56:38 GMT, Viktor Klang wrote:
>> Make final adjustments to drop PreviewFeature and updating the @ since
>> markers.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating the copyright year of the
On Fri, 1 Nov 2024 20:26:45 GMT, Alexey Ivanov wrote:
>>> Is it intentional?
>>
>> It was probably by mistake. but you are right, I see it mentioned already in
>> the doc. I don't think we need to mention it again?
>
> It has a value… when it's mentioned with `@see`, the link is present in the
This PR proposed to add a few benchmarks using superword/autovectorization
-
Commit messages:
- Add benchmarks
Changes: https://git.openjdk.org/jdk/pull/21988/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21988&range=00
Issue: https://bugs.openjdk.org/browse/JDK-834384
On Fri, 8 Nov 2024 16:17:39 GMT, Chen Liang wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating the copyright year of the Gatherer benchmarks
>
> The removal of preview toggles look good. Confirmed that since
> Hi,
>
> This patch fixes the deadlock in `TestMemorySession#testAcquireCloseRace`.
> The lock-step spin lock is implemented as with `lock` being an
> `AtomicInteger`:
>
> // Keep the 2 threads operating on the same scope
> int k = lock.getAndAdd(1) + 1;
> while (k != i * 2) {
>
On Fri, 8 Nov 2024 13:39:08 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> un
On Sun, 6 Oct 2024 10:24:53 GMT, Quan Anh Mai wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> [vectorapi] Refactor VectorShuffle implementation
>
> I have adapted the patch in accordance
On Fri, 8 Nov 2024 20:25:10 GMT, Vladimir Ivanov wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Creating specialized IR to shield pattern from subsequent transforms in
>> optimization pipeline
>
> src/hotspot/sh
On Thu, 7 Nov 2024 13:27:41 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Wed, 16 Oct 2024 16:23:41 GMT, Nizar Benalla wrote:
> Can I get a review for this patch that adds `@since` checker tests to the
> following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps.
> The initial test for `java.base` has been integrated in
> [JDK-8331051](https://bugs
On Fri, 8 Nov 2024 09:44:01 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Mandy's feedback
>> - Remove "jlink.runtime.linkable" property from VMProps
>>
>>It's no longer used in an
On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A
> future me chasing
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to receive feedback.
>
> The main changes are:
> - `require
> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
> instruction for following IR pallets.
>
>
>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>MulVL (URShiftVL SRC1 , 32) (URShiftVL SRC2, 32)
>MulVL (URShiftVL SRC1 , 32) ( A
On Fri, 23 Aug 2024 21:02:25 GMT, Gerard Ziemski wrote:
> Is the plan to check-in the fix with both paths? Or are we going to remove
> the linked-list based one after the review?
The plan is to have both versions available at run-time. In this plan, we will
add JVM options to let the user to s
On Thu, 1 Aug 2024 15:44:32 GMT, Afshin Zafari wrote:
> - `VMATree` is used instead of `SortedLinkList` in new class
> `VirtualMemoryTrackerWithTree`.
> - A wrapper/helper `RegionTree` is made around VMATree to make some calls
> easier.
> - Both old and new versions exist in the code and ca
On Fri, 9 Aug 2024 16:05:00 GMT, Gerard Ziemski wrote:
> > > Is there a concrete advantage here for using lambda expression when
> > > iterating committed regions? I'm asking because personally I find
> > > ```c++
> > > while ((committed_rgn = itr.next()) != nullptr) {
> > > print_comm
On Mon, 26 Aug 2024 07:16:39 GMT, Afshin Zafari wrote:
> > Is the plan to check-in the fix with both paths? Or are we going to remove
> > the linked-list based one after the review?
>
> The plan is to have both versions available at run-time. In this plan, we
> will add JVM options to let the
On Thu, 26 Sep 2024 10:58:31 GMT, Johan Sjölen wrote:
> What is the consensus on having two implementations alive at the same time?
> I'd like to see us delete the old VirtualMemoryTracker and only have the tree
> implementation left as part of this PR. What is the status of our testing? Is
>
On Fri, 27 Sep 2024 09:52:07 GMT, Afshin Zafari wrote:
> > What is the consensus on having two implementations alive at the same time?
> > I'd like to see us delete the old VirtualMemoryTracker and only have the
> > tree implementation left as part of this PR. What is the status of our
> > tes
On Mon, 26 Aug 2024 11:03:25 GMT, Johan Sjölen wrote:
> It's tedious to have to write return true; if you never return false; in the
> function. I looked into fixing this with some metaprogramming, and I found
> two C++14 solutions and one C++17 one. Here's the Godbolt
I'd like the lambdas wit
On Fri, 27 Sep 2024 16:23:29 GMT, Gerard Ziemski wrote:
> Should we say then, that this is blocked by those 2 issues? Is it OK then if
> I wait till those get checked in before verifying the performance benefits if
> the new implementation? The performance was the main motivation here, correct?
On Mon, 14 Oct 2024 13:22:54 GMT, Afshin Zafari wrote:
> > Yes, but this code is incorrect. So we should have a test detecting this,
> > but we do not, and so this is under-tested.
>
> This code finds committed regions within a Stack region if they are not
> accounted by NMT so far, IIUC. By r
On Thu, 7 Nov 2024 12:48:12 GMT, Afshin Zafari wrote:
>> - `VMATree` is used instead of `SortedLinkList` in new class
>> `VirtualMemoryTrackerWithTree`.
>> - A wrapper/helper `RegionTree` is made around VMATree to make some calls
>> easier.
>> - Both old and new versions exist in the code a
On Mon, 14 Oct 2024 18:56:47 GMT, Johan Sjölen wrote:
> I think it's actually the opposite: None of the committed regions will
> survive after this function.
You maybe missed my point when said " ... some extra committed size in NMT
reports". I emphasize on the " the NMT reports", since the co
On Wed, 14 Aug 2024 19:11:58 GMT, Gerard Ziemski wrote:
>> - `VMATree` is used instead of `SortedLinkList` in new class
>> `VirtualMemoryTrackerWithTree`.
>> - A wrapper/helper `RegionTree` is made around VMATree to make some calls
>> easier.
>> - Both old and new versions exist in the code
On Wed, 14 Aug 2024 19:13:49 GMT, Gerard Ziemski wrote:
>> src/hotspot/share/nmt/memReporter.cpp line 467:
>>
>>> 465:
>>> 466: if (reserved_and_committed)
>>> 467: return;
>>
>> This looks better, but now that I got more comfortable with anonymous local
>> functions using lambd
On Sat, 12 Oct 2024 14:24:15 GMT, Johan Sjölen wrote:
>> No, returned back.
>> This assert is triggered:
>>
>> # Internal Error
>> (/home/afshin/scratch/833XX_nmt_VMT_with_tree/src/hotspot/share/utilities/growableArray.hpp:142),
>> pid=1972883, tid=1972931
>> # assert(0 <= i && i < _len) fai
On Fri, 27 Sep 2024 09:57:35 GMT, Afshin Zafari wrote:
>> Removed.
>
> No, returned back.
> This assert is triggered:
>
> # Internal Error
> (/home/afshin/scratch/833XX_nmt_VMT_with_tree/src/hotspot/share/utilities/growableArray.hpp:142),
> pid=1972883, tid=1972931
> # assert(0 <= i && i < _
On Fri, 27 Sep 2024 09:46:27 GMT, Afshin Zafari wrote:
>> src/hotspot/share/nmt/nmtNativeCallStackStorage.hpp line 93:
>>
>>> 91:
>>> 92: const inline NativeCallStack& get(StackIndex si) {
>>> 93: if (is_invalid(si) || si >= _stacks.length()) {
>>
>> I don't think this should be here?
>
On Thu, 1 Aug 2024 15:44:32 GMT, Afshin Zafari wrote:
> - `VMATree` is used instead of `SortedLinkList` in new class
> `VirtualMemoryTrackerWithTree`.
> - A wrapper/helper `RegionTree` is made around VMATree to make some calls
> easier.
> - Both old and new versions exist in the code and ca
- `VMATree` is used instead of `SortedLinkList` in new class
`VirtualMemoryTrackerWithTree`.
- A wrapper/helper `RegionTree` is made around VMATree to make some calls
easier.
- Both old and new versions exist in the code and can be selected via
`MemTracker::set_version()`
- `find_reserved_r
On Fri, 8 Nov 2024 10:26:36 GMT, Alan Bateman wrote:
>> jtreg patches the `java.base` module and those langtools tests *link* from
>> the run-time image (in such a config). Having a patched JDK module is not
>> supported (and I don't think we ever should). Running in a separate JVM
>> doesn't
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
On Fri, 8 Nov 2024 09:28:07 GMT, Alan Bateman wrote:
> On the surface this looks okay but just to double check: this has no impact
> on `java -cp -jar app.jar`. The class path in that case is
> `app.jar`, the class path specified to -cp is ignored.
That's right - the launcher explicitly overr
On Thu, 1 Aug 2024 15:44:32 GMT, Afshin Zafari wrote:
> - `VMATree` is used instead of `SortedLinkList` in new class
> `VirtualMemoryTrackerWithTree`.
> - A wrapper/helper `RegionTree` is made around VMATree to make some calls
> easier.
> - Both old and new versions exist in the code and ca
On Fri, 27 Sep 2024 09:49:37 GMT, Johan Sjölen wrote:
> The fork for JDK-24 is on December 5th. That means that we have at most 8
> weeks in the testing system to find and fix any bugs that we might have
> missed after integration. To me, that feels a bit short. Either we wait after
> the fork
On Fri, 27 Sep 2024 10:22:57 GMT, Afshin Zafari wrote:
> > The fork for JDK-24 is on December 5th. That means that we have at most 8
> > weeks in the testing system to find and fix any bugs that we might have
> > missed after integration. To me, that feels a bit short. Either we wait
> > after
On Fri, 27 Sep 2024 10:10:37 GMT, Johan Sjölen wrote:
> Sure, I can understand that it's nice to have both versions present during
> development. Right now it seems like we have a broken build, do you have any
> plans on having a functioning and fully featured build soon?
The new commit is pus
On Fri, 27 Sep 2024 11:43:19 GMT, Johan Sjölen wrote:
> Why should the default be disabled? That requires customers to explicitly
> pick the new tree to be used, which they are very unlikely to do. As I
> understand it, and correct me if I am wrong, the main goal of having two
> implementation
On Fri, 8 Nov 2024 09:58:48 GMT, Severin Gehwolf wrote:
>> test/jtreg-ext/requires/VMProps.java line 28:
>>
>>> 26: import java.lang.module.ModuleFinder;
>>> 27: import java.lang.module.ModuleReader;
>>> 28: import java.lang.module.ModuleReference;
>>
>> I assume they aren't needed now.
>
> Tru
On Fri, 27 Sep 2024 16:05:33 GMT, Afshin Zafari wrote:
> > Rather than having 2 implementations, I'd like to see us aiming for
> > integration for JDK-25 after forking 24, so integration in December. That
> > would give us 6 months of ensuring stability of the new implementation
> > before it
On Fri, 27 Sep 2024 16:10:59 GMT, Gerard Ziemski wrote:
> > > Rather than having 2 implementations, I'd like to see us aiming for
> > > integration for JDK-25 after forking 24, so integration in December. That
> > > would give us 6 months of ensuring stability of the new implementation
> > > b
On Mon, 14 Oct 2024 12:37:05 GMT, Johan Sjölen wrote:
> Yes, but this code is incorrect. So we should have a test detecting this, but
> we do not, and so this is under-tested.
This code finds committed regions within a Stack region if they are not
accounted by NMT so far, IIUC.
By running this
On Mon, 14 Oct 2024 10:24:54 GMT, Afshin Zafari wrote:
> > ```c++
> > region->add_committed_region(committed_start, committed_size, ncs); // <--
> > LOST!
> > ```
>
> The `region` is not a VMATree::node, it is a `ReservedMemoryRegion*`.
I don't understand what you're trying to say here. Do you
On Mon, 14 Oct 2024 08:50:52 GMT, Afshin Zafari wrote:
>> Why is this assert triggered? That sounds like a bug.
>
> The assertion that happens during building jdk-image:
>
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # Internal Error
> (/home/afshin/scratch/83
On Mon, 5 Aug 2024 16:50:00 GMT, Afshin Zafari wrote:
>> The bool argument is just passed along.
>>
>> ```c++
>> RegionsTree(bool with_storage) : VMATree(), _ncs_storage(with_storage) {
>> }
>
> Done.
> For my curiosity, what is the advantage?
1. No malloc
2. No indirection, so no cache mis
On Fri, 9 Aug 2024 09:05:37 GMT, Johan Sjölen wrote:
>> Done.
>> For my curiosity, what is the advantage?
>
> 1. No malloc
> 2. No indirection, so no cache misses
> 3. A clear lifetime and clear ownership, both are bound to the `RegionsTree`
> object
OK. Thanks for your description.
--
On Fri, 9 Aug 2024 15:05:59 GMT, Johan Sjölen wrote:
>> src/hotspot/share/nmt/regionsTree.hpp line 46:
>>
>>> 44: using Node = VMATree::TreapNode;
>>> 45:
>>> 46: class NodeHelper : public Node {
>>
>> This shouldn't inherit from `Node` and then have each instance be cast into
>> `NodeHel
On Mon, 5 Aug 2024 08:42:43 GMT, Johan Sjölen wrote:
>> Yeah, that doesn't seem like a problem.
>>
>> ```c++
>> for (int i = 0; i < mt_number_of_types; i++) {
>> r = diff.flag[i].reserve;
>> c = diff.flag[i].commit;
>> flag = NMTUtil::index_to_flag(i);
>> VirtualMemory* mem = V
On Mon, 5 Aug 2024 08:41:49 GMT, Johan Sjölen wrote:
>> In `MemoryFileTracker`, the changes in commit/reserve are applied to a local
>> `VirtualMemorySnapshot`. Here we have to apply them to the global
>> `VirtualMemorySummary`.
>
> Yeah, that doesn't seem like a problem.
>
> ```c++
> for (i
On Fri, 9 Aug 2024 10:03:52 GMT, Johan Sjölen wrote:
>> The main purpose of the `if (...)` cases is to find if the request to apply
>> the delta is valid or not. There are related assertions in VirtualMemory but
>> not so informative. Also, using `log_debug` lets the build proceed and just
>>
On Mon, 5 Aug 2024 17:20:24 GMT, Afshin Zafari wrote:
>> Why would the execution time grow logarithmically when we do linearly more
>> work? When we run this with `N2` we will perform `10_000 * log(10_000, 2)`
>> units of work, and for `N1` we will perform `1_000 * log(1_000, 2)` units of
>> w
On Mon, 5 Aug 2024 16:54:40 GMT, Afshin Zafari wrote:
>> This applies the reserve/commit regardless of outcome, so slightly different.
>
> The main purpose of the `if (...)` cases is to find if the request to apply
> the delta is valid or not. There are related assertions in VirtualMemory but
>
On Mon, 5 Aug 2024 17:23:46 GMT, Afshin Zafari wrote:
>> It is considered that `malloc` or other external events are the same for two
>> cases. If we know that there might be some noise for one or another, we
>> should check and disable them. This is the approach I have talked. How can
>> we a
On Tue, 6 Aug 2024 07:12:13 GMT, Johan Sjölen wrote:
>> When it is said that an algorithm has the log(n) time-complexity, it means
>> that if the input grows n times, the times grows log(n) times. The tree
>> data-structure has log(n) time-complexity. VMATree may have not exactly
>> log(n) res
On Fri, 8 Nov 2024 10:34:43 GMT, Severin Gehwolf wrote:
>> That's okay, I wasn't initially sure why they were changed. I'm looking at
>> JRTArchiveFile.toEntry and wondering there should be a follow-up issue (not
>> this PR) to fail early if running on a patched run-time even though it would
Can I please get a review of this change which addresses
https://bugs.openjdk.org/browse/JDK-8211033?
As noted in that issue, this is a clean up of the code which determines the
"mode" through with the `java` application is being launched. In its current
form the presence of `--classpath` (or i
On Fri, 8 Nov 2024 08:51:38 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.org/browse/JDK-8211033?
>
> As noted in that issue, this is a clean up of the code which determines the
> "mode" through with the `java` application is being l
1 - 100 of 136 matches
Mail list logo
