On Mon, 14 Oct 2024 12:37:05 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:

> Yes, but this code is incorrect. So we should have a test detecting this, but 
> we do not, and so this is under-tested.

This code finds committed regions within a Stack region if they are not 
accounted by NMT so far, IIUC.
By running this incorrect code, we may get some extra committed size in NMT 
reports. This is hard in NMT tests to catch. How can we expect a NMT test to 
measure X bytes of committed stack and not Y bytes? We need to know exactly the 
X and/or Y to test this code.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20425#issuecomment-2411263187

Reply via email to