On Fri, 8 Nov 2024 16:17:39 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updating the copyright year of the Gatherer benchmarks > > The removal of preview toggles look good. Confirmed that since in stream > packages and removal of preview toggles tests/micro look good. > > Side comment: With the `jvmArgs` cleared on benchmark `@Fork`, you can just > make it `@Fork(1)` instead of `@Fork(value = 1)`. @liach >Side comment: With the jvmArgs cleared on benchmark @Fork, you can just make >it @Fork(1) instead of @Fork(value = 1). Yeah, I opted to keep it as-is to make the delta between old-and-new low (and to make adding additional params slightly faster). I'd be happy to change it if you insist, tho! :) ------------- PR Comment: https://git.openjdk.org/jdk/pull/21686#issuecomment-2465208982
