On Fri, 8 Nov 2024 20:25:10 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Creating specialized IR to shield pattern from subsequent transforms in
>> optimization pipeline
>
> src/hotspot/share/opto/vectornode.cpp line 2132:
>
>> 2130: // Directly forward masked inputs if
>> 2131: if (n->Opcode() == Op_AndV) {
>> 2132: return n->in(1)->Opcode() == Op_Replicate ? n->in(2) : n->in(1);
>
> This particular check should ensure that Replicate constant is `0xFFFFFFFF`.
Yes, this should ensure 0xFFFFFFFF.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21244#discussion_r1835148834