On Thu, 5 Dec 2024 04:38:04 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Thu, 5 Dec 2024 04:38:04 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Thu, 5 Dec 2024 04:38:04 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8341551?
>
> The primary work in this PR is the specification of the previously existing
> `sun.misc.URLClassPath.disableJarChecking` system property and how the
> internal implementation
On Wed, 4 Dec 2024 16:46:17 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Wed, 4 Dec 2024 16:46:14 GMT, Eirik Bjørsnøs wrote:
>> We're stuck with the property name for compatibility, and the usage within
>> the class is fairly limited.
>> Generally, it is easier to understand the behavior having a feature that is
>> enabled not a disable that is disabled.
>> $0.02
On Wed, 4 Dec 2024 16:46:17 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Wed, 4 Dec 2024 16:40:42 GMT, Roger Riggs wrote:
>> Hello Eirik, I have received similar inputs in other places when discussing
>> this change. I myself had to think a few times on which naming to follow
>> here to make it easier to understand the code. I'll consider your and other
>> input
On Wed, 4 Dec 2024 16:35:09 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lance's suggestion - better comment on the method
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java l
On Wed, 4 Dec 2024 16:35:19 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 89:
>>
>>> 87: // JAR check is disabled by default and will be enabled only if
>>> the "disable JAR check"
>>> 88: // system property has been set to "f
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8341551?
>
> The primary work in this PR is the specification of the previously existing
> `sun.misc.URLClassPath.disableJarChecking` system property and how the
> internal implementation
On Wed, 4 Dec 2024 16:28:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Wed, 4 Dec 2024 16:25:47 GMT, Eirik Bjørsnøs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve code comment
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 89:
>
>> 87:
On Wed, 4 Dec 2024 16:12:39 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve code comment
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 657:
>
>> 655:
On Wed, 4 Dec 2024 15:46:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8341551?
>
> The primary work in this PR is the specification of the previously existing
> `sun.misc.URLClassPath.disableJarChecking` system property and how the
> internal implementation
On Wed, 4 Dec 2024 15:58:41 GMT, Jaikiran Pai wrote:
>> test/jdk/jdk/internal/loader/URLClassPath/JarCheckTest.java line 60:
>>
>>> 58: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking
>>> JarCheckTest
>>> 59: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking=true
On Wed, 4 Dec 2024 15:46:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Wed, 4 Dec 2024 14:53:19 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve code comment
>
> test/jdk/jdk/internal/loader/URLClassPath/JarCheckTest.java line 60:
>
>> 58: * @run junit/ot
On Wed, 4 Dec 2024 15:46:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8341551?
>
> The primary work in this PR is the specification of the previously existing
> `sun.misc.URLClassPath.disableJarChecking` system property and how the
> internal implementation
Can I please get a review of this change which proposes to address
https://bugs.openjdk.org/browse/JDK-8341551?
The primary work in this PR is the specification of the previously existing
`sun.misc.URLClassPath.disableJarChecking` system property and how the internal
implementation of `java.ne
22 matches
Mail list logo
