On Thu, 5 Dec 2024 04:38:04 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which proposes to address >> https://bugs.openjdk.org/browse/JDK-8341551? >> >> The primary work in this PR is the specification of the previously existing >> `sun.misc.URLClassPath.disableJarChecking` system property and how the >> internal implementation of `java.net.URLClassLoader` treats it. The complete >> details about this property is available in the CSR for this change here >> https://bugs.openjdk.org/browse/JDK-8345394. >> >> A new jtreg test has been introduced to exercise the usage of this system >> property. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains eight additional > commits since the last revision: > > - simplify system property check > - fix URL creation to address failures on Windows OS > - merge latest from master branch > - Roger's suggestion - reduce "if" blocks > - Lance's suggestion - better comment on the method > - improve code comment > - introduce a test for the sun.misc.URLClassPath.disableJarChecking system > property > - 8341551: Revisit jdk.internal.loader.URLClassPath.JarLoader after JEP 486 I've updated the test to address a failure on Windows due to an incorrect URL construction in the test. The test now passes on Windows too. Additionally, I have done a very tiny change to the property parsing code to follow Eirik's suggestion of doing `"false".equals(p)`. No other changes have been done. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22545#issuecomment-2519269494
