On Wed, 4 Dec 2024 15:58:41 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> test/jdk/jdk/internal/loader/URLClassPath/JarCheckTest.java line 60: >> >>> 58: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking >>> JarCheckTest >>> 59: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking=true >>> JarCheckTest >>> 60: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking=FALSE >>> JarCheckTest >> >> maybe we should have an `@run` with the canonical "false" value too. > > It's there, just a few lines above, at line 53, made to stand out on its own > :) oh! that's why I missed it :-) LGTM then... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22545#discussion_r1869880484
