On Wed, 4 Dec 2024 15:46:28 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which proposes to address >> https://bugs.openjdk.org/browse/JDK-8341551? >> >> The primary work in this PR is the specification of the previously existing >> `sun.misc.URLClassPath.disableJarChecking` system property and how the >> internal implementation of `java.net.URLClassLoader` treats it. The complete >> details about this property is available in the CSR for this change here >> https://bugs.openjdk.org/browse/JDK-8345394. >> >> A new jtreg test has been introduced to exercise the usage of this system >> property. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > improve code comment Marked as reviewed by lancea (Reviewer). src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 657: > 655: } > 656: > 657: /* Throws if the given jar file does not start with the correct > LOC */ Probably would be clearer to state that the Exception is thrown when a LOC file Header Signature, (0x04034b50), is not found starting at byte 0 ------------- PR Review: https://git.openjdk.org/jdk/pull/22545#pullrequestreview-2479235340 PR Review Comment: https://git.openjdk.org/jdk/pull/22545#discussion_r1869871842
