On Wed, 4 Dec 2024 16:12:39 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> improve code comment > > src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 657: > >> 655: } >> 656: >> 657: /* Throws if the given jar file does not start with the correct >> LOC */ > > Probably would be clearer to state that the Exception is thrown when a LOC > file Header Signature, (0x04034b50), is not found starting at byte 0 Done, I've updated the PR to use your suggested comment. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22545#discussion_r1869892184
