On Wed, 4 Dec 2024 14:53:19 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> improve code comment > > test/jdk/jdk/internal/loader/URLClassPath/JarCheckTest.java line 60: > >> 58: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking >> JarCheckTest >> 59: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking=true >> JarCheckTest >> 60: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking=FALSE >> JarCheckTest > > maybe we should have an `@run` with the canonical "false" value too. It's there, just a few lines above, at line 53, made to stand out on its own :) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22545#discussion_r1869848270