On Wed, 13 Nov 2024 11:15:15 GMT, Raffaello Giulietti
wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 150:
>>
>>> 148: * A constant holding the largest positive finite value of type
>>> 149: * {@code Float16},
>>> 150: * (2-2-10)·215, n
On Wed, 13 Nov 2024 06:40:15 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 91:
>>
>>> 89: // JEP-401 (https://openjdk.org/jeps/401).
>>> 90: // @jdk.internal.MigratedValueClass
>>> 91: // @jdk.internal.ValueBased
>>
>> Please uncommen
On Wed, 13 Nov 2024 06:40:15 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 91:
>>
>>> 89: // JEP-401 (https://openjdk.org/jeps/401).
>>> 90: // @jdk.internal.MigratedValueClass
>>> 91: // @jdk.internal.ValueBased
>>
>> Please uncommen
On Wed, 13 Nov 2024 10:41:34 GMT, Eirik Bjørsnøs wrote:
>> Joe Darcy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Implement code review feedback.
>> - Misc cleanups.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/F
On Wed, 13 Nov 2024 05:40:24 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Implement code review feedback.
> -
On Wed, 13 Nov 2024 05:40:24 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Implement code review feedback.
> -
On Mon, 11 Nov 2024 02:09:41 GMT, Jatin Bhateja wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line
> 91:
>
>
On Wed, 30 Oct 2024 05:25:47 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
src/jdk.i
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Implement code review feedback.
- Misc cleanups.
-
Changes:
- all: https://git.open
On Tue, 12 Nov 2024 21:01:36 GMT, Joe Darcy wrote:
> > Looks good. Approving the current status. Are there plans for other small
> > additions?
>
> Subsequent to this comment, I did a light clean-up pass over the tests. I'll
> do a pass over the Float16 implementation too to make sure previous
On Tue, 12 Nov 2024 19:15:45 GMT, Raffaello Giulietti
wrote:
> Looks good. Approving the current status. Are there plans for other small
> additions?
Subsequent to this comment, I did a light clean-up pass over the tests. I'll do
a pass over the Float16 implementation too to make sure previou
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Cleanup pass on tests.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574/files
On Tue, 12 Nov 2024 18:40:34 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix bug parsing short inputs.
Looks g
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix bug parsing short inputs.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574
On Tue, 12 Nov 2024 12:49:01 GMT, Raffaello Giulietti
wrote:
>> Thanks for catching that; fix and tests added in subsequent push.
>
> Single digit inputs, e.g., `Float16.valueOf"2")` throw as well.
Addressed in most recent push; thanks.
-
PR Review Comment: https://git.openjdk.org
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typos founds in code review.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21
On Tue, 12 Nov 2024 05:38:23 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 431:
>>
>>> 429: * @seejava.lang.Float#valueOf(String)
>>> 430: */
>>> 431: public static Float16 valueOf(String s) throws
>>> NumberFormatEx
On Tue, 12 Nov 2024 05:42:46 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brough
On Tue, 12 Nov 2024 05:42:46 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brough
On Mon, 11 Nov 2024 14:03:54 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line
> 4
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 21 addi
On Wed, 30 Oct 2024 05:25:47 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
src/jdk.i
On Wed, 30 Oct 2024 05:12:18 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 504:
>>
>>> 502: // without the period.
>>> 503: hexSignificand.append(s.substring(digitStart,
>>> periodIndex));
On Tue, 29 Oct 2024 14:03:35 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add support for proper String -> Float16 conversion.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vect
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574/f
On Tue, 29 Oct 2024 14:03:17 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add support for proper String -> Float16 conversion.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vect
On Tue, 29 Oct 2024 04:30:57 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add support for proper String -> Float
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Add support for proper String -> Float16 conversion.
-
Changes:
- all: https://git.ope
On Tue, 29 Oct 2024 04:30:57 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add support for proper String -> Float
On Tue, 29 Oct 2024 04:30:57 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add support for proper String -> Float
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 14 addi
On Wed, 23 Oct 2024 01:03:38 GMT, Chen Liang wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add equals/hashCode implementation; tests to follow.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16
On Wed, 23 Oct 2024 00:53:57 GMT, Chen Liang wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add equals/hashCode implementation; tests to follow.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Improve specification per code review feedback.
-
Changes:
- all: https://git.openjdk.
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 12 addi
On Wed, 23 Oct 2024 15:46:31 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 865:
>>
>>> 863: public static Float16 min(Float16 a, Float16 b) {
>>> 864: return
>>> shortBitsToFloat16(floatToFloat16(Math.min(a.floatValue(),
>
On Wed, 23 Oct 2024 12:53:20 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add equals/hashCode implementation; tests to follow.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vect
On Tue, 22 Oct 2024 23:47:33 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add equals/hashCode implementation; te
On Tue, 22 Oct 2024 23:47:33 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add equals/hashCode implementation; te
On Tue, 22 Oct 2024 23:47:33 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add equals/hashCode implementation; te
On Tue, 22 Oct 2024 23:13:26 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 690:
>>
>>> 688: // public int hashCode()
>>> 689: // public static int hashCode(Float16 value)
>>> 690: // public boolean equals(Object obj)
>>
>>
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Add equals/hashCode implementation; tests to follow.
-
Changes:
- all: https://git.ope
On Tue, 22 Oct 2024 20:01:45 GMT, Paul Sandoz wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains seven additional commits
>> si
On Tue, 22 Oct 2024 19:41:57 GMT, Paul Sandoz wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains seven additional commits
>> si
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574/f
On Mon, 21 Oct 2024 17:07:35 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brough
On Tue, 22 Oct 2024 14:18:33 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains seven additional commi
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574/f
On Mon, 21 Oct 2024 17:07:35 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brough
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains seven a
On Mon, 21 Oct 2024 06:21:06 GMT, Jatin Bhateja wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove comments for intrinsics per review feedback.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float
On Sun, 20 Oct 2024 18:59:36 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove comments for intrinsics per rev
On Sun, 20 Oct 2024 18:59:36 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove comments for intrinsics per rev
On Sun, 20 Oct 2024 18:59:36 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove comments for intrinsics per rev
On Thu, 17 Oct 2024 23:11:07 GMT, Joe Darcy wrote:
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
> Comparing with #21490 we can see that there are more than minimum number of
> intrinsics I recommended above, but (crucially) the intrinsics are decoupled
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Remove comments for intrinsics per review feedback.
-
Changes:
- all: https://git.open
On Thu, 17 Oct 2024 23:11:07 GMT, Joe Darcy wrote:
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Comparing with https://github.com/openjdk/jdk/pull/21490 we can see that there
are more than minimum number of intrinsics I recommended above, but (crucially
Port of Float16 from java.lang in the lworld+fp16 branch to
jdk.incubabor.vector.
-
Commit messages:
- Update with changes from lworld+fp16 Float16.
- Merge branch 'master' into JDK-8341260
- Add support for BigDecimal -> Float16 conversion.
- JDK-8341260: Add Float16 to jdk.incu
On Thu, 17 Oct 2024 23:11:07 GMT, Joe Darcy wrote:
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Somebody might ask as a followup, "But what about calling sequences? Without
intrinsics, how does the JIT know to store Float16 values in the correct type
On Thu, 17 Oct 2024 23:11:07 GMT, Joe Darcy wrote:
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe, our revised and now-current thinking about JIT support for the Float16
(both as a pre-Valhalla VBC and Valhalla value class) is that there should be
ze
On Thu, 17 Oct 2024 23:37:54 GMT, Joe Darcy wrote:
> ```
> $ diff test/jdk/java/lang/Float16/BasicFloat16ArithTests.java
> ~/jdk24/test/jdk/jdk/incubator/vector/BasicFloat16ArithTests.java
> 26c26,27
> < * @bug 8329817 8334432 8339076
> ---
> > * @bug 8329817 8334432 8339076 8341260
> > * @
On Thu, 17 Oct 2024 23:11:07 GMT, Joe Darcy wrote:
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Add as contributors other engineers who worked on Float16 on the lworld+fp16
branch in Valhalla.
To ease review, diffs of corresponding files from the curre
62 matches
Mail list logo
