On Tue, 12 Nov 2024 05:42:46 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to >> jdk.incubabor.vector. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 21 additional commits since > the last revision: > > - Test update and minor bug fix. > - Merge branch 'master' into JDK-8341260 > - Add Float16 -> string conversion from Raffaello. > - Merge branch 'master' into JDK-8341260 > - Merge branch 'master' into JDK-8341260 > - Respond to review feedback. > - Add support for proper String -> Float16 conversion. > - Merge branch 'master' into JDK-8341260 > - Improve specification per code review feedback. > - Add tests, improve hashing spec. > - ... and 11 more: https://git.openjdk.org/jdk/compare/f3d339e1...8af04c4d src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 242: > 240: * The behavior of this class is analogous to {@link > 241: * Float#toHexString(float)} except that an exponent value of > 242: * {@code "p14"} is used for subnormal {@code Float16} values. Suggestion: * {@code "p-14"} is used for subnormal {@code Float16} values. src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 434: > 432: */ > 433: public static Float16 valueOf(String s) throws NumberFormatException > { > 434: s = s.trim(); // Legacy behavior from analagous methods on Suggestion: s = s.trim(); // Legacy behavior from analogous methods on src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 991: > 989: * > 990: * The handling of signed zeros, NaNs, infinities, and other > 991: * special cases by this method is analagous to the handling of Suggestion: * special cases by this method is analogous to the handling of src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 1013: > 1011: * > 1012: * The handling of signed zeros, NaNs, infinities, and other > 1013: * special cases by this method is analagous to the handling of Suggestion: * special cases by this method is analogous to the handling of ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1837987951 PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1837992200 PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1837990836 PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1837991474
