On Mon, 21 Oct 2024 06:21:06 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove comments for intrinsics per review feedback. > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line > 970: > >> 968: // of the double -> Float16 conversion also benefits from the >> 969: // 2p+2 property of IEEE 754 arithmetic. >> 970: return valueOf(Math.sqrt(radicand.doubleValue())); > > Kindly also add a reference to link you shared on lworld+fp16 branch. > https://dl.acm.org/doi/pdf/10.1145/221332.221334 That reference is already cited around line 850. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1809179951
