On Wed, 30 Oct 2024 05:12:18 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java >> line 504: >> >>> 502: // without the period. >>> 503: hexSignificand.append(s.substring(digitStart, >>> periodIndex)); >>> 504: hexSignificand.append(s.substring(periodIndex + 1, >>> pIndex)); >> >> Suggestion: >> >> hexSignificand.append(s, digitStart, periodIndex); >> hexSignificand.append(s, periodIndex + 1, pIndex); > > Good refactoring; thanks for the suggestion. The credit goes to my IDE ;-) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1822722888
