On Mon, 11 Nov 2024 14:03:54 GMT, Raffaello Giulietti <[email protected]>
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line
> 431:
>
>> 429: * @see java.lang.Float#valueOf(String)
>> 430: */
>> 431: public static Float16 valueOf(String s) throws
>> NumberFormatException {
>
> The current implementation throws when the input is `"NaN"`, with or without
> an optional sign.
Thanks for catching that; fix and tests added in subsequent push.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1837508472
