On Tue, 22 Oct 2024 23:47:33 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to >> jdk.incubabor.vector. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Add equals/hashCode implementation; tests to follow. src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 472: > 470: } > 471: } > 472: } (nit) Then indents are not "multiples of 4" in the lines of this method's body. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1812653888