On Thu, 19 Dec 2024 19:16:55 GMT, Erik Gahlin wrote:
>> I'm not sure if one or two events are most suitable. If possible, I would
>> like to discuss it with Markus to get some more input. He will back in
>> January.
>
> Regarding one or two events. I'm fine with integrating as-is and then revis
On Thu, 12 Dec 2024 03:58:29 GMT, Erik Gahlin wrote:
>> We need to help Tim on the question of whether there is one or two events.
>>
>> An application that makes outbound network connections may run slowly for
>> several reasons. A duration event may help to diagnose this, irrespective of
>>
On Mon, 16 Dec 2024 20:24:20 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additiona
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Refactored connect except
On Thu, 12 Dec 2024 09:48:45 GMT, Daniel Fuchs wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> requests fixes
>>
>> - Use IOException.toString() instead of getMessage() in case it's empty
>> - Attempts to te
On Tue, 10 Dec 2024 21:41:18 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additiona
On Tue, 10 Dec 2024 21:41:18 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additiona
On Wed, 4 Dec 2024 12:26:20 GMT, Alan Bateman wrote:
>> We could have two views with only one event. The query for the view could
>> filter for exceptionMessage != null or a failure property. The advantage of
>> having two events is that the failure event could have a threshold of 0 ms.
>>
>>
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
requests fixes
- Use
On Tue, 3 Dec 2024 23:42:34 GMT, Erik Gahlin wrote:
>> @egahlin The updated PR proposes two duration events: jdk.SocketConnect for
>> when a connection is established, and jdk.SocketConnectFailed for when a
>> connection cannot be established. Naming aside, it seems that would allow
>> the jfr
On Tue, 3 Dec 2024 12:34:20 GMT, Alan Bateman wrote:
>> A connection failure introduces a latency in the application, so probably
>> best to have such an event durational as well.
>
> @egahlin The updated PR proposes two duration events: jdk.SocketConnect for
> when a connection is established,
On Tue, 3 Dec 2024 15:12:10 GMT, Daniel Fuchs wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> split socket connect failure out to its own event.
>
> src/jdk.jfr/share/conf/jfr/default.jfc line 746:
>
>> 744:
On Sat, 23 Nov 2024 08:36:03 GMT, Alan Bateman wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added more tests for socket connect events.
>>
>> - SocketAdapter connect
>> - SocketAdapter connect with except
On Tue, 3 Dec 2024 15:40:02 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request with a new target base due to a
On Tue, 3 Dec 2024 00:40:24 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 11 commits:
On Mon, 25 Nov 2024 13:23:23 GMT, Erik Gahlin wrote:
>> Having a view for connect failures that doesn't require exceptions=all could
>> be useful. Does this mean two events, one an instant event for the failures,
>> the other a duration event for the connections that are slow to establish?
>
>
On Tue, 3 Dec 2024 00:40:24 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
split socket connect fail
On Mon, 25 Nov 2024 12:00:52 GMT, Alan Bateman wrote:
>>> If a connection cannot be established then it might be immediate, 10s of
>>> milliseconds, maybe 60+ seconds in some cases. A slow down or stall waiting
>>> for a connection to be established seems a useful event to have recorded.
>>
>>
On Mon, 25 Nov 2024 10:59:35 GMT, Erik Gahlin wrote:
>>> Perhaps this should be made more explicit with a failed field.
>>> Alternatively, there could be two events: one for success and one for
>>> failure. What is the typical duration of a failed event? If it is above
>>> 10-20 ms, two events
On Mon, 25 Nov 2024 07:54:34 GMT, Alan Bateman wrote:
> If a connection cannot be established then it might be immediate, 10s of
> milliseconds, maybe 60+ seconds in some cases. A slow down or stall waiting
> for a connection to be established seems a useful event to have recorded.
If it's imm
On Sun, 24 Nov 2024 23:15:02 GMT, Erik Gahlin wrote:
> Perhaps this should be made more explicit with a failed field. Alternatively,
> there could be two events: one for success and one for failure. What is the
> typical duration of a failed event? If it is above 10-20 ms, two events might
> n
On Sat, 23 Nov 2024 08:02:42 GMT, Alan Bateman wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added more tests for socket connect events.
>>
>> - SocketAdapter connect
>> - SocketAdapter connect with except
On Fri, 22 Nov 2024 20:32:50 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additiona
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Added more tests for sock
On Wed, 6 Nov 2024 00:15:44 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
On Wed, 6 Nov 2024 00:15:44 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
On Wed, 6 Nov 2024 07:31:37 GMT, Alan Bateman wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> suggested changes
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/JDKEvents.java line 2:
>
>> 1: /*
>> 2: * Copyright (
On Wed, 6 Nov 2024 00:15:44 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
On Wed, 6 Nov 2024 00:15:44 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
suggested changes
--
On Tue, 5 Nov 2024 16:48:14 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
improved exception names
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Added support for connect
On Mon, 21 Oct 2024 00:39:27 GMT, Tim Prinzing wrote:
> The non-blocking case is poorly handled. I'll update the JBS. The untimely
> use of finishConnect would cause an artificially bad looking event duration
> which might be a bit misleading.
My preference for now would be to focus on the blo
On Wed, 16 Oct 2024 06:46:54 GMT, Alan Bateman wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 1006:
>
On Wed, 16 Oct 2024 06:40:33 GMT, Alan Bateman wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java line 624:
>
>>
On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote:
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
I think this change should have a release note.
-
PR Comment: https
On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote:
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 1006:
> 1004:
On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote:
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java line 624:
> 622:
Adds a JFR event for socket connect operations.
Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
check for connect events.
-
Commit messages:
- fix default settings
- fix merge
- Merge branch 'master' into JDK-8310996
- added tests and support for soc
42 matches
Mail list logo
