On Wed, 6 Nov 2024 00:15:44 GMT, Tim Prinzing <tprinz...@openjdk.org> wrote:

>> Adds a JFR event for socket connect operations.
>> 
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also 
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   suggested changes

The update in ce9d39e2 has the changes that I discussed with Tim yesterday. 
Specifically, it fixes several issues with the non-blocking case, only records 
an event if the connect method actually attempts to establish a connection, and 
fixes the socket adaptor. So I think this to NioSocketImpl and 
SocketChannelImpl are good now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21528#issuecomment-2458949631

Reply via email to