On Thu, 12 Dec 2024 03:58:29 GMT, Erik Gahlin <egah...@openjdk.org> wrote:
>> We need to help Tim on the question of whether there is one or two events. >> >> An application that makes outbound network connections may run slowly for >> several reasons. A duration event may help to diagnose this, irrespective of >> whether the connection is established successfully or it fails, so one event >> is okay. Separately, another big source of latency is the name service / DNS >> lookup which happens before getting to the Socket connect. Maybe further >> work could add events to InetAddress for this. >> >> When hunting misbehaving behavior then focusing on the cases where a >> connection cannot be established may be more interesting. So it's possible >> someone might want to run with threshold=0 to see all failed events. If >> there is throttling support, and since we control call site for both the >> successful and failed cases, could we live with one event? > > I'm not sure if one or two events are most suitable. If possible, I would > like to discuss it with Markus to get some more input. He will back in > January. Regarding, one or two events. I'm fine with integrating as-is and then revisit before FC, if needed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21528#discussion_r1893019773
