On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing <tprinz...@openjdk.org> wrote:
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java line 624:
> 622: SocketConnectEvent.commit(start, duration,
> isa.getHostString(), address.getHostAddress(), port, connected);
> 623: }
> 624: }
Would it be possible to update the JBS or PR description to indicate if the
intent is to record an event when the connection cannot be established? I'm
asking the change will only record an event when a connection is successfully
established ("connected" is always true here).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21528#discussion_r1802451480
