On Tue, 10 Dec 2024 21:41:18 GMT, Tim Prinzing <tprinz...@openjdk.org> wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> requests fixes
>
> - Use IOException.toString() instead of getMessage() in case it's empty
> - Attempts to test connect exceptions may fail due to unexpected
> successful connect. Tests quit with uncompleted status if the
> connect is successful and are retried a small number of times until
> the test can be performed properly. If the retries are exceeded an
> exception is generated indicating the test can't be setup properly.
src/java.base/share/classes/jdk/internal/event/SocketConnectFailedEvent.java
line 117:
> 115: long duration = timestamp() - start;
> 116: if (shouldCommit(duration)) {
> 117: String msg = connectEx.toString();
Should the description for this field in the event be updated too?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21528#discussion_r1881757052
