> The byte[] allocated in Integer/Long.toString is fully filled, so we can use
> StringConcatHelper::newArray to create byte[] to improve performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
use Unsafe::allocateUninitializedAr
On Thu, 1 May 2025 21:23:38 GMT, Mikhail Yankelevich
wrote:
>> - Symbolic links will not be followed for `--app-content` on all platforms.
>> - Added test to cover this case.
>> - `MacHelper` updated to use "cp -R" instead of "cp -r" when unpacking DMG,
>> since "cp -r" on macOS is not document
> Sometimes, for version-specific feature access APIs, we wish to access the
> preview features of the current Java SE release. To reduce the impact of
> adding one preview-specific version on every site, we can add a constant
> modeling the preview features as a fake version.
Chen Liang has up
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Thu, 1 May 2025 21:47:01 GMT, Brent Christian wrote:
>> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
>> up the intermittent failures:
>>
>> * run with `othervm`: this test blocks the (global) finalizer thread, and
>> also requires the (global) finalizer thread
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
> On May 2, 2025, at 5:34 PM, Alexey Semenyuk wrote:
>
> On Fri, 2 May 2025 22:12:18 GMT, Alexander Matveev
> wrote:
>
>> "***" does not look right.
>
> This is just a mask to hide the real value.
>
>> I did not tried to notarize it.
>
> Well, the problem is with notarization. Signing in
On Fri, 2 May 2025 19:14:27 GMT, Chen Liang wrote:
> Roll back the HelloClasslist downcall generation that caused cross build
> failures for riscv64 and aarch64 from x86-64.
>
> Testing: riscv64 cross build
This pull request has now been integrated.
Changeset: 4d2d1298
Author:Chen Liang
On Fri, 2 May 2025 19:14:27 GMT, Chen Liang wrote:
> Roll back the HelloClasslist downcall generation that caused cross build
> failures for riscv64 and aarch64 from x86-64.
>
> Testing: riscv64 cross build
Marked as reviewed by manc (Committer).
Yes, I tested that this change fixes the failu
On Fri, 2 May 2025 22:12:18 GMT, Alexander Matveev wrote:
> "***" does not look right.
This is just a mask to hide the real value.
> I did not tried to notarize it.
Well, the problem is with notarization. Signing in jpackage passed. But looks
like it produces a bundle that can not be notarize
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm.
>
> The results of all tests posted below were captured with an [Intel® Xeon
> 6761P](https://www.intel.com/content/www/us/en/products/sku/241842/intel-xeon-6761p-processor-336m-cache-2-50-ghz/speci
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Fri, 2 May 2025 21:52:46 GMT, Oleksii Sylichenko wrote:
>> A bit more investigation and some trial and error.
>> It appears that with `echo.`, cmd.com is searching for a file named "echo"
>> and when it does not find it it reverts to the builtin. But it has already
>> wasted time searching
On Fri, 2 May 2025 21:08:46 GMT, Roger Riggs wrote:
>> That sounds brittle. The "echo." usage is not specified, only shown as an
>> example.
>> Under what command parsing rule does it run exactly the "echo" builtin?
>
> A bit more investigation and some trial and error.
> It appears that with `e
On Fri, 2 May 2025 19:14:27 GMT, Chen Liang wrote:
> Roll back the HelloClasslist downcall generation that caused cross build
> failures for riscv64 and aarch64 from x86-64.
>
> Testing: riscv64 cross build
If someone can verify this patch works - @caoman since you have tried to raise
attenti
On Fri, 2 May 2025 17:42:40 GMT, Roger Riggs wrote:
>> No, `echo.` is not an executable, this is a command of the Windows Command
>> Processor.
>>
>> See:
>> https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/echo
>
> That sounds brittle. The "echo." usage is not
Please review this PR which implements ISO 4217 update 179.
The _Arab Accounting Dinar_ currency is added under an _agency_, (not
_country_) entity. As a result it is not added as an entry in the country to
currency mapping in `currencyData.properties`. It has a numeric code of 396,
and minor u
On Fri, 2 May 2025 18:19:35 GMT, Brian Burkhalter wrote:
>> This change proposes to modify `java.io.File.delete()` so that regular files
>> on Windows will not be deleted by default if their read-only attribute is
>> set. A boolean-valued system compatibility property
>> `jdk.io.File.deleteRea
On Fri, 2 May 2025 19:14:27 GMT, Chen Liang wrote:
> Roll back the HelloClasslist downcall generation that caused cross build
> failures for riscv64 and aarch64 from x86-64.
>
> Testing: riscv64 cross build
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.
On Mon, 28 Oct 2024 22:30:06 GMT, Alexander Matveev
wrote:
>> - It is not clear on which macOS versions codesign fails if application
>> bundle contains additional content.
>> - As a result test was modified to generate only application image, since
>> PKG or DMG cannot be generated if signing
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Fri, May 2, 2025 at 2:04 PM Stuart Marks wrote:
> There was a back-and-forth a while ago -- I think @bplb was involved --
> where there was similar wording about something being "equivalent to" or
> "as if" foo() was called, and the person was insistent that this meant that
> foo() should actu
Roll back the HelloClasslist downcall generation that caused cross build
failures for riscv64 and aarch64 from x86-64.
Testing: riscv64 cross build
-
Commit messages:
- 8355962: RISCV64 cross build fails after 8354996
Changes: https://git.openjdk.org/jdk/pull/25013/files
Webrev:
On Wed, 30 Apr 2025 14:14:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
On Thu, 1 May 2025 19:19:32 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/io/Reader.java line 408:
>>
>>> 406: * This method works as if invoking it were equivalent to
>>> evaluating
>>> 407: * the expression:
>>> 408: * {@linkplain
>>> #readAllChars()}.lines().to
> Finalize the KDF API.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
fine tuning debug log and exception message
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24520/files
- new: https://git.openjdk.org/jdk/pul
On Fri, 2 May 2025 17:39:08 GMT, Justin Lu wrote:
>> Please review this PR which reduces the amount of combinations tested by
>> `LocaleNameProviderTest`.
>>
>> This test was exhaustively testing over 1000x1000 `Locale` combinations
>> which was expensive and caused a timeout in tier 5. Narrow
On Fri, 2 May 2025 18:29:14 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 491:
>>
>>> 489: + "using the supplied derivation "
>>> 490: + "inputs, using the " + source + " "
>>> 491: + theOne.provider(
On Fri, 2 May 2025 12:50:41 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - merge
>> - add a positive debug log and update exception message
>> - enhancing exception m
Collections.synchronizedList() returns a List implementation that doesn't do
proper locking. This PR does the following on the synchronized wrapper:
- overrides and adds locking to SequencedCollection methods;
- performs instance management of reversed synchronized views;
- adds test for race con
> This change proposes to modify `java.io.File.delete()` so that regular files
> on Windows will not be deleted by default if their read-only attribute is
> set. A boolean-valued system compatibility property
> `jdk.io.File.deleteReadOnly` is defined to reinstate legacy behavior if
> desired.
On Fri, 2 May 2025 18:02:57 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into
>> allocate_un_init_202501
>>
>>
On Fri, 2 May 2025 17:32:41 GMT, Roger Riggs wrote:
> This use of Unsafe is not warranted. If it can't be done with arrayCopy,
> leave the original code as is.
The core library also uses Unsafe.copyMemory in many places. Can it be used in
this scenario? Or can we find other ways to copy char[]
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Fri, 2 May 2025 03:55:24 GMT, Shaojin Wen wrote:
>> The byte[] allocated in Integer/Long.toString is fully filled, so we can use
>> StringConcatHelper::newArray to create byte[] to improve performance.
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a
On Fri, 2 May 2025 17:53:12 GMT, Raffaello Giulietti
wrote:
>>> Anyway, since the pre-checks are not precise, that would lead to an
>>> implementation with a loop with checked, and another one with unchecked
>>> multiplications. I don't think this buys you anything.
>>
>> It serves to skip th
On Fri, 2 May 2025 17:35:38 GMT, Roger Riggs wrote:
> The StringConcatHelper methods should not be used outside of StringConcat.
I had a version that used UNSAFE.allocateUninitializedArray , but @liach
suggested using StringConcatHelper.newArray
-
PR Comment: https://git.openjdk.o
On Fri, 2 May 2025 17:26:21 GMT, fabioromano1 wrote:
>> @fabioromano1 Well, there are two checks. In one the product can overflow,
>> you'd need to convert one of the operands to `long`.
>>
>> Anyway, since the pre-checks are not precise, that would lead to an
>> implementation with a loop wit
On Fri, 2 May 2025 16:57:43 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/lang/Math.java line 3500:
>>
>>> 3498: return (n & 0b1) == 0 ? 1 : -1;
>>> 3499: }
>>> 3500:
>>
>> Suggestion:
>>
>>
>> if (x == 2) {
>> if (n >= Integer.SIZE - 1)
On Fri, 2 May 2025 17:30:55 GMT, fabioromano1 wrote:
>> Again, I don't think that `n == 1` is a frequent case which would make any
>> practical difference.
>>
>> As for the `bitLength` check, the product might overflow.
>> Further, `bitLength` might not be that cheap.
>> Finally, the test would
On Fri, 2 May 2025 17:24:06 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Fri, 2 May 2025 16:55:49 GMT, Chen Liang wrote:
> May I prepare a quick patch to bring this in line with `TraverseProc` so we
> can skip this site for future start of release updates?
I know it is possible to write getSupportedSourceVersion to return the latest
version, but I don't think it
On Fri, 2 May 2025 17:39:16 GMT, Christoph wrote:
> And now I remember that probably this was the initial reason for using the
> original approach mentioned earlier with specifcying the app content
This means the two-stage packaging with signing is completely broken in
jpackage. Not good. Can
On Thu, 1 May 2025 21:58:18 GMT, Oleksii Sylichenko wrote:
>> Is `echo.` shorthand for `echo.exe`; if so, please change to the long form
>> to make it clearer the echo program is being run.
>
> No, `echo.` is not an executable, this is a command of the Windows Command
> Processor.
>
> See:
>
> Please review this PR to problemlist jdk & langtools tier1 tests requiring
> runtime usages of /bin/tools, for testing on static-jdk. The affected
> tests using following tools at runtime:
>
> - javac
> - javadoc
> - jar
> - jarsigner
> - jcmd
> - jimage
> - jps
>
> The latest teir1 testing r
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
> Please review this PR which reduces the amount of combinations tested by
> `LocaleNameProviderTest`.
>
> This test was exhaustively testing over 1000x1000 `Locale` combinations which
> was expensive and caused a timeout in tier 5. Narrowing down the tested
> locales to Japanese language ones
On Fri, 2 May 2025 03:55:24 GMT, Shaojin Wen wrote:
>> The byte[] allocated in Integer/Long.toString is fully filled, so we can use
>> StringConcatHelper::newArray to create byte[] to improve performance.
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a
On Fri, 2 May 2025 14:12:42 GMT, Per Minborg wrote:
> The performance before this PR can be seen in the "confined" benchmarks
> above. In those benchmarks, a regular `Arena.ofConfined` is created upon
> every invocation.
Yes - but I was referring to the performance of the native call -- not th
On Fri, 2 May 2025 03:49:39 GMT, Shaojin Wen wrote:
>> In BufferedReader.readLine and other similar scenarios, we need to use
>> StringBuilder.append(char[]) to build the string.
>>
>> For these scenarios, we can use the intrinsic method StringUTF16.compress
>> and Unsafe.copyMemory instead of
On Fri, 2 May 2025 16:53:39 GMT, Raffaello Giulietti
wrote:
> As for the `bitLength` check, the product might overflow. Further,
> `bitLength` might not be that cheap.
The current implementations of `bitLength()` calls `numberOfLeadingZeros`,
which are:
public static int numberOfLeadingZeros
On Fri, 2 May 2025 17:18:36 GMT, Raffaello Giulietti
wrote:
> Anyway, since the pre-checks are not precise, that would lead to an
> implementation with a loop with checked, and another one with unchecked
> multiplications. I don't think this buys you anything.
It serves to skip the checks in
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
On Fri, 2 May 2025 16:54:59 GMT, Chen Liang wrote:
> I have asked @nizarbenalla in offline communications for a list of failing
> hotspot tests. I aim to update them on a case-by-case basis, to determine if
> the compile arguments should provide a `--release ` argument or migrate
> class file
On Fri, 2 May 2025 17:03:30 GMT, fabioromano1 wrote:
>> I don't think there's a quick, _precise_ pre-check that would ensure that
>> the loop can just use simple, unchecked `*` multiplications.
>>
>> Consider `unsignedPowExact(3L, 40)`, which does not overflow, versus
>> `unsignedPowExact(3L,
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Fri, 2 May 2025 15:49:03 GMT, Justin Lu wrote:
> Please review this PR which reduces the amount of combinations tested by
> `LocaleNameProviderTest`.
>
> This test was exhaustively testing over 1000x1000 `Locale` combinations which
> was expensive and caused a timeout in tier 5. Narrowing d
On Fri, 2 May 2025 16:45:28 GMT, Raffaello Giulietti
wrote:
> I don't think there's a quick, _precise_ pre-check that would ensure that the
> loop can just use simple, unchecked `*` multiplications.
>
> Consider `unsignedPowExact(3L, 40)`, which does not overflow, versus
> `unsignedPowExact(3
> Propose to finalize scoped values.
> The only functional change is that the orElse() method no longer accepts a
> null argument.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Remove unnecessary @since 25
- Remove unnecessary @
On Thu, 24 Apr 2025 20:46:42 GMT, Brian Burkhalter wrote:
> Use the `@requires` tag instead of obtaining the operating system name from
> the `os.name` property and then exiting if the test is not run on that
> operating system.
This pull request has now been integrated.
Changeset: 5faa5590
A
On Thu, 24 Apr 2025 00:33:20 GMT, Brian Burkhalter wrote:
> For tests of the `java.io` package, instead of doing this
>
> public static void main(String[] args) throws Exception {
> if (File.separatorChar != '\') {
> /* This test is only valid on win32 systems */
>
On Fri, 2 May 2025 16:04:18 GMT, fabioromano1 wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clearer and more complete spec of the *pow* methods.
>
> src/java.base/share/classes/java/lang/Math.java line 350
On Fri, 2 May 2025 16:44:40 GMT, Joe Darcy wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java
>> line 58:
>>
>>> 56: */
>>> 57: @SupportedAnnotationTypes("*")
>>> 58: @SupportedSourceVersion(SourceVersion.RELEASE_26)
>>
>> This processor should emul
On Fri, 2 May 2025 16:45:42 GMT, Alan Bateman wrote:
>> There are various HotSpot tests that use ASM and they all fail under JDK 26
>> without this change.
>
> Hopefully new tests will use the ClassFile API and that over time that some
> of the existing tests that use ASM can be migrated.
I ha
On Fri, 2 May 2025 16:26:48 GMT, fabioromano1 wrote:
>> @fabioromano1 Unless there's evidence that these cases are _very very_
>> common, there's no point in adding fast paths.
>> See this comment in `unsignedPowExact(long,int)`
>>
>>
>> /*
>> * To keep the code as simple as p
On Fri, 2 May 2025 15:47:43 GMT, Chen Liang wrote:
>> Get JDK 26 underway.
>
> make/conf/version-numbers.conf line 36:
>
>> 34: DEFAULT_VERSION_EXTRA2=0
>> 35: DEFAULT_VERSION_EXTRA3=0
>> 36: DEFAULT_VERSION_DATE=2026-03-16
>
> Is this accurate?
One day off; should be 2026-03-17.
I should hav
On Fri, 2 May 2025 16:43:02 GMT, Joe Darcy wrote:
>> test/hotspot/jtreg/testlibrary/asm/org/objectweb/asm/ClassReader.java line
>> 229:
>>
>>> 227: // Check the class' major_version. This field is after the
>>> magic and minor_version fields, which
>>> 228: // use 4 and 2 bytes
On Fri, 2 May 2025 16:06:42 GMT, fabioromano1 wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clearer and more complete spec of the *pow* methods.
>
> src/java.base/share/classes/java/lang/Math.java line 361
On Fri, 2 May 2025 16:08:09 GMT, Shaojin Wen wrote:
>> Using an anonymous class for the cleanup action had very adverse effects on
>> performance. I didn't want to use a lambda for startup performance reasons.
>
> If using lambda affects performance, how about using anonymous classes?
>
>
On Fri, 2 May 2025 16:05:05 GMT, Brian Burkhalter wrote:
>> For tests of the `java.io` package, instead of doing this
>>
>> public static void main(String[] args) throws Exception {
>> if (File.separatorChar != '\') {
>> /* This test is only valid on win32 systems */
>>
On Fri, 2 May 2025 16:23:24 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/lang/Math.java line 3567:
>>
>>> 3565: return 1;
>>> 3566: }
>>> 3567: if (x == 0 || x == 1) {
>>
>> Suggestion:
>>
>> if (x == 0 || x == 1 || n == 1) {
>
> @fab
On Fri, 2 May 2025 16:07:31 GMT, fabioromano1 wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clearer and more complete spec of the *pow* methods.
>
> src/java.base/share/classes/java/lang/Math.java line 356
On Fri, 2 May 2025 14:11:19 GMT, Per Minborg wrote:
>>> any reason why you didn't use a lambda here?
>>
>> I also think that CleanupAction should be changed to lambda
>
> Using an anonymous class for the cleanup action had very adverse effects on
> performance. I didn't want to use a lambda for
On Fri, 2 May 2025 15:12:01 GMT, Raffaello Giulietti
wrote:
>> Add `powExact()` and `unsignedPowExact()` methods that operate on integer
>> values arguments.
>> Further, add `unsignedMultiplyExact` methods as well.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> a
On Thu, 24 Apr 2025 00:33:20 GMT, Brian Burkhalter wrote:
> For tests of the `java.io` package, instead of doing this
>
> public static void main(String[] args) throws Exception {
> if (File.separatorChar != '\') {
> /* This test is only valid on win32 systems */
>
> For tests of the `java.io` package, instead of doing this
>
> public static void main(String[] args) throws Exception {
> if (File.separatorChar != '\') {
> /* This test is only valid on win32 systems */
> return;
> }
>
> do this
>
>@requires (os
On Fri, 2 May 2025 14:48:01 GMT, Nizar Benalla wrote:
> Get JDK 26 underway.
Changes requested by liach (Reviewer).
make/conf/version-numbers.conf line 36:
> 34: DEFAULT_VERSION_EXTRA2=0
> 35: DEFAULT_VERSION_EXTRA3=0
> 36: DEFAULT_VERSION_DATE=2026-03-16
Is this accurate?
src/jdk.compiler/s
Please review this PR which reduces the amount of combinations tested by
`LocaleNameProviderTest`.
This test was exhaustively testing over 1000x1000 `Locale` combinations which
was expensive and caused a timeout in tier 5. Narrowing down the tested locales
to Japanese language ones can reduce o
On Fri, 2 May 2025 12:56:49 GMT, Jaikiran Pai wrote:
> I would suggest doing a similar run without specifying a specific test
> platform. That way it will get run on all relevant platforms. I don't expect
> it to fail, but it would be good to have that tested before this is
> integrated.
I ra
On Thu, 1 May 2025 14:50:31 GMT, Weijun Wang wrote:
>> Finalize the KDF API.
>
> Weijun Wang has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - merge
> - add a positive debug log and update exception message
> -
On Fri, 2 May 2025 15:12:01 GMT, Raffaello Giulietti
wrote:
>> Add `powExact()` and `unsignedPowExact()` methods that operate on integer
>> values arguments.
>> Further, add `unsignedMultiplyExact` methods as well.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> a
On Fri, 2 May 2025 14:21:54 GMT, Jaikiran Pai wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make some static arrays @Stable.
>
> If I understand correctly, we are talking about several (primitive) array
>
On Fri, 2 May 2025 13:19:13 GMT, Doug Lea wrote:
>> We logged several bugs on the LinkedBlockingDeque. This aggregates them into
>> a single bug report and PR.
>>
>> 1. LinkedBlockingDeque does not immediately throw InterruptedException in
>> put/take
>>
>> The LinkedBlockingDeque does not be
> The recent patch #23866 makes calling `ClassValue::remove()` from
> `ClassValue::computeValue()` end up in infinite loops while fixing the stale
> value risk from the method.
>
> The proposed fix is to preserve the stale value risk fix, and update the
> remove-from-compute behavior from the o
> Add `powExact()` and `unsignedPowExact()` methods that operate on integer
> values arguments.
> Further, add `unsignedMultiplyExact` methods as well.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Clearer and more complete
On Fri, 2 May 2025 14:48:01 GMT, Nizar Benalla wrote:
> Get JDK 26 underway.
This initial commit of the PR intentionally excludes the creation of the new
symbol files so that the fundamental code aspects of the update are easier to
see.
-
PR Comment: https://git.openjdk.org/jdk/p
Get JDK 26 underway.
-
Commit messages:
- Update copyright years
- Update --release 25 symbol information for JDK 24 build 20
- initial commit start-of-JDK-26
Changes: https://git.openjdk.org/jdk/pull/25008/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25008&range=00
On Fri, 2 May 2025 14:14:28 GMT, Per Minborg wrote:
> Can you summarize your proposed changes below as It was a bit unclear to me
> what you meant. I can create a separate PR with those changes later.
My suggestion is to use two records (both PerThread and Frame) to replace the
original inner
On Thu, 1 May 2025 05:33:29 GMT, Volkan Yazici wrote:
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 314:
> 312: *
> 313: * WARNING
On Fri, 2 May 2025 13:34:02 GMT, Raffaello Giulietti
wrote:
>> See the JBS bug for some details.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Make some static arrays @Stable.
If I understand correctly, we are ta
On Wed, 23 Apr 2025 14:05:58 GMT, Per Minborg wrote:
> This PR is based on the work of @mernst-github and aims to implement an
> _internal_ thread-local 'stack' allocator, which works like a dynamically
> sized arena, but with reset functionality to reset the allocated size back to
> a certain
On Fri, 2 May 2025 11:13:27 GMT, Per Minborg wrote:
>> This PR is based on the work of @mernst-github and aims to implement an
>> _internal_ thread-local 'stack' allocator, which works like a dynamically
>> sized arena, but with reset functionality to reset the allocated size back
>> to a cert
On Fri, 2 May 2025 14:06:23 GMT, Per Minborg wrote:
>> Add `powExact()` and `unsignedPowExact()` methods that operate on integer
>> values arguments.
>> Further, add `unsignedMultiplyExact` methods as well.
>
> Maybe it is too late, but shouldn't there be a better way to structure all
> these m
On Fri, 2 May 2025 11:56:31 GMT, Shaojin Wen wrote:
>> And, if you do that, you then don't need the `of` factory -- clients can
>> just use `new`
>
>> any reason why you didn't use a lambda here?
>
> I also think that CleanupAction should be changed to lambda
Using an anonymous class for the c
On Fri, 2 May 2025 13:34:02 GMT, Raffaello Giulietti
wrote:
>> See the JBS bug for some details.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Make some static arrays @Stable.
I'm not worried if C2 cannot optimiz
On Fri, 2 May 2025 11:47:32 GMT, Raffaello Giulietti
wrote:
> Add `powExact()` and `unsignedPowExact()` methods that operate on integer
> values arguments.
> Further, add `unsignedMultiplyExact` methods as well.
Maybe it is too late, but shouldn't there be a better way to structure all
these
1 - 100 of 147 matches
Mail list logo
