On Fri, 2 May 2025 14:48:01 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
> Get JDK 26 underway.
Changes requested by liach (Reviewer).
make/conf/version-numbers.conf line 36:
> 34: DEFAULT_VERSION_EXTRA2=0
> 35: DEFAULT_VERSION_EXTRA3=0
> 36: DEFAULT_VERSION_DATE=2026-03-16
Is this accurate?
src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java
line 58:
> 56: */
> 57: @SupportedAnnotationTypes("*")
> 58: @SupportedSourceVersion(SourceVersion.RELEASE_26)
This processor should emulate `com.sun.tools.jdeprscan.TraverseProc` and
override `getSupportedSourceVersion`.
test/hotspot/jtreg/testlibrary/asm/org/objectweb/asm/ClassReader.java line 229:
> 227: // Check the class' major_version. This field is after the magic
> and minor_version fields, which
> 228: // use 4 and 2 bytes respectively.
> 229: if (checkClassVersion && readShort(classFileOffset + 6) >
> Opcodes.V26) {
Please do not change ASM - if a test uses ASM to generate or parse later class
files, they must migrate to the ClassFile API. Open a JBS issue and identify
the hotspot tests failing without this change.
test/langtools/tools/javac/options/HelpOutputColumnWidthTest.java line 50:
> 48: public class HelpOutputColumnWidthTest extends TestRunner {
> 49:
> 50: public static final int MAX_COLUMNS = 84;
What is this for?
-------------
PR Review: https://git.openjdk.org/jdk/pull/25008#pullrequestreview-2812349246
PR Review Comment: https://git.openjdk.org/jdk/pull/25008#discussion_r2071811476
PR Review Comment: https://git.openjdk.org/jdk/pull/25008#discussion_r2071815767
PR Review Comment: https://git.openjdk.org/jdk/pull/25008#discussion_r2071819374
PR Review Comment: https://git.openjdk.org/jdk/pull/25008#discussion_r2071817584
