On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev <almat...@openjdk.org>
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fails. Exit code of jpackage is
> ignored, but generated application image will be checked for additional
> content.
> - This change is for macOS only.
> - Previous implementation of test (forcing expected exist code to 1) was not
> doing anything useful, since we never checked if additional content was
> copied or not.
Followed the stepa and built an unsigned image first and then signed the
jpackage build and created the pkg/dmg files. However, notarization fails as it
says it's not signed at all:
e.g.:
> "path": "JabRef-6.0_arm64.dmg/JabRef.app/Contents/MacOS/JabRef",
"message": "The binary is not signed with a valid Developer ID
certificate.",
[
notarylog.log](https://github.com/user-attachments/files/20016162/notarylog.log)
Testing now with a presigned image.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21698#issuecomment-2847722058
