On Fri, 2 May 2025 15:47:43 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Get JDK 26 underway.
>
> make/conf/version-numbers.conf line 36:
>
>> 34: DEFAULT_VERSION_EXTRA2=0
>> 35: DEFAULT_VERSION_EXTRA3=0
>> 36: DEFAULT_VERSION_DATE=2026-03-16
>
> Is this accurate?
One day off; should be 2026-03-17.
I should have double-checked that in the initial authoring of the change.
> src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java
> line 58:
>
>> 56: */
>> 57: @SupportedAnnotationTypes("*")
>> 58: @SupportedSourceVersion(SourceVersion.RELEASE_26)
>
> This processor should emulate `com.sun.tools.jdeprscan.TraverseProc` and
> override `getSupportedSourceVersion`.
The implementation of getSupportedSourceVersion inherited from
AbstractProcessor uses the value of this annotation.
> test/hotspot/jtreg/testlibrary/asm/org/objectweb/asm/ClassReader.java line
> 229:
>
>> 227: // Check the class' major_version. This field is after the
>> magic and minor_version fields, which
>> 228: // use 4 and 2 bytes respectively.
>> 229: if (checkClassVersion && readShort(classFileOffset + 6) >
>> Opcodes.V26) {
>
> Please do not change ASM - if a test uses ASM to generate or parse later
> class files, they must migrate to the ClassFile API. Open a JBS issue and
> identify the hotspot tests failing without this change.
There are various HotSpot tests that use ASM and they all fail under JDK 26
without this change.
> test/langtools/tools/javac/options/HelpOutputColumnWidthTest.java line 50:
>
>> 48: public class HelpOutputColumnWidthTest extends TestRunner {
>> 49:
>> 50: public static final int MAX_COLUMNS = 84;
>
> What is this for?
It is to accommodate the now longer list of --release values in the javac help
output,the addition of ", 26".
Splitting the list of releases over two lines would be a better solution, but I
didn't take that one when initially preparing the patch.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25008#discussion_r2071878858
PR Review Comment: https://git.openjdk.org/jdk/pull/25008#discussion_r2071883440
PR Review Comment: https://git.openjdk.org/jdk/pull/25008#discussion_r2071881672
PR Review Comment: https://git.openjdk.org/jdk/pull/25008#discussion_r2071880549
