On Thu, 1 May 2025 21:23:38 GMT, Mikhail Yankelevich <myankelev...@openjdk.org>
wrote:
>> - Symbolic links will not be followed for `--app-content` on all platforms.
>> - Added test to cover this case.
>> - `MacHelper` updated to use "cp -R" instead of "cp -r" when unpacking DMG,
>> since "cp -r" on macOS is not documented option and when used `cp` will
>> follow symbolic links which breaks test. "cp -R" does not follow symbolic
>> links.
>
> test/jdk/tools/jpackage/share/AppContentTest.java line 57:
>
>> 55: */
>> 56: public class AppContentTest {
>> 57:
>
> Nitpick: do you think it might be worth it to add a bug id to the `@test`?
No. I do not see a need. This is a generic test and not something specific to
particular JBS issue.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24974#discussion_r2072305435
