On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
> - It is not clear on which macOS versions codesign fails if application > bundle contains additional content. > - As a result test was modified to generate only application image, since PKG > or DMG cannot be generated if signing fails. Exit code of jpackage is > ignored, but generated application image will be checked for additional > content. > - This change is for macOS only. > - Previous implementation of test (forcing expected exist code to 1) was not > doing anything useful, since we never checked if additional content was > copied or not. When supplying mac sign to building the image, it does not work either and then applying. The current branch is here in this PR https://github.com/JabRef/jabref/pull/13032/ And now I remember that probably this was the initial reason for using the original approach mentioned earlier with specifcying the app content "severity": "error", "code": null, "path": "JabRef-6.0_arm64.dmg/JabRef.app/Contents/MacOS/JabRef", "message": "The signature of the binary is invalid.", "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087735";, "architecture": "arm64" } ------------- PR Comment: https://git.openjdk.org/jdk/pull/21698#issuecomment-2847757982
