[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6430: wireless/bcm430xx: rename chip minor id to 'x'

xiaoxiang781216 commented on code in PR #6430: URL: https://github.com/apache/incubator-nuttx/pull/6430#discussion_r896465864 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -483,6 +481,25 @@ int bcmf_core_upload_firmware(FAR struct bcmf_sdio_dev_s *sbus) #endif

[incubator-nuttx] 01/02: sched/env: Fix the return value of unsetenv()

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 1b32fc1642a163b6860c7b2eb9c5a8f60a3b9963 Author: Ville Juven AuthorDate: Mon Jun 13 15:00:44 2022 +0300

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6423: sched/env: Fix the return value of unsetenv()

pkarashchenko merged PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] branch master updated (cf91b403c9 -> dc2b2dcb3f)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from cf91b403c9 arch: imx6: Enable imx_idle.c to reduce CPU load new 1b32fc1642 sched/env: Fix the ret

[incubator-nuttx] 02/02: sched/env: Check for incoming parameter validity in unsetenv()

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit dc2b2dcb3f7f4561f880fbbbaa60fab90984ffa4 Author: Ville Juven AuthorDate: Mon Jun 13 15:51:12 2022 +0300

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

xiaoxiang781216 commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896469823 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6426: stm32wl5: add flash progmem driver support

xiaoxiang781216 commented on code in PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#discussion_r896501160 ## arch/arm/src/stm32wl5/stm32wl5_flash.c: ## @@ -359,6 +343,31 @@ ssize_t up_progmem_eraseblock(size_t block) } } +ssize_t up_progmem_ispageeras

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896531681 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896532186 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896534268 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896535318 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896536326 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896539021 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896539801 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896540264 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx-apps] cwespressif opened a new pull request, #1197: testing/irtest: Fix issue of failure to open multiple IR devices

cwespressif opened a new pull request, #1197: URL: https://github.com/apache/incubator-nuttx-apps/pull/1197 ## Summary Fix issue of failure to open multiple IR devices. ## Impact ## Testing `irtest` -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] onegray commented on pull request #6426: stm32wl5: add flash progmem driver support

onegray commented on PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#issuecomment-1154897429 I'm working on [adding a new chip stm32wb](https://github.com/apache/incubator-nuttx/pull/6422), which is similar in some things. So I think it might be helpful to compare our re

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6430: wireless/bcm430xx: rename chip minor id to 'x'

anchao commented on code in PR #6430: URL: https://github.com/apache/incubator-nuttx/pull/6430#discussion_r896581354 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -483,6 +481,25 @@ int bcmf_core_upload_firmware(FAR struct bcmf_sdio_dev_s *sbus) #endif defa

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6431: wirless/sdio: frame length should with guard bound

anchao opened a new pull request, #6431: URL: https://github.com/apache/incubator-nuttx/pull/6431 ## Summary wirless/sdio: frame length should with guard bound some SDIO device will return the larger frames out of bound error log: bcmf_sdpcm_readframe: Frame is too

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6432: wireless/bcm43xxx: add extended join parameters

anchao opened a new pull request, #6432: URL: https://github.com/apache/incubator-nuttx/pull/6432 ## Summary wireless/bcm43xxx: add extended join parameters ## Impact N/A ## Testing ci-check -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #1027: Remove errno accesses from the OS

pkarashchenko commented on issue #1027: URL: https://github.com/apache/incubator-nuttx/issues/1027#issuecomment-1155170735 I'm not sure if https://github.com/apache/incubator-nuttx/pull/6433 is contradicting to what is proposed here. Maybe we can discuss what is the best solution. -- Th

[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #1197: testing/irtest: Fix issue of failure to open multiple IR devices

Ouss4 merged PR #1197: URL: https://github.com/apache/incubator-nuttx-apps/pull/1197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[incubator-nuttx-apps] branch master updated: testing/irtest: Fix issue of failure to open multiple IR devices

This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 068905d07 testing/irtest: Fix

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #6433: sched: expose nxsched_ set/get APIs as system calls

pkarashchenko opened a new pull request, #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433 ## Summary - expose nxsched_ set/get APIs as syscalls - move corresponding sched_ and pthread_ set/get APIs to libc - remove _SCHED_ macro based interface - reduce number o

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #1027: Remove errno accesses from the OS

pkarashchenko commented on issue #1027: URL: https://github.com/apache/incubator-nuttx/issues/1027#issuecomment-1155275788 I expect that this proposal assumes that POSIX APIs are a system calls, however such approach introduce the implicit cancellation point support. For example the some o

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6432: wireless/bcm43xxx: add extended join parameters

anchao commented on code in PR #6432: URL: https://github.com/apache/incubator-nuttx/pull/6432#discussion_r896948471 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_ioctl.h: ## @@ -236,6 +239,40 @@ typedef struct wl_join_scan_params * between channel scans

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6432: wireless/bcm43xxx: add extended join parameters

xiaoxiang781216 commented on code in PR #6432: URL: https://github.com/apache/incubator-nuttx/pull/6432#discussion_r896938676 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_ioctl.h: ## @@ -236,6 +239,40 @@ typedef struct wl_join_scan_params * between chann

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6418: Eps32 Lilygo t5v2 BSP

pkarashchenko commented on code in PR #6418: URL: https://github.com/apache/incubator-nuttx/pull/6418#discussion_r896972478 ## boards/xtensa/esp32/ttgo_eink5_v2/src/esp32_bringup.c: ## @@ -0,0 +1,539 @@ +/**

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6431: wirless/sdio: frame length should with guard bound

pkarashchenko merged PR #6431: URL: https://github.com/apache/incubator-nuttx/pull/6431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] branch master updated: wirless/sdio: frame length should with guard bound

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 28b46bd381 wirless/sdio: frame l

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6430: wireless/bcm430xx: rename chip minor id to 'x'

pkarashchenko commented on code in PR #6430: URL: https://github.com/apache/incubator-nuttx/pull/6430#discussion_r896980537 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c: ## @@ -844,7 +837,16 @@ int bcmf_chipinitialize(FAR struct bcmf_sdio_dev_s *sbus) break; #end

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6430: wireless/bcm430xx: rename chip minor id to 'x'

xiaoxiang781216 commented on code in PR #6430: URL: https://github.com/apache/incubator-nuttx/pull/6430#discussion_r896984106 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c: ## @@ -844,7 +837,16 @@ int bcmf_chipinitialize(FAR struct bcmf_sdio_dev_s *sbus) break; #e

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

pkarashchenko commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896984526 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,111 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address,

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6430: wireless/bcm430xx: rename chip minor id to 'x'

anchao commented on code in PR #6430: URL: https://github.com/apache/incubator-nuttx/pull/6430#discussion_r896988419 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c: ## @@ -844,7 +837,16 @@ int bcmf_chipinitialize(FAR struct bcmf_sdio_dev_s *sbus) break; #endif +#

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896992246 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,111 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r897017423 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,111 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #1027: Remove errno accesses from the OS

pkarashchenko commented on issue #1027: URL: https://github.com/apache/incubator-nuttx/issues/1027#issuecomment-1155408495 For the most of the cases when API is not a cancellation point it is easy to make NX API as a system call and create a libc wrapper that will handle `errno` correctly.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

xiaoxiang781216 commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r897015976 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,111 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address,

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6428: net/tcp: d_appdata should remove the tcp specific option field

pkarashchenko commented on code in PR #6428: URL: https://github.com/apache/incubator-nuttx/pull/6428#discussion_r897039891 ## net/tcp/tcp_input.c: ## @@ -629,6 +629,17 @@ static void tcp_input(FAR struct net_driver_s *dev, uint8_t domain, dev->d_len -= (len + iplen); +

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6426: stm32wl5: add flash progmem driver support

xiaoxiang781216 commented on PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#issuecomment-1155456792 @onegray do you want we wait you finish review before merging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6432: wireless/bcm43xxx: add extended join parameters

xiaoxiang781216 merged PR #6432: URL: https://github.com/apache/incubator-nuttx/pull/6432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: wireless/bcm43xxx: add extended join parameters

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4659e00fac wireless/bcm43xxx: add ex

[GitHub] [incubator-nuttx] onegray commented on a diff in pull request #6426: stm32wl5: add flash progmem driver support

onegray commented on code in PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#discussion_r896523732 ## arch/arm/src/stm32wl5/hardware/stm32wl5_flash.h: ## @@ -131,174 +129,174 @@ /* Register Addresses ***/

[GitHub] [incubator-nuttx] onegray commented on a diff in pull request #6426: stm32wl5: add flash progmem driver support

onegray commented on code in PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#discussion_r897095057 ## arch/arm/src/stm32wl5/hardware/stm32wl5_flash.h: ## @@ -131,174 +129,174 @@ /* Register Addresses ***/

[GitHub] [incubator-nuttx] onegray commented on pull request #6426: stm32wl5: add flash progmem driver support

onegray commented on PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#issuecomment-1155483551 > do you want we wait you finish review before merging? @xiaoxiang781216 I've finished and have proposed minor changes. I just forget to submit my review, thanks. -- This

[incubator-nuttx] branch master updated: wireless/bcm430xx: rename chip minor id to 'x'

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new f6b8cc1407 wireless/bcm430xx: rename

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6430: wireless/bcm430xx: rename chip minor id to 'x'

xiaoxiang781216 merged PR #6430: URL: https://github.com/apache/incubator-nuttx/pull/6430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] mlyszczek commented on pull request #6426: stm32wl5: add flash progmem driver support

mlyszczek commented on PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#issuecomment-1155530316 @onegray Thank you for your review. Good findings! How familliar are you with both of stm32wl and stm32wb chips? If they are similar maybe we could think about merging the

[GitHub] [incubator-nuttx] onegray commented on pull request #6426: stm32wl5: add flash progmem driver support

onegray commented on PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#issuecomment-1155582100 > How familliar are you with both of stm32wl and stm32wb chips? If they are similar maybe we could think about merging these two chips into single stm32wx? I have no experience

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

pkarashchenko commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r897208843 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,107 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address,

[GitHub] [incubator-nuttx] mlyszczek commented on pull request #6426: stm32wl5: add flash progmem driver support

mlyszczek commented on PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#issuecomment-1155597332 > > How familliar are you with both of stm32wl and stm32wb chips? If they are similar maybe we could think about merging these two chips into single stm32wx? > > I have n

[GitHub] [incubator-nuttx] onegray commented on pull request #6426: stm32wl5: add flash progmem driver support

onegray commented on PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#issuecomment-1155610086 > In that case, expect from me to steal from your code :) Hahaha, you are welcome :) I think the common parts belong to L4. -- This is an automated message

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6433: sched: expose nxsched_ set/get APIs as system calls

xiaoxiang781216 commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897222929 ## include/sys/syscall_lookup.h: ## @@ -33,13 +33,13 @@ SYSCALL_LOOKUP(gettid, 0) SYSCALL_LOOKUP(getppid, 0) #en

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6433: sched: expose nxsched_ set/get APIs as system calls

pkarashchenko commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897230196 ## include/cxx/csched: ## @@ -44,6 +44,12 @@ namespace std using ::sched_get_priority_max; using ::sched_get_priority_min; using ::sched_rr_get_in

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6433: sched: expose nxsched_ set/get APIs as system calls

acassis commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897231328 ## arch/arm/src/cxd56xx/cxd56_farapi.c: ## @@ -196,14 +196,14 @@ void farapi_main(int id, void *arg, struct modulelist_s *mlist) { /* Save the curre

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6433: sched: expose nxsched_ set/get APIs as system calls

pkarashchenko commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897232384 ## include/sys/syscall_lookup.h: ## @@ -33,13 +33,13 @@ SYSCALL_LOOKUP(gettid, 0) SYSCALL_LOOKUP(getppid, 0) #endi

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6433: sched: expose nxsched_ set/get APIs as system calls

pkarashchenko commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897233022 ## arch/arm/src/cxd56xx/cxd56_farapi.c: ## @@ -196,14 +196,14 @@ void farapi_main(int id, void *arg, struct modulelist_s *mlist) { /* Save the

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6433: sched: expose nxsched_ set/get APIs as system calls

pkarashchenko commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897235287 ## arch/arm/src/cxd56xx/cxd56_farapi.c: ## @@ -196,14 +196,14 @@ void farapi_main(int id, void *arg, struct modulelist_s *mlist) { /* Save the

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6433: sched: expose nxsched_ set/get APIs as system calls

pkarashchenko commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897235697 ## arch/arm/src/cxd56xx/cxd56_farapi.c: ## @@ -196,14 +196,14 @@ void farapi_main(int id, void *arg, struct modulelist_s *mlist) { /* Save the

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6433: sched: expose nxsched_ set/get APIs as system calls

pkarashchenko commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897249956 ## include/sys/syscall_lookup.h: ## @@ -33,13 +33,13 @@ SYSCALL_LOOKUP(gettid, 0) SYSCALL_LOOKUP(getppid, 0) #endi

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6434: include/cxx: Remove all non standard c++ header files

xiaoxiang781216 opened a new pull request, #6434: URL: https://github.com/apache/incubator-nuttx/pull/6434 ## Summary All standard header files can check here: https://en.cppreference.com/w/cpp/header ## Impact ## Testing -- This is an automated message from the

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6435: drivers/syslog: reuse rmutex_t for the recursive check

xiaoxiang781216 opened a new pull request, #6435: URL: https://github.com/apache/incubator-nuttx/pull/6435 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] davids5 commented on pull request #6434: include/cxx: Remove all non standard c++ header files

davids5 commented on PR #6434: URL: https://github.com/apache/incubator-nuttx/pull/6434#issuecomment-1155689067 Where will ::close be defined? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[incubator-nuttx-website] branch asf-site updated: Publishing web: 42e9e27963415ec1359277228669d6b9c71c48d1 docs: f6b8cc140752c1ea35a9e10d32824eb701956ffe

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 1c5d247 Publishing web

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request, #1198: webclient: Allow users to specify extra headers for proxy

yamt opened a new pull request, #1198: URL: https://github.com/apache/incubator-nuttx-apps/pull/1198 ## Summary My primary motivation at this point is to use it for basic proxy auth. (specify "Proxy-Authorization" header) But there can be other use cases for proxy-specific extra

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6434: include/cxx: Remove all non standard c++ header files

xiaoxiang781216 commented on PR #6434: URL: https://github.com/apache/incubator-nuttx/pull/6434#issuecomment-1155938024 > Where will ::close be defined? unistd.h. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6435: drivers/syslog: reuse rmutex_t for the recursive check

pkarashchenko commented on code in PR #6435: URL: https://github.com/apache/incubator-nuttx/pull/6435#discussion_r897499348 ## include/nuttx/mutex.h: ## @@ -419,7 +419,7 @@ static inline int nxrmutex_trylock(FAR rmutex_t *rmutex) static inline bool nxrmutex_is_locked(FAR rmut

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6433: sched: expose nxsched_ set/get APIs as system calls

xiaoxiang781216 commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897504364 ## include/cxx/csched: ## @@ -44,6 +44,12 @@ namespace std using ::sched_get_priority_max; using ::sched_get_priority_min; using ::sched_rr_get_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6435: drivers/syslog: reuse rmutex_t for the recursive check

xiaoxiang781216 commented on code in PR #6435: URL: https://github.com/apache/incubator-nuttx/pull/6435#discussion_r897507834 ## include/nuttx/mutex.h: ## @@ -419,7 +419,7 @@ static inline int nxrmutex_trylock(FAR rmutex_t *rmutex) static inline bool nxrmutex_is_locked(FAR rm

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6435: drivers/syslog: reuse rmutex_t for the recursive check

pkarashchenko commented on code in PR #6435: URL: https://github.com/apache/incubator-nuttx/pull/6435#discussion_r897512045 ## drivers/syslog/syslog_device.c: ## @@ -169,15 +150,7 @@ static inline int syslog_dev_takesem(FAR struct syslog_dev_s *syslog_dev) static inline void

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6435: drivers/syslog: reuse rmutex_t for the recursive check

xiaoxiang781216 commented on code in PR #6435: URL: https://github.com/apache/incubator-nuttx/pull/6435#discussion_r897530173 ## drivers/syslog/syslog_device.c: ## @@ -169,15 +150,7 @@ static inline int syslog_dev_takesem(FAR struct syslog_dev_s *syslog_dev) static inline vo

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1199: Remove the non standard c++ header file inclusion

xiaoxiang781216 opened a new pull request, #1199: URL: https://github.com/apache/incubator-nuttx-apps/pull/1199 ## Summary Found by https://github.com/apache/incubator-nuttx/pull/6434 ## Impact ## Testing -- This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6435: drivers/syslog: reuse rmutex_t for the recursive check

xiaoxiang781216 commented on code in PR #6435: URL: https://github.com/apache/incubator-nuttx/pull/6435#discussion_r897532084 ## drivers/syslog/syslog_device.c: ## @@ -83,8 +79,7 @@ struct syslog_dev_s uint8_t sl_state;/* See enum syslog_dev_state */ uint8_t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6435: drivers/syslog: reuse rmutex_t for the recursive check

xiaoxiang781216 commented on code in PR #6435: URL: https://github.com/apache/incubator-nuttx/pull/6435#discussion_r897532084 ## drivers/syslog/syslog_device.c: ## @@ -83,8 +79,7 @@ struct syslog_dev_s uint8_t sl_state;/* See enum syslog_dev_state */ uint8_t

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6435: drivers/syslog: reuse rmutex_t for the recursive check

pkarashchenko commented on code in PR #6435: URL: https://github.com/apache/incubator-nuttx/pull/6435#discussion_r897533709 ## drivers/syslog/syslog_device.c: ## @@ -169,15 +150,7 @@ static inline int syslog_dev_takesem(FAR struct syslog_dev_s *syslog_dev) static inline void

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6434: include/cxx: Remove all non standard c++ header files

pkarashchenko commented on PR #6434: URL: https://github.com/apache/incubator-nuttx/pull/6434#issuecomment-1155986803 ``` ./src/cwidgetcontrol.cxx:30:10: fatal error: csched: No such file or directory 30 | #include ``` -- This is an automated message from the Apache Git Servi

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1199: Remove the non standard c++ header file inclusion

pkarashchenko commented on PR #1199: URL: https://github.com/apache/incubator-nuttx-apps/pull/1199#issuecomment-1155987391 Please remove Gerrit Change-ID -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1199: Remove the non standard c++ header file inclusion

xiaoxiang781216 commented on PR #1199: URL: https://github.com/apache/incubator-nuttx-apps/pull/1199#issuecomment-1156007939 > Please remove Gerrit Change-ID Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6427: wireless/bcm43xxx: load nvram from file system

anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r897562992 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ## @@ -328,24 +331,107 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcm

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1199: Remove the non standard c++ header file inclusion

pkarashchenko commented on PR #1199: URL: https://github.com/apache/incubator-nuttx-apps/pull/1199#issuecomment-1156051491 Seems like we need some more changes: ``` src/ctouchscreen.cxx: In destructor 'NxWM::CTouchscreen::~CTouchscreen()': Error: src/ctouchscreen.cxx:105:12: error: