xiaoxiang781216 commented on code in PR #6433: URL: https://github.com/apache/incubator-nuttx/pull/6433#discussion_r897222929
########## include/sys/syscall_lookup.h: ########## @@ -33,13 +33,13 @@ SYSCALL_LOOKUP(gettid, 0) SYSCALL_LOOKUP(getppid, 0) #endif -SYSCALL_LOOKUP(sched_getparam, 2) -SYSCALL_LOOKUP(sched_getscheduler, 1) +SYSCALL_LOOKUP(nxsched_get_param, 2) +SYSCALL_LOOKUP(nxsched_get_scheduler, 1) SYSCALL_LOOKUP(sched_lock, 0) Review Comment: what' rule to add or not add the nx prefix? ########## include/cxx/csched: ########## @@ -44,6 +44,12 @@ namespace std using ::sched_get_priority_max; using ::sched_get_priority_min; using ::sched_rr_get_interval; +#ifdef CONFIG_SMP Review Comment: But, csched is never a standard c++ header. It's better to let C++ code include sched.h directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
