anchao commented on code in PR #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427#discussion_r896536326
########## drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c: ########## @@ -328,24 +331,114 @@ int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, int bcmf_upload_nvram(FAR struct bcmf_sdio_dev_s *sbus) { - int ret; + FAR uint8_t *nvram_buf; uint32_t nvram_sz; uint32_t token; + int ret; + +#ifdef CONFIG_IEEE80211_BROADCOM_FWFILES + const char *nvfile = CONFIG_IEEE80211_BROADCOM_NVFILENAME; + unsigned char swap[32]; + struct file finfo; Review Comment: style same with bcmf_upload_file ``` int bcmf_upload_file(FAR struct bcmf_sdio_dev_s *sbus, uint32_t address, FAR const char *path) { struct file finfo; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org