[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6435: drivers/syslog: reuse rmutex_t for the recursive check

[GitBox]

xiaoxiang781216 commented on code in PR #6435:
URL: https://github.com/apache/incubator-nuttx/pull/6435#discussion_r897530173


##########
drivers/syslog/syslog_device.c:
##########
@@ -169,15 +150,7 @@ static inline int syslog_dev_takesem(FAR struct 
syslog_dev_s *syslog_dev)
 
 static inline void syslog_dev_givesem(FAR struct syslog_dev_s *syslog_dev)
 {
-#ifdef CONFIG_DEBUG_ASSERTIONS
-  pid_t me = getpid();
-  DEBUGASSERT(syslog_dev->sl_holder == me);

Review Comment:
   it's better to add to mutex.h



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org