surfskidude closed pull request #3071: Adding new example Xedge
URL: https://github.com/apache/nuttx-apps/pull/3071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
dakejahl closed issue #16373: [HELP] SPI TX DMA complete callback
URL: https://github.com/apache/nuttx/issues/16373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
dakejahl commented on issue #16373:
URL: https://github.com/apache/nuttx/issues/16373#issuecomment-2893017296
Thanks for the reply! Okay yeah that makes sense. Using signals makes sense,
there's a sem already in use for the STM32H7 SPI RX complete. Unfortunately I'm
dealing with a pre-compi
sumpfralle commented on PR #16401:
URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2892657130
> please rebase your patch to fix the conflict. BTW why sim-01 can't citest
with your patch?
I just pushed the rebased branch.
The sim-01 failure was in fact the consequen
xiaoxiang781216 commented on PR #16408:
URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2892572178
@ldube please fix the ci error:
https://github.com/apache/nuttx/actions/runs/15121852423/job/42505917973?pr=16408
--
This is an automated message from the Apache Git Service.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from df8a889bd0f arch/arm/rp23xx: resets: do not reset USBCTL, SYSCFG
add 87761477838 tools/Config.mk: add -DHAVE_ST
xiaoxiang781216 merged PR #16413:
URL: https://github.com/apache/nuttx/pull/16413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
ldube opened a new pull request, #16414:
URL: https://github.com/apache/nuttx/pull/16414
## Summary
Delete the board-specific usb host waiters and use the common code.
## Impact
Only affects users of sama5d3-xplained
## Testing
Add this to the sama5d3-xplain
acassis commented on issue #16412:
URL: https://github.com/apache/nuttx/issues/16412#issuecomment-2892140996
@snikeguo the preflight normally is used to double check that the buffer is
correctly aligned, that the memory source is DMA capable, etc. It also could be
used to enable some MCU sp
ldube commented on PR #16408:
URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2892114778
You are starting to sound like AI :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
acassis commented on PR #16408:
URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2892077210
> @acassis Yes, I agree those tasks are important, but you can't demand
extra from people who are contributing their time freely.
I just wanted to clarify that my suggestion about u
ldube commented on PR #16408:
URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2892036289
@acassis Yes, I agree those tasks are important, but you can't demand extra
from people who are contributing their time freely.
--
This is an automated message from the Apache Git Service
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 9520f5bfc8e [nxstyle]: fix Inconsistency in fu
xiaoxiang781216 merged PR #16411:
URL: https://github.com/apache/nuttx/pull/16411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095136393
##
fs/vfs/fs_open.c:
##
@@ -372,7 +372,7 @@ int file_open(FAR struct file *filep, FAR const char *path,
int oflags, ...)
if (ret >= OK)
{
- FS_ADD_BACKTR
acassis commented on PR #16408:
URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2891523182
> @acassis I see FOSS as an opportunity to work on things that interest me,
primarily when I'm motivated. I doubt I'll have time for extra things I didn't
plan. I'm starting to think keep
ldube commented on PR #16408:
URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2891456387
@acassis I see FOSS as an opportunity to work on things that interest me,
primarily when I'm motivated. I doubt I'll have time for extra things I didn't
plan. I'm starting to think keeping
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 3b27b444355 tools/nxstyle.c: fix error Relative file path on Windows
Native
add df8a889bd0f arch/arm/rp23xx: res
acassis merged PR #16395:
URL: https://github.com/apache/nuttx/pull/16395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891403355
> > So, I can't understand why need move fdsan/fdcheck to fcntl
>
> No need to move, the funtion nx_fcntl is just named very badly. But I'm
finally starting to undestand wha
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095922616
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
ldube closed pull request #16408: boards/sama5d3-xplained: Add knsh
configuration
URL: https://github.com/apache/nuttx/pull/16408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891372442
> So, I can't understand why need move fdsan/fdcheck to fcntl
No need to move, the funtion nx_fcntl is just named very badly. But I'm
finally starting to undestand what you want me t
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095922616
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
simbit18 opened a new pull request, #16413:
URL: https://github.com/apache/nuttx/pull/16413
## Summary
In all POSIX environments (Linux, Cygwin, MSYS2, macOS) strndup() function
is available.
add HOSTCFLAGS += -DHAVE_STRTOK_C=1 -DHAVE_STRNDUP=1
Required after PR #16396
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891308759
> > > I tried to modify the fcntl/ioctl calls to separate fd and file
requests. I don't think it is a good idea to modify/remove FIOC numbers.
> >
> >
> > if so, why not
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891276973
> > I tried to modify the fcntl/ioctl calls to separate fd and file
requests. I don't think it is a good idea to modify/remove FIOC numbers.
>
> if so, why not keep implement in nx_i
snikeguo opened a new issue, #16412:
URL: https://github.com/apache/nuttx/issues/16412
### Description
Is the stm32_dmapreflight check necessary? I can still successfully mount
the filesystem and read/write when CONFIG_ARCH_HAVE_SDIO_PREFLIGHT is set to
'n'. However, setting it to 'y
xiaoxiang781216 merged PR #16396:
URL: https://github.com/apache/nuttx/pull/16396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 631732e6476 Documentation/platforms/avr: move documents to fix table
of contents
add 3b27b444355 tools/nxstyle
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 6ed21ec1afa sched: Remove checking of WDOG_ISACTIVE when cancelling
wdog
add 6196327155d boards/avr/avrdx/brea
xiaoxiang781216 merged PR #16365:
URL: https://github.com/apache/nuttx/pull/16365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891209631
> I tried to modify the fcntl/ioctl calls to separate fd and file requests.
I don't think it is a good idea to modify/remove FIOC numbers.
if so, why not keep implement in n
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095821342
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init
simbit18 commented on code in PR #9782:
URL: https://github.com/apache/nuttx/pull/9782#discussion_r2095740641
##
tools/nxmake2cmake.py:
##
@@ -0,0 +1,270 @@
+#!/usr/bin/env python3
+
+# tools/nxmake2cmak
acassis commented on code in PR #16399:
URL: https://github.com/apache/nuttx/pull/16399#discussion_r2095719343
##
Documentation/platforms/arm/nrf53/boards/thingy53/index.rst:
##
@@ -78,6 +78,18 @@ nsh_cpunet
Basic NuttShell configuration for the network core (console enabled in
acassis closed pull request #16410: arch/avr: New patches to support AVRDA/AVRDB
URL: https://github.com/apache/nuttx/pull/16410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095591335
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFI
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095624051
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095624051
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095617002
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFI
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095597205
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFI
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from ccc974b2242 WIP: Documentation: replace first person perspectives
add 6ed21ec1afa sched: Remove checking of WDO
xiaoxiang781216 merged PR #16389:
URL: https://github.com/apache/nuttx/pull/16389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095608918
##
include/nuttx/fs/ioctl.h:
##
@@ -197,8 +197,6 @@
* configuration
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095605256
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095602534
##
fs/inode/fs_files.c:
##
@@ -858,6 +1027,263 @@ int fs_putfilep(FAR struct file *filep)
}
#endif
+/
xiaoxiang781216 commented on PR #16401:
URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2890831178
@sumpfralle please rebase your patch to fix the conflict. BTW why sim-01
can't citest with your patch?
--
This is an automated message from the Apache Git Service.
To respond to
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095592349
##
fs/inode/fs_files.c:
##
@@ -858,6 +1027,263 @@ int fs_putfilep(FAR struct file *filep)
}
#endif
+/***
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 9520f5bfc8e [nxstyle]: fix Inconsistency in function headers style
add ccc974b2242 WIP: Documentation: replace
xiaoxiang781216 merged PR #16407:
URL: https://github.com/apache/nuttx/pull/16407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095383461
##
include/nuttx/fs/ioctl.h:
##
@@ -197,8 +197,6 @@
* configuration
* OUT: N
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095515021
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */
jerpelea commented on PR #16410:
URL: https://github.com/apache/nuttx/pull/16410#issuecomment-2890602086
for a linear review history please use the original patches updated with the
latest version
https://github.com/apache/nuttx/pull/16365
Best regards
Alin
--
This is an
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2890406654
I tried to modify the fcntl/ioctl calls to separate fd and file requests. I
don't think it is a good idea to modify/remove FIOC numbers.
--
This is an automated message from the Apache G
acassis commented on PR #16408:
URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2890400719
> @acassis Is this a requirement?
Hi @ldube It is not a requirement, but it is an act of good faith, only then
will we finish converting all README.txt to the new standard.
--
Th
simbit18 opened a new pull request, #16411:
URL: https://github.com/apache/nuttx/pull/16411
## Summary
added to the end of the header a new line *
added space
Doc Function Headers
https://nuttx.apache.org/docs/latest/contributing/coding_style.html#function-headers
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095120372
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095136393
##
fs/vfs/fs_open.c:
##
@@ -372,7 +372,7 @@ int file_open(FAR struct file *filep, FAR const char *path,
int oflags, ...)
if (ret >= OK)
{
- FS_ADD_BACKTR
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095124199
##
include/nuttx/fs/ioctl.h:
##
@@ -197,8 +197,6 @@
* configuration
* OUT: N
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095120372
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095118825
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095112790
##
fs/inode/fs_files.c:
##
@@ -858,6 +1027,263 @@ int fs_putfilep(FAR struct file *filep)
}
#endif
+/
simbit18 commented on PR #16396:
URL: https://github.com/apache/nuttx/pull/16396#issuecomment-2890009093
@raiden00pl done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Fix-Point commented on code in PR #16394:
URL: https://github.com/apache/nuttx/pull/16394#discussion_r2094984901
##
sched/wdog/wd_start.c:
##
@@ -406,15 +406,12 @@ int wd_start_abstick(FAR struct wdog_s *wdog, clock_t
ticks,
*
***
70 matches
Mail list logo
