[PR] spinlock: Add spin_lock_init and spin_is_locked macro [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 opened a new pull request, #10861: URL: https://github.com/apache/nuttx/pull/10861 ## Summary align with Linux api naming. ## Impact new api ## Testing ci -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on PR #10605: URL: https://github.com/apache/nuttx/pull/10605#issuecomment-1748049854 @TaiJuWu please squash your patch. It's very easy to review the change between the update from github, so you don't need split the new change into the separated patch. BTW, please

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346795877 ## include/nuttx/spinlock.h: ## @@ -49,6 +49,21 @@ typedef uint8_t spinlock_t; * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t. */ +#if d

[nuttx] branch master updated (6521bdfa1f -> bf6606f80c)

2023-10-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 6521bdfa1f esp32s3/ble: fix saving/restoring the interrupt status flags add bf6606f80c libxx: Use gnu++20 optio

Re: [PR] libxx: Use gnu++20 option only if using libcxx [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 merged PR #10860: URL: https://github.com/apache/nuttx/pull/10860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] rw spinlock prototype [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1346789695 ## include/nuttx/spinlock.h: ## @@ -285,7 +290,7 @@ void spin_unlock_wo_note(FAR volatile spinlock_t *lock); *

Re: [PR] rw spinlock prototype [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1346731951 ## sched/semaphore/spinlock.c: ## @@ -384,4 +388,138 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned int cpu, } #endif +#if defined(CONFIG_RW_SPINLOCK) +

Re: [PR] rw spinlock prototype [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1346732396 ## include/nuttx/spinlock.h: ## @@ -51,6 +51,11 @@ typedef uint8_t spinlock_t; #include +#if defined(CONFIG_RW_SPINLOCK) Review Comment: Done. -- This is

Re: [PR] rw spinlock prototype [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1346731951 ## sched/semaphore/spinlock.c: ## @@ -384,4 +388,138 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned int cpu, } #endif +#if defined(CONFIG_RW_SPINLOCK) +

[nuttx] branch master updated (2e93882bcf -> 6521bdfa1f)

2023-10-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 2e93882bcf esp32/ble: Fix task_create_wrapper CPU core ID passed as argument add 86b118854e esp32s3/irq: Fix e

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 merged PR #10854: URL: https://github.com/apache/nuttx/pull/10854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541 ## include/nuttx/spinlock.h: ## @@ -49,6 +49,21 @@ typedef uint8_t spinlock_t; * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t. */ +#if defined(C

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541 ## include/nuttx/spinlock.h: ## @@ -49,6 +49,21 @@ typedef uint8_t spinlock_t; * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t. */ +#if defined(C

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541 ## include/nuttx/spinlock.h: ## @@ -49,6 +49,21 @@ typedef uint8_t spinlock_t; * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t. */ +#if defined(C

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541 ## include/nuttx/spinlock.h: ## @@ -49,6 +49,21 @@ typedef uint8_t spinlock_t; * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t. */ +#if defined(C

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346701893 ## sched/semaphore/spinlock.c: ## @@ -189,6 +224,25 @@ spinlock_t spin_trylock(FAR volatile spinlock_t *lock) spinlock_t spin_trylock_wo_note(FAR volatile spinlock_t

[PR] libxx: Use gnu++20 option only if using libcxx [nuttx]

2023-10-04 Thread via GitHub
SPRESENSE opened a new pull request, #10860: URL: https://github.com/apache/nuttx/pull/10860 ## Summary Fix an issue that gnu++20 option is always used. By https://github.com/apache/nuttx/pull/8244#discussion_r1294750528, when libcxx is not used, gnu++17 should be retained. ## I

[nuttx-website] branch asf-site updated: Publishing web: 07abea83aab63736f2895f109c448ae631509f46 docs: 2e93882bcfbbeccb0a8ad4ddffb79f75ab7bc271

2023-10-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new eb34747c Publishing web: 07abea83

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541 ## include/nuttx/spinlock.h: ## @@ -49,6 +49,21 @@ typedef uint8_t spinlock_t; * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t. */ +#if defined(C

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541 ## include/nuttx/spinlock.h: ## @@ -49,6 +49,21 @@ typedef uint8_t spinlock_t; * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t. */ +#if defined(C

Re: [I] imxrt/lpi2c multibyte read broken following DMA addition [nuttx]

2023-10-04 Thread via GitHub
acassis commented on issue #10853: URL: https://github.com/apache/nuttx/issues/10853#issuecomment-1747765665 @thebolt please consider integrating RX8900 RTC into mainline, it will help more people. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] imxrt/lpi2c multibyte read broken following DMA addition [nuttx]

2023-10-04 Thread via GitHub
acassis commented on issue #10853: URL: https://github.com/apache/nuttx/issues/10853#issuecomment-1747764641 @davids5 git blame pointed you, could you please take a look? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346535035 ## include/nuttx/spinlock.h: ## @@ -49,6 +49,21 @@ typedef uint8_t spinlock_t; * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t. */ +#if defined(C

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346535035 ## include/nuttx/spinlock.h: ## @@ -49,6 +49,21 @@ typedef uint8_t spinlock_t; * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t. */ +#if defined(C

Re: [PR] rw spinlock prototype [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1346505267 ## sched/semaphore/spinlock.c: ## @@ -384,4 +388,138 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned int cpu, } #endif +#if defined(CONFIG_RW_SPINLOCK) +

Re: [PR] rw spinlock prototype [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1346502131 ## include/nuttx/spinlock.h: ## @@ -285,7 +290,7 @@ void spin_unlock_wo_note(FAR volatile spinlock_t *lock); *

Re: [PR] rw spinlock prototype [nuttx]

2023-10-04 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1346500501 ## include/nuttx/spinlock.h: ## @@ -51,6 +51,11 @@ typedef uint8_t spinlock_t; #include +#if defined(CONFIG_RW_SPINLOCK) Review Comment: It should be added to

[nuttx] branch master updated: esp32/ble: Fix task_create_wrapper CPU core ID passed as argument

2023-10-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2e93882bcf esp32/ble: Fix task_create_wrap

Re: [PR] esp32/ble: Fix task_create_wrapper CPU core ID passed as argument [nuttx]

2023-10-04 Thread via GitHub
pkarashchenko merged PR #10859: URL: https://github.com/apache/nuttx/pull/10859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

Re: [PR] rw spinlock prototype [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1346359981 ## sched/semaphore/spinlock.c: ## @@ -384,4 +388,138 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned int cpu, } #endif +#if defined(CONFIG_RW_SPI

Re: [PR] rw spinlock prototype [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1346235964 ## include/nuttx/spinlock.h: ## @@ -285,7 +290,7 @@ void spin_unlock_wo_note(FAR volatile spinlock_t *lock); *

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
tmedicci commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346355485 ## arch/xtensa/src/esp32s3/esp32s3_spiflash.c: ## @@ -858,6 +924,178 @@ IRAM_ATTR int spi_flash_read(uint32_t src_addr, void *dest, uint32_t size) } #endif /* CONFI

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
tmedicci commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346343511 ## arch/xtensa/src/esp32s3/esp32s3_irq.c: ## @@ -785,6 +873,15 @@ int esp32s3_setup_irq(int cpu, int periphid, int priority, int type) intmap[cpuint] = CPUINT_ASSI

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
pkarashchenko commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346328585 ## arch/xtensa/src/esp32s3/esp32s3_irq.c: ## @@ -785,6 +873,15 @@ int esp32s3_setup_irq(int cpu, int periphid, int priority, int type) intmap[cpuint] = CPUINT

Re: [PR] Implement ticket spinlock [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10605: URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346262202 ## sched/semaphore/CMakeLists.txt: ## @@ -40,4 +40,8 @@ if(CONFIG_SPINLOCK) list(APPEND CSRCS spinlock.c) endif() +if(CONFIG_TICKET_SPINLOCK) Review Comm

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
tmedicci commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346291532 ## arch/xtensa/src/esp32s3/esp32s3_irq.h: ## @@ -132,6 +134,126 @@ void esp32s3_teardown_irq(int cpu, int periphid, int cpuint); int esp32s3_getirq(int cpu, int cp

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
pkarashchenko commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346279601 ## arch/xtensa/src/esp32s3/esp32s3_ble_adapter.c: ## @@ -834,26 +892,32 @@ static void IRAM_ATTR task_yield_from_isr(void) static void *semphr_create_wrapper(uin

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
tmedicci commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346275963 ## arch/xtensa/src/esp32s3/esp32s3_ble_adapter.c: ## @@ -896,7 +960,8 @@ static int IRAM_ATTR semphr_take_from_isr_wrapper(void *semphr, void *hptw) { *(int *)hpt

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
tmedicci commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346266382 ## arch/xtensa/src/esp32s3/esp32s3_ble_adapter.c: ## @@ -717,7 +754,7 @@ static void interrupt_handler_set_wrapper(int intr_num, void *fn, void *arg) adapter->arg

Re: [PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10856: URL: https://github.com/apache/nuttx/pull/10856#discussion_r1346261062 ## arch/risc-v/src/common/riscv_addrenv.c: ## @@ -421,6 +422,12 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize, heapsize = heapsize + M

Re: [PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10856: URL: https://github.com/apache/nuttx/pull/10856#discussion_r1346259547 ## arch/risc-v/src/common/riscv_addrenv.c: ## @@ -421,6 +422,12 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize, heapsize = hea

Re: [PR] Add basic IEEE-1588 PTP server/client [nuttx-apps]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #2101: URL: https://github.com/apache/nuttx-apps/pull/2101#discussion_r1346251501 ## netutils/ptpd/Makefile: ## @@ -0,0 +1,29 @@ + +# apps/netutils/ptpd/Makefile +

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on PR #10857: URL: https://github.com/apache/nuttx/pull/10857#issuecomment-1747366834 > is it a kernel mode bug? we never see this in the flat mode. Yes I think so. It works fine in flat mode for me as well. -- This is an automated message from the Apache Git Servic

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on PR #10857: URL: https://github.com/apache/nuttx/pull/10857#issuecomment-1747365481 is it a kernel mode bug? we never see this in the flat mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10857: URL: https://github.com/apache/nuttx/pull/10857#discussion_r1346245539 ## sched/task/task_exithook.c: ## @@ -465,7 +465,15 @@ void nxtask_exithook(FAR struct tcb_s *tcb, int status) * status (no zombies here!) */ - group

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on PR #10857: URL: https://github.com/apache/nuttx/pull/10857#issuecomment-1747361547 Btw, the crash occurs if another process is running, so some kind of bug exists in this case: ``` ville@workpc:~/wpc_toolchain/workspace/nuttx-bare/nuttx$ qemu-system-riscv64 -se

Re: [PR] CONFIG_BUILD_KERNEL: Print process name in assert dump [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10858: URL: https://github.com/apache/nuttx/pull/10858#discussion_r1346240310 ## sched/misc/assert.c: ## @@ -554,12 +554,22 @@ static void dump_deadlock(void) void _assert(FAR const char *filename, int linenum, FAR const char *msg,

Re: [PR] CONFIG_BUILD_KERNEL: Print process name in assert dump [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10858: URL: https://github.com/apache/nuttx/pull/10858#discussion_r1346235691 ## sched/misc/assert.c: ## @@ -554,12 +554,22 @@ static void dump_deadlock(void) void _assert(FAR const char *filename, int linenum, FAR const char *msg,

Re: [PR] samv7: channel gain switching in aefc [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on PR #10855: URL: https://github.com/apache/nuttx/pull/10855#issuecomment-1747348947 please squash your change, @SimonFilgis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] samv7: channel gain switching in aefc [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10855: URL: https://github.com/apache/nuttx/pull/10855#discussion_r1346232022 ## arch/arm/src/samv7/sam_afec.c: ## @@ -1021,20 +1025,53 @@ static int afec_ioctl(struct adc_dev_s *dev, int cmd, unsigned long arg) } break

Re: [PR] CONFIG_BUILD_KERNEL: Print process name in assert dump [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10858: URL: https://github.com/apache/nuttx/pull/10858#discussion_r1346222975 ## sched/misc/assert.c: ## @@ -554,12 +554,22 @@ static void dump_deadlock(void) void _assert(FAR const char *filename, int linenum, FAR const ch

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
pkarashchenko commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346219819 ## arch/xtensa/src/esp32s3/esp32s3_irq.c: ## @@ -965,6 +1094,189 @@ uint32_t *xtensa_int_decode(uint32_t cpuints, uint32_t *regs) } } + UNUSED(c

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10857: URL: https://github.com/apache/nuttx/pull/10857#discussion_r1346219402 ## sched/task/task_exithook.c: ## @@ -465,7 +465,15 @@ void nxtask_exithook(FAR struct tcb_s *tcb, int status) * status (no zombies here!) */ - group_leave(tc

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
pussuw closed pull request #10857: CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process URL: https://github.com/apache/nuttx/pull/10857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
tmedicci commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346198286 ## arch/xtensa/src/esp32s3/esp32s3_ble_adapter.c: ## @@ -736,7 +773,12 @@ static void interrupt_handler_set_wrapper(int intr_num, void *fn, void *arg) static void

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
tmedicci commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346197804 ## arch/xtensa/include/esp32s3/irq.h: ## @@ -37,6 +37,16 @@ #define ESP32S3_INT_PRIO_DEF1 +/* CPU interrupt flags: + * These flags can be used to specif

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10857: URL: https://github.com/apache/nuttx/pull/10857#discussion_r1346195434 ## sched/task/task_exithook.c: ## @@ -465,7 +465,15 @@ void nxtask_exithook(FAR struct tcb_s *tcb, int status) * status (no zombies here!) */ - group_leave(tc

[PR] esp32/ble: Fix task_create_wrapper CPU core ID passed as argument [nuttx]

2023-10-04 Thread via GitHub
tmedicci opened a new pull request, #10859: URL: https://github.com/apache/nuttx/pull/10859 ## Summary * esp32/ble: Fix task_create_wrapper CPU core ID passed as argument The registered `task_create_wrapper` receives the `core_id`, but the current implementation ignores this

Re: [PR] Add basic IEEE-1588 PTP server/client [nuttx-apps]

2023-10-04 Thread via GitHub
PetteriAimonen commented on code in PR #2101: URL: https://github.com/apache/nuttx-apps/pull/2101#discussion_r1346187026 ## netutils/ptpd/Makefile: ## @@ -0,0 +1,29 @@ + +# apps/netutils/ptpd/Makefile +#

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10857: URL: https://github.com/apache/nuttx/pull/10857#discussion_r1346186050 ## sched/task/task_exithook.c: ## @@ -465,7 +465,15 @@ void nxtask_exithook(FAR struct tcb_s *tcb, int status) * status (no zombies here!) */ - group_leave(tc

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10857: URL: https://github.com/apache/nuttx/pull/10857#discussion_r1346186050 ## sched/task/task_exithook.c: ## @@ -465,7 +465,15 @@ void nxtask_exithook(FAR struct tcb_s *tcb, int status) * status (no zombies here!) */ - group_leave(tc

Re: [PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10856: URL: https://github.com/apache/nuttx/pull/10856#discussion_r1346185129 ## arch/risc-v/src/common/riscv_addrenv.c: ## @@ -421,6 +422,12 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize, heapsize = heapsize + M

Re: [PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10856: URL: https://github.com/apache/nuttx/pull/10856#discussion_r1346150803 ## arch/risc-v/src/common/riscv_addrenv.c: ## @@ -421,6 +422,12 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize, heapsize = hea

Re: [PR] examples/foc: add support for streaming modulation state [nuttx-apps]

2023-10-04 Thread via GitHub
raiden00pl commented on code in PR #2104: URL: https://github.com/apache/nuttx-apps/pull/2104#discussion_r1346151466 ## industry/foc/float/foc_svm3.c: ## @@ -286,3 +289,33 @@ static void foc_modulation_run_f32(FAR foc_handler_f32_t *h, f_saturate(&duty[1], 0.0f, svm->cfg.pwm

Re: [PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10857: URL: https://github.com/apache/nuttx/pull/10857#discussion_r1346147862 ## sched/task/task_exithook.c: ## @@ -465,7 +465,15 @@ void nxtask_exithook(FAR struct tcb_s *tcb, int status) * status (no zombies here!) */ - group

Re: [PR] Add basic IEEE-1588 PTP server/client [nuttx-apps]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #2101: URL: https://github.com/apache/nuttx-apps/pull/2101#discussion_r1346131319 ## netutils/ptpd/Makefile: ## @@ -0,0 +1,29 @@ + +# apps/netutils/ptpd/Makefile +

Re: [PR] Shm example [nuttx-apps]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on PR #2105: URL: https://github.com/apache/nuttx-apps/pull/2105#issuecomment-1747219188 @trns1997 please fix the nxstyle warning: ``` ../nuttx/tools/checkpatch.sh -m -g 719d03a8c14b4ce6263d57666f1c6d3244af6a60..HEAD Error: /home/runner/work/nuttx-apps/nut

Re: [PR] examples/foc: add support for streaming modulation state [nuttx-apps]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #2104: URL: https://github.com/apache/nuttx-apps/pull/2104#discussion_r1346125032 ## industry/foc/float/foc_svm3.c: ## @@ -286,3 +289,33 @@ static void foc_modulation_run_f32(FAR foc_handler_f32_t *h, f_saturate(&duty[1], 0.0f, svm->cf

Re: [PR] samv7: channel gain switching in aefc [nuttx]

2023-10-04 Thread via GitHub
pkarashchenko commented on code in PR #10855: URL: https://github.com/apache/nuttx/pull/10855#discussion_r1346116527 ## arch/arm/include/samv7/sam_afec.h: ## @@ -0,0 +1,69 @@ +/ + * arch/arm/include/samv

Re: [PR] samv7: channel gain switching in aefc [nuttx]

2023-10-04 Thread via GitHub
pkarashchenko commented on code in PR #10855: URL: https://github.com/apache/nuttx/pull/10855#discussion_r1346097230 ## arch/arm/include/samv7/sam_afec.h: ## @@ -0,0 +1,69 @@ +/ + * arch/arm/include/samv

[PR] Shm example [nuttx-apps]

2023-10-04 Thread via GitHub
trns1997 opened a new pull request, #2105: URL: https://github.com/apache/nuttx-apps/pull/2105 ## Summary SHM example with producer and consumer ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] CONFIG_BUILD_KERNEL: Print process name in assert dump [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10858: URL: https://github.com/apache/nuttx/pull/10858#discussion_r1346069217 ## sched/misc/assert.c: ## @@ -554,12 +554,22 @@ static void dump_deadlock(void) void _assert(FAR const char *filename, int linenum, FAR const char *msg,

[PR] CONFIG_BUILD_KERNEL: Print process name in assert dump [nuttx]

2023-10-04 Thread via GitHub
pussuw opened a new pull request, #10858: URL: https://github.com/apache/nuttx/pull/10858 ## Summary In addition to printing out the thread name (task name in flat mode), print the parent process's name as well. It is quite useful to know which process is the parent of a faulting t

[PR] CONFIG_BUILD_KERNEL: PANIC() if someone tries to kill the init process [nuttx]

2023-10-04 Thread via GitHub
pussuw opened a new pull request, #10857: URL: https://github.com/apache/nuttx/pull/10857 ## Summary As everything is inherited from the init process, there is no way it can be allowed to be killed. Mark the init process's group ID and PANIC() at once if someone tries to kill it /

[PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
pussuw opened a new pull request, #10856: URL: https://github.com/apache/nuttx/pull/10856 ## Summary Fixes two bugs in risc-v address environment handling. - Not enough heap to allocate properly aligned TLS stack - Mapping kernel page tables with user page table flags is not a good i

[PR] samv7: channel gain switching in aefc [nuttx]

2023-10-04 Thread via GitHub
SimonFilgis opened a new pull request, #10855: URL: https://github.com/apache/nuttx/pull/10855 ## Summary via ioctl one can make use of the samv7's afec internal gain amplifiers ## Impact none ## Testing on custom board with current 0.000 ... 50 Amps, dynamic gain sele

Re: [PR] Add basic IEEE-1588 PTP server/client [nuttx-apps]

2023-10-04 Thread via GitHub
hartmannathan commented on code in PR #2101: URL: https://github.com/apache/nuttx-apps/pull/2101#discussion_r1345828049 ## netutils/ptpd/Makefile: ## @@ -0,0 +1,29 @@ + +# apps/netutils/ptpd/Makefile +#

Re: [PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
pkarashchenko commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1345752430 ## arch/xtensa/src/esp32s3/esp32s3_ble_adapter.c: ## @@ -736,7 +773,12 @@ static void interrupt_handler_set_wrapper(int intr_num, void *fn, void *arg) static

[PR] esp32s3/ble: enable the BLE interrupt during a SPI flash operation [nuttx]

2023-10-04 Thread via GitHub
tmedicci opened a new pull request, #10854: URL: https://github.com/apache/nuttx/pull/10854 ## Summary * esp32s3/irq: Fix erroneous interrupt allocation for each CPU core * esp32s3/ble: fix saving/restoring the interrupt status flags * esp32s3/irq: Allow IRAM ISRs to run

[PR] examples/foc: add support for streaming modulation state [nuttx-apps]

2023-10-04 Thread via GitHub
raiden00pl opened a new pull request, #2104: URL: https://github.com/apache/nuttx-apps/pull/2104 ## Summary - logging/nxscope/nxscope.c: fix indentation - industrail/foc: add an interface that returns the modulation state - examples/foc: support svm3 state with nxscope ##

[I] imxrt/lpi2c multibyte read broken following DMA addition [nuttx]

2023-10-04 Thread via GitHub
thebolt opened a new issue, #10853: URL: https://github.com/apache/nuttx/issues/10853 We are on Nuttx 12.2.1 release, with and without commit afdce6e8c2d9557c9032c91aebc997ba555bb721 back-applied. The device is a iMXRT 1062, and communicating with an RX8900 RTC using an in-house driver.

[nuttx] branch master updated (2ffb72917d -> 071fb18501)

2023-10-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 2ffb72917d The character U+ff0c "," could be confused with the ASCII character U+002c ",", which is more common

Re: [PR] xtensa/esp32s2: add UART RS485 support [nuttx]

2023-10-04 Thread via GitHub
pkarashchenko merged PR #10850: URL: https://github.com/apache/nuttx/pull/10850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt