TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346535035


##########
include/nuttx/spinlock.h:
##########
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
  * SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
  */
 
+#if defined(CONFIG_TICKET_SPINLOCK)
+#include <stdatomic.h>
+
+struct ticket_spinlock_s

Review Comment:
   Why is uint32_t ?
   It should be spinlock_t because if we uses aarch64 the spin clock size is 
64bit instead of 32bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to