xiaoxiang781216 commented on code in PR #7735:
URL: https://github.com/apache/nuttx/pull/7735#discussion_r1037857912
##
include/nuttx/notifier.h:
##
@@ -0,0 +1,199 @@
+/
+ * include/nuttx/notifier.h
+ *
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from c1c17794f9 arm/arm: generating assemble code in ARM states by default
add da6ab79d65 net/ipv4_input: Set IPv4 f
xiaoxiang781216 merged PR #7750:
URL: https://github.com/apache/nuttx/pull/7750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
qiaohaijiao commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037821686
##
system/nxplayer/nxplayer.c:
##
@@ -121,6 +131,27 @@ static const struct nxplayer_ext_fmt_s g_known_ext[] =
static const int g_known_ext_count = sizeof(g_kn
qiaohaijiao commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037819055
##
include/system/nxplayer.h:
##
@@ -72,6 +80,8 @@ struct nxplayer_s
uint16_ttreble; /* Treble as a whole % */
uint16_tbass; /* B
qiaohaijiao commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037818887
##
include/system/nxplayer.h:
##
@@ -39,6 +39,14 @@
* Public Type Declarations
/
qiaohaijiao commented on code in PR #7717:
URL: https://github.com/apache/nuttx/pull/7717#discussion_r1037818394
##
arch/sim/src/sim/sim_alsa.c:
##
@@ -702,6 +855,147 @@ static int sim_mixer_open(struct sim_audio_s *priv)
return 0;
}
+static int sim_audio_mp3_scale(mad_fix
qiaohaijiao commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037809858
##
system/nxplayer/nxplayer_mp3.c:
##
@@ -0,0 +1,321 @@
+/
+ * apps/system/nxplayer/n
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from fc4493b7f1 esp32-devkitc/wamr_wasi_debug: enable native-lib stuff
add c1c17794f9 arm/arm: generating assemble c
xiaoxiang781216 merged PR #7755:
URL: https://github.com/apache/nuttx/pull/7755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
xiaoxiang781216 merged PR #7756:
URL: https://github.com/apache/nuttx/pull/7756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new fc4493b7f1 esp32-devkitc/wamr_wasi_debug: enab
PeterBee97 commented on code in PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#discussion_r1037797335
##
include/nuttx/video/video.h:
##
@@ -641,6 +1097,89 @@ struct v4l2_querymenu
};
};
+struct v4l2_input
+{
+ uint32_t index; /* Which input */
+ ui
PeterBee97 commented on code in PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#discussion_r1037795560
##
include/nuttx/video/video.h:
##
@@ -641,6 +1097,89 @@ struct v4l2_querymenu
};
};
+struct v4l2_input
+{
+ uint32_t index; /* Which input */
+ ui
PeterBee97 commented on code in PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#discussion_r1037795157
##
drivers/video/video.c:
##
@@ -1076,6 +1100,30 @@ static int video_querycap(FAR struct v4l2_capability
*cap)
/* cap->driver needs to be NULL-terminated. */
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 84fa994f51 rpmsgdev: rpmsgdegv ioctl and seek buf fix
add 365b1f4bb8 drivers/video: add support for YUYV format
xiaoxiang781216 merged PR #7754:
URL: https://github.com/apache/nuttx/pull/7754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
qiaohaijiao commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037793939
##
system/nxplayer/nxplayer_mp3.c:
##
@@ -0,0 +1,321 @@
+/
+ * apps/system/nxplayer/n
qiaohaijiao commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037793787
##
system/nxplayer/nxplayer_mp3.c:
##
@@ -0,0 +1,321 @@
+/
+ * apps/system/nxplayer/n
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037789054
##
net/tcp/tcp.h:
##
@@ -385,6 +386,39 @@ extern "C"
{
#endif
+/
+ * Inline Functions
+ ***
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037788911
##
include/nuttx/net/ip.h:
##
@@ -238,6 +238,51 @@ extern "C"
* Public Function Prototypes
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037780674
##
net/udp/udp_recvfrom.c:
##
@@ -208,44 +181,34 @@ static inline void udp_readahead(struct udp_recvfrom_s
*pstate)
if ((iob = iob_peek_queue(&conn->readahead)) != N
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037780539
##
net/udp/udp_recvfrom.c:
##
@@ -126,19 +126,19 @@ static void udp_recvpktinfo(FAR struct udp_recvfrom_s
*pstate,
* Copy the read data from the packet
*
* Input
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037779462
##
net/pkt/pkt_input.c:
##
@@ -109,4 +111,38 @@ int pkt_input(struct net_driver_s *dev)
return ret;
}
+/*
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037779375
##
net/pkt/pkt_input.c:
##
@@ -65,10 +67,10 @@
*
/
-int pkt_input(struct net_driver_s *de
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037779272
##
net/icmpv6/icmpv6_reply.c:
##
@@ -117,6 +175,7 @@ void icmpv6_reply(FAR struct net_driver_s *dev, int type,
int code, int data)
/* Initialize the ICMPv6 header */
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037779107
##
net/icmpv6/icmpv6_reply.c:
##
@@ -108,6 +108,64 @@ void icmpv6_reply(FAR struct net_driver_s *dev, int type,
int code, int data)
if (datalen > ICMPv6_MINMTULEN - ip
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037778937
##
net/icmpv6/icmpv6_input.c:
##
@@ -87,82 +87,32 @@ static uint16_t icmpv6_datahandler(FAR struct net_driver_s
*dev,
unsigned int ipl
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037778818
##
net/icmp/icmp_sendmsg.c:
##
@@ -125,7 +129,7 @@ static void sendto_request(FAR struct net_driver_s *dev,
/* Calculate the ICMP checksum. */
icmp->icmpchksum =
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037778614
##
net/icmp/icmp_reply.c:
##
@@ -119,20 +119,75 @@ void icmp_reply(FAR struct net_driver_s *dev, int type,
int code)
if (datalen > ICMP_MAXMSGLEN - ipicmplen)
{
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037778456
##
net/icmp/icmp_reply.c:
##
@@ -119,20 +119,75 @@ void icmp_reply(FAR struct net_driver_s *dev, int type,
int code)
if (datalen > ICMP_MAXMSGLEN - ipicmplen)
{
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r103809
##
net/devif/devif_send.c:
##
@@ -65,10 +65,23 @@
*
/
-void devif_send(struct net_driver_
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r103578
##
net/devif/devif_pktsend.c:
##
@@ -83,16 +55,25 @@
void devif_pkt_send(FAR struct net_driver_s *dev, FAR const void *buf,
unsigned int len)
{
- D
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r103406
##
net/devif/devif_iobsend.c:
##
@@ -53,19 +53,77 @@
/
void devif_iob_send(FAR struct net_
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r103225
##
net/devif/devif_cansend.c:
##
@@ -83,16 +55,25 @@
void devif_can_send(FAR struct net_driver_s *dev, FAR const void *buf,
unsigned int len)
{
- D
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r103011
##
net/devif/devif_cansend.c:
##
@@ -83,16 +55,25 @@
void devif_can_send(FAR struct net_driver_s *dev, FAR const void *buf,
unsigned int len)
{
- D
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037776861
##
net/can/can_recvmsg.c:
##
@@ -122,6 +122,7 @@ static inline void can_add_recvlen(FAR struct
can_recvfrom_s *pstate,
static size_t can_recvfrom_newdata(FAR struct net_
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037776697
##
net/can/can_callback.c:
##
@@ -149,6 +133,34 @@ uint16_t can_callback(FAR struct net_driver_s *dev,
if ((flags & CAN_NEWDATA) != 0)
{
+#ifdef CONFIG_N
qiaohaijiao commented on code in PR #7717:
URL: https://github.com/apache/nuttx/pull/7717#discussion_r1037776459
##
arch/sim/src/sim/sim_alsa.c:
##
@@ -116,6 +177,32 @@ static const struct audio_ops_s g_sim_audio_ops =
.release = sim_audio_release,
};
+static const s
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037775288
##
net/arp/arp.h:
##
@@ -81,8 +81,11 @@
/* This is a helper pointer for accessing the contents of the IP header */
-#define ARPBUF((FAR struct arp_hdr_s *)&dev->d
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037774072
##
mm/iob/Kconfig:
##
@@ -41,7 +41,7 @@ config IOB_HEADSIZE
config IOB_ALIGNMENT
int "Alignment size of each I/O buffer"
- default 1
+ default 4
Re
xiaoxiang781216 commented on code in PR #7735:
URL: https://github.com/apache/nuttx/pull/7735#discussion_r1037773012
##
include/nuttx/notifier.h:
##
@@ -0,0 +1,197 @@
+/
+ * include/nuttx/notifier.h
+ *
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037772811
##
include/nuttx/net/netdev.h:
##
@@ -802,4 +936,88 @@ void net_incr32(FAR uint8_t *op32, uint16_t op16);
int netdev_lladdrsize(FAR struct net_driver_s *dev);
+/*
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037771931
##
include/nuttx/net/ip.h:
##
@@ -238,6 +238,51 @@ extern "C"
* Public Function Prototypes
yamt opened a new pull request, #7756:
URL: https://github.com/apache/nuttx/pull/7756
## Summary
* enable DLFCN.
* bump WAMR to a version which i happened to test.
* enable bulk-memory because it's required by recent versions of wasi-sdk,
which i happened to use to build
anchao opened a new pull request, #7755:
URL: https://github.com/apache/nuttx/pull/7755
## Summary
arm/arm: generating assemble code in ARM states by default
The following changes omit the arm version:
```
| commit d3210803512896607ef32ca5a90f4b3774aed8f7
| Auth
xiaoxiang781216 commented on PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#issuecomment-1334740464
@PeterBee97 thanks for clarifying the reference source. Since our
declaration (implementation is still different) come from FreeBSD, I think that
the concern about license should di
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 84fa994f51 rpmsgdev: rpmsgdegv ioctl and seek
xiaoxiang781216 merged PR #7753:
URL: https://github.com/apache/nuttx/pull/7753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
wengzhe commented on code in PR #7750:
URL: https://github.com/apache/nuttx/pull/7750#discussion_r1037765822
##
net/ipforward/ipv4_forward.c:
##
@@ -505,6 +502,37 @@ int ipv4_forward(FAR struct net_driver_s *dev, FAR struct
ipv4_hdr_s *ipv4)
drop:
ipv4_dropstats(ipv4);
+
PeterBee97 opened a new pull request, #7754:
URL: https://github.com/apache/nuttx/pull/7754
## Summary
Add definitions for two YUV formats (YUYV and YU12) used by most USB cameras
and v4l2loopback.
## Impact
## Testing
--
This is an automated message from the Apache Git
wengzhe commented on code in PR #7750:
URL: https://github.com/apache/nuttx/pull/7750#discussion_r1037757065
##
net/ipforward/ipv4_forward.c:
##
@@ -505,6 +502,37 @@ int ipv4_forward(FAR struct net_driver_s *dev, FAR struct
ipv4_hdr_s *ipv4)
drop:
ipv4_dropstats(ipv4);
+
PeterBee97 commented on PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#issuecomment-1334719072
> @PeterBee97 @xiaoxiang781216 these headers files seem to be a direct copy
of Linux V4L2 header that is GPL:
https://www.kernel.org/doc/html/v4.8/media/uapi/v4l/videodev.html
>
>
wengzhe commented on code in PR #7750:
URL: https://github.com/apache/nuttx/pull/7750#discussion_r1037755786
##
net/ipforward/ipv4_forward.c:
##
@@ -505,6 +502,37 @@ int ipv4_forward(FAR struct net_driver_s *dev, FAR struct
ipv4_hdr_s *ipv4)
drop:
ipv4_dropstats(ipv4);
+
wengzhe commented on code in PR #7750:
URL: https://github.com/apache/nuttx/pull/7750#discussion_r1037755691
##
net/ipforward/ipv4_forward.c:
##
@@ -505,6 +502,37 @@ int ipv4_forward(FAR struct net_driver_s *dev, FAR struct
ipv4_hdr_s *ipv4)
drop:
ipv4_dropstats(ipv4);
+
wengzhe commented on code in PR #7750:
URL: https://github.com/apache/nuttx/pull/7750#discussion_r1037749433
##
net/icmpv6/icmpv6_reply.c:
##
@@ -112,15 +112,19 @@ void icmpv6_reply(FAR struct net_driver_s *dev, int type,
int code, int data)
dev->d_len = ipicmplen + datale
xiaoxiang781216 commented on code in PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#discussion_r1037734150
##
drivers/video/video.c:
##
@@ -222,7 +222,13 @@ static int validate_frame_setting(enum v4l2_buf_type type,
/* internal function for each cmds of ioctl */
+
CV-Bowen opened a new pull request, #7753:
URL: https://github.com/apache/nuttx/pull/7753
## Summary
1. rpmsgdev ioctl: should assgin back the client return value to
cookie->result, then this return value can be returned to the application;
2. rpmsgdev seek: the type "off_t" may be 64b
xiaoxiang781216 commented on PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#issuecomment-1334687230
> @PeterBee97 @xiaoxiang781216 these headers files seem to be a direct copy
of Linux V4L2 header that is GPL:
https://www.kernel.org/doc/html/v4.8/media/uapi/v4l/videodev.html
>
pkarashchenko commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037706680
##
include/system/nxplayer.h:
##
@@ -39,6 +39,14 @@
* Public Type Declarations
pkarashchenko commented on code in PR #7717:
URL: https://github.com/apache/nuttx/pull/7717#discussion_r1037705437
##
arch/sim/src/sim/sim_alsa.c:
##
@@ -116,6 +177,32 @@ static const struct audio_ops_s g_sim_audio_ops =
.release = sim_audio_release,
};
+static const
pkarashchenko commented on code in PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#discussion_r1037702770
##
drivers/video/video.c:
##
@@ -1053,6 +1065,18 @@ static int video_close(FAR struct file *filep)
return ret;
}
+static ssize_t video_read(FAR struct file *f
pkarashchenko commented on PR #7743:
URL: https://github.com/apache/nuttx/pull/7743#issuecomment-1334643916
```
+ python3 -m pytest -m 'common or sim' ./ -B sim -P -L
/github/workspace/sources/nuttx/boards/sim/sim/sim/configs/citest/logs/sim/sim
-R sim -C
--json=/github/workspace/source
pkarashchenko commented on PR #7743:
URL: https://github.com/apache/nuttx/pull/7743#issuecomment-1334642145
I also see `warning: (SYSTEM_PING) selects NETUTILS_PING which has unmet
direct dependencies (NET_ICMP)`
--
This is an automated message from the Apache Git Service.
To respond to t
pkarashchenko commented on code in PR #7750:
URL: https://github.com/apache/nuttx/pull/7750#discussion_r1037694003
##
net/ipforward/ipv4_forward.c:
##
@@ -505,6 +502,37 @@ int ipv4_forward(FAR struct net_driver_s *dev, FAR struct
ipv4_hdr_s *ipv4)
drop:
ipv4_dropstats(ipv
pkarashchenko commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037680443
##
include/nuttx/net/ip.h:
##
@@ -238,6 +238,51 @@ extern "C"
* Public Function Prototypes
*
pkarashchenko commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1037678110
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -1069,10 +1137,13 @@ static void sam_adc_reset(struct adc_dev_s *dev)
/* Reset gain, offset, differential modes */
+#i
pkarashchenko commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1037677855
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 02e34c10 Publishing web: e978ad4c
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 77aede7c87 arm/thumb: outputs an implicit IT block to avoid build break
add b6c148e763 Style changes for sa
pkarashchenko merged PR #7752:
URL: https://github.com/apache/nuttx/pull/7752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.
TimJTi opened a new pull request, #7752:
URL: https://github.com/apache/nuttx/pull/7752
## Summary
Late feedback on PR #7702
## Impact
none
## Testing
none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1037614508
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%08x\n",
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1037597230
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%08x\n",
TimJTi commented on PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#issuecomment-1334495014
Since this is closed I can't just commit the suggestions here, so I'll do a
new PR in the next few days to fix these style issues. Although I suppose I
shouldn't rely on checkpatch.sh to fix
pkarashchenko commented on code in PR #7737:
URL: https://github.com/apache/nuttx/pull/7737#discussion_r1037579763
##
arch/arm/src/s32k3xx/Kconfig:
##
@@ -193,6 +193,14 @@ config S32K3XX_HAVE_ENET
select ARCH_PHY_INTERRUPT
select ARCH_HAVE_NETDEV_STATISTICS
+#
pkarashchenko commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1037576176
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%
pkarashchenko commented on code in PR #7724:
URL: https://github.com/apache/nuttx/pull/7724#discussion_r1037573738
##
libs/libc/stdlib/lib_strtod.c:
##
@@ -188,8 +227,17 @@ double strtod(FAR const char *str, FAR char **endptr)
/* Process an exponent string */
- if (*p ==
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 9ab97df0a57d92caf509824c9bc15309a71bc242
Author: chao an
AuthorDate: Fri Dec 2 02:20:09 2022 +0800
arm/cortex
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 77aede7c87b3364eb30cce31db421a88321fb0d1
Author: chao an
AuthorDate: Fri Dec 2 03:03:57 2022 +0800
arm/thumb:
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 8ee2ed0b91 littlefs: add a few Kconfig options
new d321080351 arm/cortex-[a|r]: generating assemble code in
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit d3210803512896607ef32ca5a90f4b3774aed8f7
Author: chao an
AuthorDate: Fri Dec 2 02:52:18 2022 +0800
arm/cortex
pkarashchenko merged PR #7751:
URL: https://github.com/apache/nuttx/pull/7751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037520421
##
include/nuttx/net/netdev.h:
##
@@ -154,17 +157,25 @@
# define NETDEV_ERRORS(dev)
#endif
-/* There are some helper pointers for accessing the contents of the Ethern
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037518290
##
net/devif/devif_poll.c:
##
@@ -769,6 +875,69 @@ int devif_poll(FAR struct net_driver_s *dev,
devif_poll_callback_t callback)
/* Nothing more to do */
}
+
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037517413
##
net/netdev/netdev_input.c:
##
@@ -0,0 +1,117 @@
+/
+ * net/netdev/netdev_input.c
+ *
+ * Lic
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037516015
##
net/devif/devif_poll.c:
##
@@ -617,12 +617,89 @@ static inline int devif_poll_tcp_connections(FAR struct
net_driver_s *dev,
# define devif_poll_tcp_connections(dev, c
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037511062
##
arch/sim/src/sim/sim_netdriver.c:
##
@@ -334,22 +358,21 @@ int sim_netdriver_init(void)
netdriver_txdone_interrupt,
netdriver_rxre
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037509112
##
net/tcp/tcp_recvfrom.c:
##
@@ -244,6 +255,7 @@ static inline void tcp_readahead(struct tcp_recvfrom_s
*pstate)
*/
recvlen = iob_copyout(pstate->ir_buf
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037508713
##
net/udp/udp_sendto_buffered.c:
##
@@ -737,14 +749,21 @@ ssize_t psock_udp_sendto(FAR struct socket *psock, FAR
const void *buf,
memcpy(&wrb->wb_dest, to, to
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037507896
##
include/nuttx/net/netdev.h:
##
@@ -802,4 +936,88 @@ void net_incr32(FAR uint8_t *op32, uint16_t op16);
int netdev_lladdrsize(FAR struct net_driver_s *dev);
+/*
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037504024
##
net/utils/net_icmpchksum.c:
##
@@ -61,6 +61,23 @@ uint16_t icmp_chksum(FAR struct net_driver_s *dev, int len)
}
#endif /* CONFIG_NET_ICMP */
+/*
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037503280
##
net/utils/Make.defs:
##
@@ -21,7 +21,11 @@
# Common utilities
NET_CSRCS += net_dsec2tick.c net_dsec2timeval.c net_timeval2dsec.c
-NET_CSRCS += net_chksum.c net_ipch
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037501649
##
net/Kconfig:
##
@@ -117,6 +117,15 @@ config NET_GUARDSIZE
packet size will be chopped down to the size indicated in the
TCP
header.
+
acassis commented on code in PR #7750:
URL: https://github.com/apache/nuttx/pull/7750#discussion_r1037478781
##
net/icmpv6/icmpv6_reply.c:
##
@@ -112,15 +112,19 @@ void icmpv6_reply(FAR struct net_driver_s *dev, int type,
int code, int data)
dev->d_len = ipicmplen + datale
anchao opened a new pull request, #7751:
URL: https://github.com/apache/nuttx/pull/7751
## Summary
1. arm/cortex-[a|r]/thumb: force assembler files to be interpreted as Thumb
code
The option '-mthumb' is only valid for C source files and it is not passed
to the assembler.
acassis commented on PR #7743:
URL: https://github.com/apache/nuttx/pull/7743#issuecomment-1334228346
@ttnie any idea why CI is failing? I restart the failing jobs and the issue
remains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
acassis commented on PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#issuecomment-1334226046
@PeterBee97 @xiaoxiang781216 these headers files seem to be a direct copy of
Linux V4L2 header that is GPL:
https://www.kernel.org/doc/html/v4.8/media/uapi/v4l/videodev.html
Please
xiaoxiang781216 commented on code in PR #7735:
URL: https://github.com/apache/nuttx/pull/7735#discussion_r1037443177
##
include/nuttx/notifier.h:
##
@@ -0,0 +1,197 @@
+/
+ * include/nuttx/notifier.h
+ *
xiaoxiang781216 commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037364684
##
net/utils/Make.defs:
##
@@ -21,7 +21,11 @@
# Common utilities
NET_CSRCS += net_dsec2tick.c net_dsec2timeval.c net_timeval2dsec.c
-NET_CSRCS += net_chksum.c
1 - 100 of 138 matches
Mail list logo