qiaohaijiao commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037821686
##########
system/nxplayer/nxplayer.c:
##########
@@ -121,6 +131,27 @@ static const struct nxplayer_ext_fmt_s g_known_ext[] =
static const int g_known_ext_count = sizeof(g_known_ext) /
sizeof(struct nxplayer_ext_fmt_s);
+
+static const struct nxplayer_dec_ops_s g_dec_mp3 =
+{
+ AUDIO_FMT_MP3,
+ nxplayer_parse_mp3,
+ nxplayer_fill_mp3
+};
+
+static const struct nxplayer_dec_ops_s g_dec_pcm =
+{
+ AUDIO_FMT_PCM,
+ NULL,
+ nxplayer_fill_pcm
+};
+
+static const struct nxplayer_dec_ops_s g_dec_s[] =
Review Comment:
hello pkarashchenko,
there is no copy, use the reference of g_dec_pcm or g_dec_mp3 in function
`nxplayer_playinternal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
