PeterBee97 commented on code in PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#discussion_r1037795560
##########
include/nuttx/video/video.h:
##########
@@ -641,6 +1097,89 @@ struct v4l2_querymenu
};
};
+struct v4l2_input
+{
+ uint32_t index; /* Which input */
+ uint8_t name[32]; /* Label */
+ uint32_t type; /* Type of input */
+ uint32_t audioset; /* Associated audios (bitfield) */
+ uint32_t tuner; /* enum v4l2_tuner_type */
+ v4l2_std_id std;
+ uint32_t status;
+ uint32_t capabilities;
+ uint32_t reserved[3];
+};
+
+/* Values for the 'type' field */
+
+#define V4L2_INPUT_TYPE_TUNER 1
Review Comment:
I have rewritten then into enums so that the code position is still good for
reference while not breaking NuttX rules.
##########
include/nuttx/video/video.h:
##########
@@ -641,6 +1097,89 @@ struct v4l2_querymenu
};
};
+struct v4l2_input
+{
+ uint32_t index; /* Which input */
+ uint8_t name[32]; /* Label */
+ uint32_t type; /* Type of input */
+ uint32_t audioset; /* Associated audios (bitfield) */
+ uint32_t tuner; /* enum v4l2_tuner_type */
+ v4l2_std_id std;
+ uint32_t status;
+ uint32_t capabilities;
+ uint32_t reserved[3];
+};
+
+/* Values for the 'type' field */
+
+#define V4L2_INPUT_TYPE_TUNER 1
Review Comment:
I have rewritten them into enums so that the code position is still good for
reference while not breaking NuttX rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
