[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #7702: Fix SAMA5D2 ADC and TSD problems

[GitBox]

pkarashchenko commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1037576176


##########
arch/arm/src/sama5/sam_adc.c:
##########
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
   int ret;
 
   DEBUGASSERT(priv != NULL);
-  ainfo("pending=%08x\n", priv->pending);
+  ainfo("pending=%08lx\n", priv->pending);

Review Comment:
   PRIx32



##########
arch/arm/src/sama5/sam_adc.c:
##########
@@ -2050,9 +2213,17 @@ struct adc_dev_s *sam_adc_initialize(void)
       /* Initialize the public ADC device data structure */
 
 #ifdef SAMA5_ADC_HAVE_CHANNELS
+      g_adcdev.ad_ops  = &g_adcops;
       priv->dev = &g_adcdev;
 #endif
 
+      g_adcdev.ad_priv = priv;
+
+      /* Initialize the private ADC device data structure */
+
+      nxmutex_init(&priv->lock);
+      priv->cb  = NULL;

Review Comment:
   ```suggestion
         priv->cb = NULL;
   ```
   



##########
arch/arm/src/sama5/sam_tsd.c:
##########
@@ -1318,7 +1382,11 @@ static void sam_tsd_tracking(struct sam_tsd_s *priv, 
uint32_t time)
           tracktim--;
         }
     }
-
+#elif defined (ATSAMA5D3)

Review Comment:
   ```suggestion
   #elif defined(ATSAMA5D3)
   ```
   



##########
arch/arm/src/sama5/sam_adc.c:
##########
@@ -2050,9 +2213,17 @@ struct adc_dev_s *sam_adc_initialize(void)
       /* Initialize the public ADC device data structure */
 
 #ifdef SAMA5_ADC_HAVE_CHANNELS
+      g_adcdev.ad_ops  = &g_adcops;

Review Comment:
   ```suggestion
         g_adcdev.ad_ops = &g_adcops;
   ```
   



##########
arch/arm/src/sama5/sam_tsd.c:
##########
@@ -137,6 +137,18 @@
 #  define MAX(a,b) (((a) > (b)) ? (a) : (b))
 #endif
 
+#ifndef BOARD_TSSCTIM
+# define BOARD_TSSCTIM 0

Review Comment:
   ```suggestion
   #  define BOARD_TSSCTIM 0
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org