PeterBee97 commented on code in PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#discussion_r1037795157
##########
drivers/video/video.c:
##########
@@ -1076,6 +1100,30 @@ static int video_querycap(FAR struct v4l2_capability
*cap)
/* cap->driver needs to be NULL-terminated. */
strlcpy((FAR char *)cap->driver, name, sizeof(cap->driver));
+ cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
+
+ return OK;
+}
+
+static int video_g_input(FAR int *num)
+{
+ *num = 0;
Review Comment:
Not really, our driver does not support any input format standards(NTSC,
PAL, etc.) so we should return 0 here. It is the same behavior as that on my
USB camera. Changing it to >0 while not supporting ENUMINPUT will cause
application such as FFmpeg to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
