anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037518290
##########
net/devif/devif_poll.c:
##########
@@ -769,6 +875,69 @@ int devif_poll(FAR struct net_driver_s *dev,
devif_poll_callback_t callback)
/* Nothing more to do */
}
+ /* Device polling completed, release iob */
+
+ netdev_iob_release(dev);
+
+ return bstop;
+}
+
+/****************************************************************************
+ * Name: devif_poll
+ *
+ * Description:
+ * This function will traverse each active network connection structure and
+ * will perform network polling operations. devif_poll() may be called
+ * asynchronously with the network driver can accept another outgoing
+ * packet.
+ *
+ * This function will call the provided callback function for every active
+ * connection. Polling will continue until all connections have been polled
+ * or until the user-supplied function returns a non-zero value (which it
+ * should do only if it cannot accept further write data).
+ *
+ * When the callback function is called, there may be an outbound packet
+ * waiting for service in the device packet buffer, and if so the d_len
+ * field is set to a value larger than zero. The device driver should then
+ * send out the packet.
+ *
+ * Compatible with all old flat buffer NICs
+ *
+ * tcp_poll()/udp_poll()/pkt_poll()/...(l3|l4)
+ * / \
+ * / \
+ * devif_poll_[l3|l4]_connections() devif_iob_send() (nocopy:udp/icmp/..)
+ * / \ (copy:tcp)
+ * / \
+ * devif_iob_poll(devif_poll_callback()) devif_poll_callback()
+ * / \
+ * / \
+ * devif_poll("NIC"_txpoll) "NIC"_send()(dev->d_buf)
+ *
+ *
+ * Assumptions:
+ * This function is called from the MAC device driver with the network
+ * locked.
+ *
+ ****************************************************************************/
+
+int devif_poll(FAR struct net_driver_s *dev, devif_poll_callback_t callback)
+{
+ int bstop;
+
+ /* Hook the original callback/buffer before device poll,
+ * devif_poll_callback() will convert the stack iob to flat buffer.
+ */
+
+ dev->d_pollcallback = callback;
+ dev->d_pollbuf = dev->d_buf;
+
+ bstop = devif_iob_poll(dev, devif_poll_callback);
Review Comment:
Unlikely here, unless the iob prepare/release is moved outside devif_iob_poll
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
