[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027239747 ## arch/sim/src/sim/up_netdriver.c: ## @@ -107,6 +120,10 @@ static void netdriver_reply(struct net_driver_s *dev) if (dev->d_len > 0) { +#ifdef SIM_NET

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027237283 ## arch/sim/src/sim/up_netdriver.c: ## @@ -107,6 +120,10 @@ static void netdriver_reply(struct net_driver_s *dev) if (dev->d_len > 0) { +#ifdef SIM_NET

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

pkarashchenko commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027234848 ## arch/sim/src/sim/up_netdriver.c: ## @@ -107,6 +120,10 @@ static void netdriver_reply(struct net_driver_s *dev) if (dev->d_len > 0) { +#ifdef

[incubator-nuttx-apps] branch master updated: wapi: fix passphrase can not update if prefix is same

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new dc90c5241 wapi: fix passphr

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1425: wapi: fix save_config can not update if string prefix is same

pkarashchenko merged PR #1425: URL: https://github.com/apache/incubator-nuttx-apps/pull/1425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1425: wapi: fix save_config can not update if string prefix is same

pkarashchenko commented on code in PR #1425: URL: https://github.com/apache/incubator-nuttx-apps/pull/1425#discussion_r1027234677 ## wireless/wapi/src/util.c: ## @@ -148,7 +148,7 @@ static bool wapi_json_update(FAR cJSON *root, int len = strlen(obj->valuestring);

[GitHub] [incubator-nuttx] anchao commented on pull request #7625: net/icmp: ICMP_NO_STACK should not depends on NET_IPv4

anchao commented on PR #7625: URL: https://github.com/apache/incubator-nuttx/pull/7625#issuecomment-1321052045 depends on https://github.com/apache/incubator-nuttx-apps/pull/1428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx-apps] anchao opened a new pull request, #1428: system/ping[6]: ping[6] should also be enabled if NET_ICMP[v6]_NO_STACK == y

anchao opened a new pull request, #1428: URL: https://github.com/apache/incubator-nuttx-apps/pull/1428 ## Summary system/ping[6]: ping[6] should also be enabled if NET_ICMP[v6]_NO_STACK == y ## Impact N/A ## Testing icmp ping -- This is an automated messa

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1427: Fix Error: vi.c:888:57: error: format string is not a string literal(potentially insecure)

xiaoxiang781216 opened a new pull request, #1427: URL: https://github.com/apache/incubator-nuttx-apps/pull/1427 ## Summary ## Impact Minor change ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] anchao commented on pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#issuecomment-1321044699 Mark this PR as a draft until we complete the network sanity test from internally. welcome any suggestions for this offload scheme -- This is an automated message from the Apache

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027228166 ## net/tcp/tcp_send_buffered.c: ## @@ -244,6 +244,44 @@ static inline void psock_lost_connection(FAR struct tcp_conn_s *conn, } } +/

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027228016 ## net/devif/devif_iobsend.c: ## @@ -53,24 +53,65 @@ / void devif_iob_send(FAR s

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227936 ## net/devif/devif_poll.c: ## @@ -639,15 +698,44 @@ static inline int devif_poll_tcp_connections(FAR struct net_driver_s *dev, * field is set to a value lar

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227906 ## net/devif/devif_poll.c: ## @@ -616,12 +616,71 @@ static inline int devif_poll_tcp_connections(FAR struct net_driver_s *dev, # define devif_poll_tcp_connecti

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227859 ## net/devif/devif_iobsend.c: ## @@ -53,24 +53,65 @@ / void devif_iob_send(FAR s

[GitHub] [incubator-nuttx-apps] zhhyu7 commented on a diff in pull request #1425: wapi: fix save_config can not update if string prefix is same

zhhyu7 commented on code in PR #1425: URL: https://github.com/apache/incubator-nuttx-apps/pull/1425#discussion_r1027227854 ## wireless/wapi/src/util.c: ## @@ -148,7 +148,7 @@ static bool wapi_json_update(FAR cJSON *root, int len = strlen(obj->valuestring);

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227824 ## net/devif/devif_poll.c: ## @@ -616,12 +616,71 @@ static inline int devif_poll_tcp_connections(FAR struct net_driver_s *dev, # define devif_poll_tcp_connecti

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227780 ## net/devif/devif_iobsend.c: ## @@ -53,24 +53,65 @@ / void devif_iob_send(FAR s

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227687 ## mm/iob/Kconfig: ## @@ -41,7 +41,7 @@ config IOB_HEADSIZE config IOB_ALIGNMENT int "Alignment size of each I/O buffer" - default 1 + def

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227607 ## net/icmp/icmp_recvmsg.c: ## @@ -227,79 +227,35 @@ static inline ssize_t icmp_readahead(FAR struct icmp_conn_s *conn, FA

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227537 ## net/icmp/icmp_input.c: ## @@ -100,86 +100,39 @@ static uint16_t icmp_datahandler(FAR struct net_driver_s *dev, FAR struct ipv4_hdr_s *ipv4; struct sock

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227383 ## net/devif/devif_poll.c: ## @@ -639,15 +698,44 @@ static inline int devif_poll_tcp_connections(FAR struct net_driver_s *dev, * field is set to a value lar

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227296 ## arch/sim/src/sim/up_netdriver.c: ## @@ -402,22 +436,21 @@ int netdriver_init(void) netdriver_txdone_interrupt, netdriver

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227212 ## arch/sim/src/sim/up_netdriver.c: ## @@ -107,6 +120,10 @@ static void netdriver_reply(struct net_driver_s *dev) if (dev->d_len > 0) { +#ifdef SIM_NET

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7616: net/l2/l3/l4: add support of iob offload

anchao commented on code in PR #7616: URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1027227037 ## arch/sim/src/sim/up_netdriver.c: ## @@ -72,6 +72,19 @@ #include "up_internal.h" +#if CONFIG_IOB_BUFSIZE > (MAX_NETDEV_PKTSIZE + \ +

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7625: net/icmp: ICMP_NO_STACK should not depends on NET_IPv4

anchao opened a new pull request, #7625: URL: https://github.com/apache/incubator-nuttx/pull/7625 ## Summary net/icmp: ICMP_NO_STACK should not depends on NET_IPv4 sim/vncserver: SIM_NETUSRSOCK does not require l3 protocol support ## Impact N/A ## Testing

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7624: tools/ci: Remove thttpd related config from the black list

xiaoxiang781216 opened a new pull request, #7624: URL: https://github.com/apache/incubator-nuttx/pull/7624 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[incubator-nuttx-website] branch asf-site updated: Publishing web: 7e21510459ba6f754fb1da76a14d643b3953b931 docs: 63bcca985fe53080fdae624141433df243fdb4e8

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 4cf78975 Publishing web

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7614: SAMA5D2 pio errors

TimJTi commented on code in PR #7614: URL: https://github.com/apache/incubator-nuttx/pull/7614#discussion_r1027132286 ## arch/arm/src/sama5/hardware/_sama5d2x_memorymap.h: ## @@ -517,9 +520,10 @@ #define SAM_SFRBU_VBASE (SAM_PERIPHC_VSECTION+SAM_SFRBU_OFFSET) #define

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7622: Fix clang compiler warning

pkarashchenko commented on code in PR #7622: URL: https://github.com/apache/incubator-nuttx/pull/7622#discussion_r1027125856 ## arch/arm/src/s32k1xx/s32k1xx_enet.c: ## @@ -1217,8 +1217,8 @@ static int s32k1xx_ifup_action(struct net_driver_s *dev, bool resetphy) int ret;

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7610: arch: rename arch special function name

xiaoxiang781216 commented on PR #7610: URL: https://github.com/apache/incubator-nuttx/pull/7610#issuecomment-1320935338 @davids5 and @pkarashchenko the patch is ready for review, please ignore the first three patch which belong to https://github.com/apache/incubator-nuttx/pull/7599 but this

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7599: nuttx/sched: remove nxsched_remove_blocked from up_unblock_task

xiaoxiang781216 commented on PR #7599: URL: https://github.com/apache/incubator-nuttx/pull/7599#issuecomment-1320934899 > I do not have anything against this change. Only need to clarify `group_addrenv()` usage in general, but if overall behaviour is kept as before and change is well tested

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7622: Fix clang compiler warning

xiaoxiang781216 commented on code in PR #7622: URL: https://github.com/apache/incubator-nuttx/pull/7622#discussion_r1027121681 ## arch/arm/src/s32k1xx/s32k1xx_enet.c: ## @@ -1217,8 +1217,8 @@ static int s32k1xx_ifup_action(struct net_driver_s *dev, bool resetphy) int ret;

[incubator-nuttx-apps] 02/02: Fix dac_main.c: error: format string is not a string literal (potentially insecure)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 0c200b8966fece082c6cf8d2d231bd34859a41f0 Author: Xiang Xiao AuthorDate: Sat Nov 19 13:17:16 2022 +0

[incubator-nuttx-apps] 01/02: Fix foc_fixed16_thr.c:188:27: error: variable 'time' set but not used

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 81de5d4c5962e45ad01031610032be10f2a2abd1 Author: Xiang Xiao AuthorDate: Sat Nov 19 12:56:41 2022 +0

[incubator-nuttx-apps] branch master updated (3a6775c8a -> 0c200b896)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 3a6775c8a examples/tcp_ipc_server: fix wrong file path typo new 81de5d4c5 Fix foc_fixed16_th

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7622: Fix clang compiler warning

xiaoxiang781216 commented on code in PR #7622: URL: https://github.com/apache/incubator-nuttx/pull/7622#discussion_r1027121681 ## arch/arm/src/s32k1xx/s32k1xx_enet.c: ## @@ -1217,8 +1217,8 @@ static int s32k1xx_ifup_action(struct net_driver_s *dev, bool resetphy) int ret;

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1426: Fix clang compiler warning

pkarashchenko merged PR #1426: URL: https://github.com/apache/incubator-nuttx-apps/pull/1426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1426: Fix clang compiler warning

pkarashchenko commented on code in PR #1426: URL: https://github.com/apache/incubator-nuttx-apps/pull/1426#discussion_r1027121781 ## examples/dac/dac_main.c: ## @@ -110,15 +110,15 @@ static void print_cmds(FAR const char *header, size_t ncmds,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7622: Fix clang compiler warning

xiaoxiang781216 commented on code in PR #7622: URL: https://github.com/apache/incubator-nuttx/pull/7622#discussion_r1027121681 ## arch/arm/src/s32k1xx/s32k1xx_enet.c: ## @@ -1217,8 +1217,8 @@ static int s32k1xx_ifup_action(struct net_driver_s *dev, bool resetphy) int ret;

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7622: Fix clang compiler warning

xiaoxiang781216 commented on code in PR #7622: URL: https://github.com/apache/incubator-nuttx/pull/7622#discussion_r1027121427 ## arch/arm/src/kinetis/kinetis_enet.c: ## @@ -872,7 +872,7 @@ static void kinetis_interrupt_work(void *arg) { /* An error has occurred, upd

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7622: Fix clang compiler warning

xiaoxiang781216 commented on code in PR #7622: URL: https://github.com/apache/incubator-nuttx/pull/7622#discussion_r1027121427 ## arch/arm/src/kinetis/kinetis_enet.c: ## @@ -872,7 +872,7 @@ static void kinetis_interrupt_work(void *arg) { /* An error has occurred, upd

[incubator-nuttx] 03/03: arch/armv7-r: Don't clear SCTLR_U bit since spec require it's always one

This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 63bcca985fe53080fdae624141433df243fdb4e8 Author: Xiang Xiao AuthorDate: Sat Nov 19 06:26:17 2022 +0800 ar

[incubator-nuttx] branch master updated (d088a48da4 -> 63bcca985f)

This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from d088a48da4 mpfs/knsh: Enable SHM for MPFS kernel mode build new 4abd626288 arch/armv7-r: Remove the non

[incubator-nuttx] 02/03: arch/armv7-a: Support the big endian in arm_pghead.S like arm_head.S

This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 4d56ef5d8c68650ebdc9a14181ca27d6e6419471 Author: Xiang Xiao AuthorDate: Sat Nov 19 06:19:42 2022 +0800 ar

[incubator-nuttx] 01/03: arch/armv7-r: Remove the nonexistent SCTLR_IE

This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 4abd6262883c632deca2a5059a3fd565cdeb4211 Author: Xiang Xiao AuthorDate: Sat Nov 19 04:14:45 2022 +0800 ar

[GitHub] [incubator-nuttx] acassis merged pull request #7621: Refine SCTLR register configuration to confirm the spec

acassis merged PR #7621: URL: https://github.com/apache/incubator-nuttx/pull/7621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1426: Fix clang compiler warning

xiaoxiang781216 commented on code in PR #1426: URL: https://github.com/apache/incubator-nuttx-apps/pull/1426#discussion_r1027120483 ## examples/foc/foc_fixed16_thr.c: ## @@ -185,9 +185,10 @@ int foc_fixed16_thr(FAR struct foc_ctrl_env_s *envp) struct foc_mq_s handle;

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1426: Fix clang compiler warning

xiaoxiang781216 commented on code in PR #1426: URL: https://github.com/apache/incubator-nuttx-apps/pull/1426#discussion_r1027120483 ## examples/foc/foc_fixed16_thr.c: ## @@ -185,9 +185,10 @@ int foc_fixed16_thr(FAR struct foc_ctrl_env_s *envp) struct foc_mq_s handle;

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1426: Fix clang compiler warning

xiaoxiang781216 commented on code in PR #1426: URL: https://github.com/apache/incubator-nuttx-apps/pull/1426#discussion_r1027120201 ## examples/dac/dac_main.c: ## @@ -110,15 +110,15 @@ static void print_cmds(FAR const char *header, size_t ncmds,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7621: Refine SCTLR register configuration to confirm the spec

xiaoxiang781216 commented on PR #7621: URL: https://github.com/apache/incubator-nuttx/pull/7621#issuecomment-1320929483 > @xiaoxiang781216 have you tried to run ARM in BE mode? No, we use only little endian mode. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7599: nuttx/sched: remove nxsched_remove_blocked from up_unblock_task

xiaoxiang781216 commented on PR #7599: URL: https://github.com/apache/incubator-nuttx/pull/7599#issuecomment-1320929086 > I do not have anything against this change. Only need to clarify `group_addrenv()` usage in general, but if overall behaviour is kept as before and change is well tested

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7623: arch/arm64: Move group_addrenv to arm64_syscall_switch

xiaoxiang781216 opened a new pull request, #7623: URL: https://github.com/apache/incubator-nuttx/pull/7623 ## Summary See the discussion here: https://github.com/apache/incubator-nuttx/pull/7599 ## Impact Code refactor ## Testing Pass CI -- This is an automated m

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7599: nuttx/sched: remove nxsched_remove_blocked from up_unblock_task

xiaoxiang781216 commented on code in PR #7599: URL: https://github.com/apache/incubator-nuttx/pull/7599#discussion_r1027118504 ## arch/arm64/src/common/arm64_unblocktask.c: ## @@ -43,102 +43,70 @@ * Name: up_unblock_task * * Description: - * A task is currently in an ina

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7622: Fix clang compiler warning

pkarashchenko commented on code in PR #7622: URL: https://github.com/apache/incubator-nuttx/pull/7622#discussion_r1027109940 ## arch/arm/src/imxrt/imxrt_enc.c: ## @@ -1011,10 +1011,9 @@ static int imxrt_shutdown(struct qe_lowerhalf_s *lower) /* Disable interrupts if used */

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1426: Fix clang compiler warning

pkarashchenko commented on code in PR #1426: URL: https://github.com/apache/incubator-nuttx-apps/pull/1426#discussion_r1027109606 ## examples/dac/dac_main.c: ## @@ -110,15 +110,15 @@ static void print_cmds(FAR const char *header, size_t ncmds,

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7614: SAMA5D2 pio errors

TimJTi commented on code in PR #7614: URL: https://github.com/apache/incubator-nuttx/pull/7614#discussion_r1027109592 ## arch/arm/src/sama5/hardware/_sama5d2x_memorymap.h: ## @@ -517,9 +520,10 @@ #define SAM_SFRBU_VBASE (SAM_PERIPHC_VSECTION+SAM_SFRBU_OFFSET) #define

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1426: Fix clang compiler warning

xiaoxiang781216 opened a new pull request, #1426: URL: https://github.com/apache/incubator-nuttx-apps/pull/1426 ## Summary Found by https://github.com/apache/incubator-nuttx/pull/7391 ## Impact Minor ## Testing Pass CI -- This is an automated message from the Apa

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7622: Fix clang compiler warning

xiaoxiang781216 opened a new pull request, #7622: URL: https://github.com/apache/incubator-nuttx/pull/7622 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7614: SAMA5D2 pio errors

pkarashchenko commented on code in PR #7614: URL: https://github.com/apache/incubator-nuttx/pull/7614#discussion_r1027108915 ## arch/arm/src/sama5/hardware/_sama5d2x_memorymap.h: ## @@ -517,9 +520,10 @@ #define SAM_SFRBU_VBASE (SAM_PERIPHC_VSECTION+SAM_SFRBU_OFFSET) #

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7614: SAMA5D2 pio errors

TimJTi commented on code in PR #7614: URL: https://github.com/apache/incubator-nuttx/pull/7614#discussion_r1027106905 ## arch/arm/src/sama5/hardware/_sama5d2x_memorymap.h: ## @@ -517,9 +520,10 @@ #define SAM_SFRBU_VBASE (SAM_PERIPHC_VSECTION+SAM_SFRBU_OFFSET) #define

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7614: SAMA5D2 pio errors

pkarashchenko commented on code in PR #7614: URL: https://github.com/apache/incubator-nuttx/pull/7614#discussion_r1027106687 ## arch/arm/src/sama5/hardware/_sama5d2x_memorymap.h: ## @@ -517,9 +520,10 @@ #define SAM_SFRBU_VBASE (SAM_PERIPHC_VSECTION+SAM_SFRBU_OFFSET) #

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7614: SAMA5D2 pio errors

TimJTi commented on code in PR #7614: URL: https://github.com/apache/incubator-nuttx/pull/7614#discussion_r1027106631 ## arch/arm/src/sama5/sama5d2x_pio.c: ## @@ -262,6 +262,32 @@ static uint32_t sam_configcommon(pio_pinset_t cfgset) break; } + /* Select Input Eve

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1425: wapi: fix save_config can not update if string prefix is same

pkarashchenko commented on code in PR #1425: URL: https://github.com/apache/incubator-nuttx-apps/pull/1425#discussion_r1027106429 ## wireless/wapi/src/util.c: ## @@ -148,7 +148,7 @@ static bool wapi_json_update(FAR cJSON *root, int len = strlen(obj->valuestring);

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7614: SAMA5D2 pio errors

TimJTi commented on code in PR #7614: URL: https://github.com/apache/incubator-nuttx/pull/7614#discussion_r1027106510 ## arch/arm/src/sama5/hardware/_sama5d2x_memorymap.h: ## @@ -517,9 +520,10 @@ #define SAM_SFRBU_VBASE (SAM_PERIPHC_VSECTION+SAM_SFRBU_OFFSET) #define

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1423: fix issue with reading ipv6 routes.

pkarashchenko commented on code in PR #1423: URL: https://github.com/apache/incubator-nuttx-apps/pull/1423#discussion_r1027105886 ## netutils/netlib/netlib_ipv6route.c: ## @@ -131,9 +131,12 @@ ssize_t netlib_read_ipv6route(FILE *stream, return 0; } - /* The first

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7599: nuttx/sched: remove nxsched_remove_blocked from up_unblock_task

pkarashchenko commented on code in PR #7599: URL: https://github.com/apache/incubator-nuttx/pull/7599#discussion_r1027104724 ## arch/arm64/src/common/arm64_unblocktask.c: ## @@ -43,102 +43,70 @@ * Name: up_unblock_task * * Description: - * A task is currently in an inact

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7614: SAMA5D2 pio errors

pkarashchenko commented on code in PR #7614: URL: https://github.com/apache/incubator-nuttx/pull/7614#discussion_r1027102529 ## arch/arm/src/sama5/Kconfig: ## @@ -3244,13 +3244,15 @@ config SAMA5_ADC_SEQUENCER config SAMA5_ADC_ANARCH bool "Analog changes" defaul

[GitHub] [incubator-nuttx-apps] zhhyu7 opened a new pull request, #1425: wapi: fix save_config can not update if string prefix is same

zhhyu7 opened a new pull request, #1425: URL: https://github.com/apache/incubator-nuttx-apps/pull/1425 Signed-off-by: zhanghongyu ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log