TimJTi commented on code in PR #7614: URL: https://github.com/apache/incubator-nuttx/pull/7614#discussion_r1027106510
########## arch/arm/src/sama5/hardware/_sama5d2x_memorymap.h: ########## @@ -517,9 +520,10 @@ #define SAM_SFRBU_VBASE (SAM_PERIPHC_VSECTION+SAM_SFRBU_OFFSET) #define SAM_CHIPID_VBASE (SAM_PERIPHC_VSECTION+SAM_CHIPID_OFFSET) -#define SAM_PIOA_VBASE (SAM_PERIPHA_VSECTION+SAM_PIO_OFFSET) -#define SAM_PIOB_VBASE (SAM_PERIPHB_VSECTION+SAM_PIO_OFFSET) -#define SAM_PIOC_VBASE (SAM_PERIPHC_VSECTION+SAM_PIO_OFFSET) +#define SAM_PIOA_VBASE (SAM_PIO_VBASE) +#define SAM_PIOB_VBASE (SAM_PIO_VBASE+SAM_PIOB_OFFSET) +#define SAM_PIOC_VBASE (SAM_PIO_VBASE+SAM_PIOC_OFFSET) +#define SAM_PIOD_VBASE (SAM_PIO_VBASE+SAM_PIOD_OFFSET) Review Comment: I did wonder about that, and happy to take that suggestion on board. Will change it on Monday and re-push, once I've worked through all the Kconfig blunders you've found <embarrassed> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
