xiaoxiang781216 commented on code in PR #7622:
URL: https://github.com/apache/incubator-nuttx/pull/7622#discussion_r1027121681
##########
arch/arm/src/s32k1xx/s32k1xx_enet.c:
##########
@@ -1217,8 +1217,8 @@ static int s32k1xx_ifup_action(struct net_driver_s *dev,
bool resetphy)
int ret;
ninfo("Bringing up: %d.%d.%d.%d\n",
- dev->d_ipaddr & 0xff, (dev->d_ipaddr >> 8) & 0xff,
- (dev->d_ipaddr >> 16) & 0xff, dev->d_ipaddr >> 24);
+ (int)(dev->d_ipaddr & 0xff), (int)((dev->d_ipaddr >> 8) & 0xff),
+ (int)((dev->d_ipaddr >> 16) & 0xff), (int)(dev->d_ipaddr >> 24));
Review Comment:
Even we change to %u, the cast is still needed since [u]int32_t map to
[unsigned ]long int not [unsigned ]int when we compile the source code with
gcc. And this is the same approach used by @yamt here:
https://github.com/apache/incubator-nuttx/commit/9d02bbcfdde8636436ac9341a3a8a6018781281e#diff-19e666bb08f6d2cc2b3d6e41b78563b129ef0724f6f637f1345456c8740770eeR1160-R1163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
