xiaoxiang781216 commented on code in PR #1426: URL: https://github.com/apache/incubator-nuttx-apps/pull/1426#discussion_r1027120483
########## examples/foc/foc_fixed16_thr.c: ########## @@ -185,9 +185,10 @@ int foc_fixed16_thr(FAR struct foc_ctrl_env_s *envp) struct foc_mq_s handle; struct foc_motor_b16_s motor; struct foc_device_s dev; - int time = 0; - int ret = OK; + int time = 0; Review Comment: Can't since time is also used in other places which isn't guarded by FOC_STATE_PRINT_PRE: https://github.com/apache/incubator-nuttx-apps/pull/1426/files#diff-df4ad1889816b80fd16d4fa0906888c2f9313974ee14e02acd88231f569c7afcR234 https://github.com/apache/incubator-nuttx-apps/pull/1426/files#diff-df4ad1889816b80fd16d4fa0906888c2f9313974ee14e02acd88231f569c7afcR372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
